From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Date: Wed, 16 Oct 2019 17:35:42 -0300 Message-ID: References: <87h8eq332i.fsf@gmail.com> <87h84a6e42.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="132537"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 33959@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 22:37:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKq2k-000YMR-As for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 22:37:14 +0200 Original-Received: from localhost ([::1]:48042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKq2i-0006yg-T4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 16:37:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41967) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKq2d-0006yN-2b for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:37:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKq2c-0005dj-59 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:37:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37845) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKq2b-0005dc-Vt for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:37:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKq2X-0002Tl-VR for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:37:05 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 20:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33959-submit@debbugs.gnu.org id=B33959.15712581629450 (code B ref 33959); Wed, 16 Oct 2019 20:37:01 +0000 Original-Received: (at 33959) by debbugs.gnu.org; 16 Oct 2019 20:36:02 +0000 Original-Received: from localhost ([127.0.0.1]:46666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKq1Z-0002SK-IS for submit@debbugs.gnu.org; Wed, 16 Oct 2019 16:36:01 -0400 Original-Received: from mail-yb1-f172.google.com ([209.85.219.172]:35788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKq1X-0002S1-MN for 33959@debbugs.gnu.org; Wed, 16 Oct 2019 16:36:00 -0400 Original-Received: by mail-yb1-f172.google.com with SMTP id i6so3863773ybe.2 for <33959@debbugs.gnu.org>; Wed, 16 Oct 2019 13:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/S68S9SUVq8QKbQwu+sUX/XkcURILZNoMtArEPTy0yM=; b=PZpw5UM56/UZoGXyqV7/B8W/R/7neJ49evekD5q/cMjGkGcVmwYLI0n6JYYpS181KY Rfv9QYEvD25p6g+hyfuGoHaXSsI4W6vZ8ZbVO2+fKR9F0fZ2CuRppIetgPPsXgYQy/Yw 71rrPC9kr2067DReTAPYOUugkIQsA1twWnabKMc9i+nbOoHjh9EqNrjMuFFkySlFWFNz DBu7mxvEdPmvyjQVXpxz8hN9hBlFPKNq4u2Vuge+uWecZFZG9tz75Vs9aXkW0GIG0KjS fZ6uZdVh7gDdcBI/xnRpH3MIsK65NhGQtglgjNrVE5Qg8VMIiCYxH9h1V2WnJiTdySVe iJIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/S68S9SUVq8QKbQwu+sUX/XkcURILZNoMtArEPTy0yM=; b=jnlQG/52J0cPToy79cQTcxoqK1ybkddb6PaMPgZZMloJJuacIJIK0oTc8t4fPS1lDt MrIAHPd+MgRrg0ek7/t7U74xRI0l0xKqPZZyDX31Cz07hM/kdfjBuZMq0e+kQ03B3dKL rg+ucREiXdS8HPTPNpYJemTpSWJnIfa4ioqcaySKUN1Ej9z0LeWsQSltULGfYDqFndHZ z2m3bWu6kJHyTddROd/JMEAoJvkjSW4a7X6ZfGSndmg1oVvk5MUem/SZ7fceVAFG+UIJ Xm6TuPJEh1KtRZHrY2QhWPwsI/aiH9tlqJGmRvmcA6cjbeGv+6csNQrs10rPigZaqdaJ d1Tw== X-Gm-Message-State: APjAAAUh3NzuiRIqqC8Fj+4HwbHy+JqSZpC0dbGdL5A8gRC0o34zGMKK XtnkD4TQowBIrJbYAZdGqaQCTMSQ7vD3kPP6XiI= X-Google-Smtp-Source: APXvYqypgRtQIEWSq24FtNIUNlqDxBd+odnRQRZGWiCvTcx7wCB1quhlVOUegYE/7bDxEYVVqKGEweBICnOTD10W97M= X-Received: by 2002:a25:42:: with SMTP id 63mr379204yba.454.1571258153937; Wed, 16 Oct 2019 13:35:53 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169498 Archived-At: Hi Noam, I don't want to be insistent (and I'm probably being) but it won't take much time for someone to complaint about [1] because it removed the `(not (string= "" output))` guard from the original code. As it is now, it's certainly buggy. I know it would be desirable to provide an unit test for [1] but this new commit I'm providing can't harm (remember it's just an "around advice": `(unless (string= output "") ... )`) and I believe my argument against the way the empty output condition was checked before is sound and simple enough. Thanks and sorry for the insistence. --- [1] 7acc621e3 (Fix python-shell font-lock cleanup for unclosed quotes (Bug#32390))