From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Date: Tue, 16 Apr 2019 18:47:19 -0300 Message-ID: References: <87zhp5ch5n.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="106459"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 33959@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 16 23:48:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGVw2-000RVS-Fy for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Apr 2019 23:48:10 +0200 Original-Received: from localhost ([127.0.0.1]:43276 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGVw1-0001in-Im for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Apr 2019 17:48:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGVvv-0001iX-0l for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2019 17:48:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGVvu-0004TW-3P for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2019 17:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53310) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGVvt-0004T1-SN for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2019 17:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hGVvt-0006RE-Kk for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2019 17:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Apr 2019 21:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33959-submit@debbugs.gnu.org id=B33959.155545125924719 (code B ref 33959); Tue, 16 Apr 2019 21:48:01 +0000 Original-Received: (at 33959) by debbugs.gnu.org; 16 Apr 2019 21:47:39 +0000 Original-Received: from localhost ([127.0.0.1]:38621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGVvX-0006Qc-GF for submit@debbugs.gnu.org; Tue, 16 Apr 2019 17:47:39 -0400 Original-Received: from mail-yb1-f169.google.com ([209.85.219.169]:39763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGVvV-0006QP-Ln for 33959@debbugs.gnu.org; Tue, 16 Apr 2019 17:47:38 -0400 Original-Received: by mail-yb1-f169.google.com with SMTP id x71so7815695ybe.6 for <33959@debbugs.gnu.org>; Tue, 16 Apr 2019 14:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yUhoJtLR1ujtRQZIX74K4/1kUzXIHXExTY5NWBORyj0=; b=qoUCaSJYyH+4dkRKj7IPG/nXFtdfUJxmcP9AMb0ONtr0/DJZx5GjBqNWziMHvUigpK h9Ea9YuSMY/B/+457lCmw+soi6QhHzHoM9IeRfNsckatiOUlw/oy2HWQcKsh45GfGr8N RKsci+PVSafO/8KiiKgIY2dNabnPFoiYCuEe0DpQNDtjsSWQtBKCSqz6bYAkOdBRAEz5 pP8AqxhE38f5ffQQJLqOmwLn19LxWrIogMxvfC8Y0ntK9qsojLBIlq53P4MSq+0Kp+3t MW0snoeNdgE9OLo4dJL+wTLMPUJwXZAz0tTRUMoQOnZLbvXpYrwH8hDlOqAQ/Fc54Rbo UiIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yUhoJtLR1ujtRQZIX74K4/1kUzXIHXExTY5NWBORyj0=; b=lG9rZc3HHE5yrTjYfv80Scz4295ytqclyCQt4eMy677sVhdCaIL0dQSfAb9d/BIklm phrzmkjfpjXDN8RxoflBnZG6cuiISnYANS+tHo7Tr+WPl3sRhJVKZGqSFu2EyYNf/mbg Lnvhen6Mxn/Kj5o0otKpt0y14Ah9dIyWgIjD05bA8FwUlrP3T4CsBJKrvqBjcUmyBsLu /otMI5d6GVQOriuIwUi5cYrjJI/qkldUM5OK+dyWSOoxpmea7NaYxTHy96X3PhOaGcfX VAQMib6xpyKTmohQISiyNBB5RvMildnt/7KHuTL+PKh5xg+yKPIxJc7IHA9fbyCoLlv1 w5lA== X-Gm-Message-State: APjAAAVXa7pQUjCkmucigWi4Cx4YqGfdvY36MlQ0e3CrhewyPgPkBST/ aHoR9tOe8TaADptRaFiTl/M+/liFjgeOrszWP+k= X-Google-Smtp-Source: APXvYqzQcS2yrHL28iT0vY83Xf2yP+ElTmqIzlgmChlfwezhKRzVo6rg0paAMuCFVhaSkT+nNB4DSioCZfCGrAPgris= X-Received: by 2002:a25:c281:: with SMTP id s123mr72030325ybf.401.1555451251993; Tue, 16 Apr 2019 14:47:31 -0700 (PDT) In-Reply-To: <87zhp5ch5n.fsf_-_@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157744 Archived-At: Hi Noam, > And my " *Python-font-lock*" looks like this: > > > 1 + len('123') + 99 + len('aa') > > > > 1 + len( > 1 + len('123' > 1 + len('123') + 99 + len('aa') > > The behaviour seems rather inconsistent. I think to solve this properly > we need some deterministic tests which reproduce the problem. The state of your " *Python-font-lock*" buffer is exactly what I mean. The duplications you see are caused by spurious newlines added when empty output is passed to the filter. There are two bad things there: i) empty strings are transformed into new lines and 2) empty strings are an undesirable side effect of company being triggered in a hidden buffer (this is analogous to the problem with org mode hidden buffer and yasnippet that I recently reported). Try disabling company mode in python font lock buffer; even though, this is not necessary if (i) above is fixed, which IMO should be done independently of the nasty company interaction. Besides, remember that patch 2 is fixing two different issues. This is somewhat undesirable but there are a lot of overlapping between them. Nevertheless, I provided patch 1 in case you are unwilling to apply one of them. Best regards -- Carlos