* bug#65154: vhdl-mode bug
@ 2023-08-08 17:55 Gonzalo Larumbe
2023-08-23 10:48 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Gonzalo Larumbe @ 2023-08-08 17:55 UTC (permalink / raw)
To: 65154
[-- Attachment #1.1: Type: text/plain, Size: 425 bytes --]
Hello,
While developing some features for `vhdl-ext` MELPA package (
https://github.com/gmlarumbe/vhdl-ext) I believe I have come across a bug
in `vhdl-mode` function `vhdl-corresponding-begin`.
Inside the cond block, for the "end component" condition, it seems that the
enclosing parentheses to set capture group 1 in the `looking-at` string
argument are missing.
I attach a simple patch that fixes it.
Thanks!
Gonzalo
[-- Attachment #1.2: Type: text/html, Size: 538 bytes --]
[-- Attachment #2: vhdl-corresponding-begin.patch --]
[-- Type: text/x-patch, Size: 509 bytes --]
diff --git a/lisp/progmodes/vhdl-mode.el b/lisp/progmodes/vhdl-mode.el
index 77d862f1a17..ccbe04db1e8 100644
--- a/lisp/progmodes/vhdl-mode.el
+++ b/lisp/progmodes/vhdl-mode.el
@@ -6198,7 +6198,7 @@ vhdl-corresponding-begin
(vhdl-first-word pos)
"else\\|then\\|use" nil))
;; "end component":
- ((looking-at "component\\b[^_]")
+ ((looking-at "\\(component\\)\\b[^_]")
(vector (buffer-substring (match-beginning 1)
(match-end 1))
(vhdl-first-word pos)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#65154: vhdl-mode bug
2023-08-08 17:55 bug#65154: vhdl-mode bug Gonzalo Larumbe
@ 2023-08-23 10:48 ` Stefan Kangas
2023-08-29 13:20 ` Reto Zimmermann
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2023-08-23 10:48 UTC (permalink / raw)
To: Gonzalo Larumbe, Reto Zimmermann; +Cc: 65154
Gonzalo Larumbe <gonzalomlarumbe@gmail.com> writes:
> Hello,
>
> While developing some features for `vhdl-ext` MELPA package (https://github.com/gmlarumbe/vhdl-ext) I believe I have come across a bug in `vhdl-mode` function `vhdl-corresponding-begin`.
>
> Inside the cond block, for the "end component" condition, it seems that the enclosing parentheses to set capture group 1 in the `looking-at` string argument are missing.
>
> I attach a simple patch that fixes it.
>
> Thanks!
>
> Gonzalo
Copying in vhdl-mode.el maintainer Reto Zimmermann.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-29 16:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-08 17:55 bug#65154: vhdl-mode bug Gonzalo Larumbe
2023-08-23 10:48 ` Stefan Kangas
2023-08-29 13:20 ` Reto Zimmermann
2023-08-29 16:47 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).