unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Gonzalo Larumbe <gonzalomlarumbe@gmail.com>
To: 65154@debbugs.gnu.org
Subject: bug#65154: vhdl-mode bug
Date: Tue, 8 Aug 2023 19:55:59 +0200	[thread overview]
Message-ID: <CADYqLo9=wyeFF4ZqC_jY8+7qv+5Gh19U1Gt4XEs7mipZy1Ho+g@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 425 bytes --]

Hello,

While developing some features for `vhdl-ext` MELPA package (
https://github.com/gmlarumbe/vhdl-ext) I believe I have come across a bug
in `vhdl-mode` function `vhdl-corresponding-begin`.

Inside the cond block, for the "end component" condition, it seems that the
enclosing parentheses to set capture group 1 in the `looking-at` string
argument are missing.

I attach a simple patch that fixes it.

Thanks!

Gonzalo

[-- Attachment #1.2: Type: text/html, Size: 538 bytes --]

[-- Attachment #2: vhdl-corresponding-begin.patch --]
[-- Type: text/x-patch, Size: 509 bytes --]

diff --git a/lisp/progmodes/vhdl-mode.el b/lisp/progmodes/vhdl-mode.el
index 77d862f1a17..ccbe04db1e8 100644
--- a/lisp/progmodes/vhdl-mode.el
+++ b/lisp/progmodes/vhdl-mode.el
@@ -6198,7 +6198,7 @@ vhdl-corresponding-begin
 		      (vhdl-first-word pos)
 		      "else\\|then\\|use" nil))
 	     ;; "end component":
-	     ((looking-at "component\\b[^_]")
+	     ((looking-at "\\(component\\)\\b[^_]")
 	      (vector (buffer-substring (match-beginning 1)
 					(match-end 1))
 		      (vhdl-first-word pos)

             reply	other threads:[~2023-08-08 17:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 17:55 Gonzalo Larumbe [this message]
2023-08-23 10:48 ` bug#65154: vhdl-mode bug Stefan Kangas
2023-08-29 13:20   ` Reto Zimmermann
2023-08-29 16:47     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADYqLo9=wyeFF4ZqC_jY8+7qv+5Gh19U1Gt4XEs7mipZy1Ho+g@mail.gmail.com' \
    --to=gonzalomlarumbe@gmail.com \
    --cc=65154@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).