bug#65154: vhdl-mode bug

bug#65154: vhdl-mode bug

[Gonzalo Larumbe]

[-- Attachment #1.1: Type: text/plain, Size: 425 bytes --]

Hello,

While developing some features for `vhdl-ext` MELPA package (
https://github.com/gmlarumbe/vhdl-ext) I believe I have come across a bug
in `vhdl-mode` function `vhdl-corresponding-begin`.

Inside the cond block, for the "end component" condition, it seems that the
enclosing parentheses to set capture group 1 in the `looking-at` string
argument are missing.

I attach a simple patch that fixes it.

Thanks!

Gonzalo

[-- Attachment #1.2: Type: text/html, Size: 538 bytes --]

[-- Attachment #2: vhdl-corresponding-begin.patch --]
[-- Type: text/x-patch, Size: 509 bytes --]

diff --git a/lisp/progmodes/vhdl-mode.el b/lisp/progmodes/vhdl-mode.el
index 77d862f1a17..ccbe04db1e8 100644
--- a/lisp/progmodes/vhdl-mode.el
+++ b/lisp/progmodes/vhdl-mode.el
@@ -6198,7 +6198,7 @@ vhdl-corresponding-begin
 		      (vhdl-first-word pos)
 		      "else\\|then\\|use" nil))
 	     ;; "end component":
-	     ((looking-at "component\\b[^_]")
+	     ((looking-at "\\(component\\)\\b[^_]")
 	      (vector (buffer-substring (match-beginning 1)
 					(match-end 1))
 		      (vhdl-first-word pos)

bug#65154: vhdl-mode bug

[Stefan Kangas]

Gonzalo Larumbe <gonzalomlarumbe@gmail.com> writes:

> Hello,
>
> While developing some features for `vhdl-ext` MELPA package (https://github.com/gmlarumbe/vhdl-ext) I believe I have come across a bug in `vhdl-mode` function `vhdl-corresponding-begin`.
>
> Inside the cond block, for the "end component" condition, it seems that the enclosing parentheses to set capture group 1 in the `looking-at` string argument are missing.
>
> I attach a simple patch that fixes it.
>
> Thanks!
>
> Gonzalo

Copying in vhdl-mode.el maintainer Reto Zimmermann.

bug#65154: vhdl-mode bug

[Reto Zimmermann]

Thanks for reporting the issue.  It is fixed in my latest version 3.39.2 at

https://iis.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html

Reto


On 2023-08-23 12:48, Stefan Kangas wrote:
> Gonzalo Larumbe <gonzalomlarumbe@gmail.com> writes:
>
>> Hello,
>>
>> While developing some features for `vhdl-ext` MELPA package (https://github.com/gmlarumbe/vhdl-ext) I believe I have come across a bug in `vhdl-mode` function `vhdl-corresponding-begin`.
>>
>> Inside the cond block, for the "end component" condition, it seems that the enclosing parentheses to set capture group 1 in the `looking-at` string argument are missing.
>>
>> I attach a simple patch that fixes it.
>>
>> Thanks!
>>
>> Gonzalo
> Copying in vhdl-mode.el maintainer Reto Zimmermann.

bug#65154: vhdl-mode bug

[Stefan Kangas]

forcemerge 65154 65464
thanks

Reto Zimmermann <reto@gnu.org> writes:

> Thanks for reporting the issue.  It is fixed in my latest version 3.39.2 at
>
> https://iis.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html

Thanks.  I'm therefore merging this bug with Bug#65464, which is about
upgrading vhdl-mode.el in Emacs itself.