* bug#52322: `make --question info` always fails
@ 2021-12-06 0:54 Stefan Kangas
2021-12-06 16:42 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2021-12-06 0:54 UTC (permalink / raw)
To: 52322; +Cc: Glenn Morris
This command on emacs-28 and master always fails:
make --question info
Here is a reproducer:
make info && make --question info || echo "failed"
This breaks the `make-dist` script, where we rely on `make --question
info' returning 0 to continue. I had to comment out that line to
produce the first pretest.
I have bisected this error to the following commit:
fddd63f8b854f6bfa91403f69ba694ccb54197bc is the first bad commit
commit fddd63f8b854f6bfa91403f69ba694ccb54197bc
Author: Glenn Morris <rgm@gnu.org>
Date: Fri Feb 26 19:28:43 2021 -0800
Distribute the real source for some doc/misc manuals (bug#45143)
* doc/misc/modus-themes.texi, doc/misc/org.texi:
Remove generated files from repository.
* doc/misc/Makefile.in: Add rules for building .texi from .org.
(ORG_SRC, abs_top_builddir, EMACS, emacs):
New variables.
(org_template): New template.
(orgclean): New phony target.
* Makefile.in (info): Depend on lisp.
* lisp/org/ox-texinfo.el (org-texinfo-export-to-texinfo-batch):
New function.
* doc/misc/org.org, doc/misc/org-setup.org: New files.
Import from https://code.orgmode.org d8e8a97a14.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#52322: `make --question info` always fails
2021-12-06 0:54 bug#52322: `make --question info` always fails Stefan Kangas
@ 2021-12-06 16:42 ` Glenn Morris
2021-12-06 20:57 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2021-12-06 16:42 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 52322
ISTM that src/Makefile.in has a problem, in that it wants globals.h to
be newer than gl-stamp, but the rule that generates globals.h ensures
the opposite is always true. So it always tries to rebuild globals.h
(even if it is a no-op).
Working around that, one is left with the issue that compile-clean
always runs, and make can't tell that it can be a no-op.
Perhaps just get rid of the --question test.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#52322: `make --question info` always fails
2021-12-06 16:42 ` Glenn Morris
@ 2021-12-06 20:57 ` Stefan Kangas
2021-12-14 2:23 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2021-12-06 20:57 UTC (permalink / raw)
To: Glenn Morris; +Cc: 52322
Glenn Morris <rgm@gnu.org> writes:
> ISTM that src/Makefile.in has a problem, in that it wants globals.h to
> be newer than gl-stamp, but the rule that generates globals.h ensures
> the opposite is always true. So it always tries to rebuild globals.h
> (even if it is a no-op).
>
> Working around that, one is left with the issue that compile-clean
> always runs, and make can't tell that it can be a no-op.
>
> Perhaps just get rid of the --question test.
Fine by me. AFAICT, we will run "make info" anyways.
Any other comments?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-14 2:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-06 0:54 bug#52322: `make --question info` always fails Stefan Kangas
2021-12-06 16:42 ` Glenn Morris
2021-12-06 20:57 ` Stefan Kangas
2021-12-14 2:23 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).