* bug#52322: `make --question info` always fails
@ 2021-12-06 0:54 Stefan Kangas
2021-12-06 16:42 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2021-12-06 0:54 UTC (permalink / raw)
To: 52322; +Cc: Glenn Morris
This command on emacs-28 and master always fails:
make --question info
Here is a reproducer:
make info && make --question info || echo "failed"
This breaks the `make-dist` script, where we rely on `make --question
info' returning 0 to continue. I had to comment out that line to
produce the first pretest.
I have bisected this error to the following commit:
fddd63f8b854f6bfa91403f69ba694ccb54197bc is the first bad commit
commit fddd63f8b854f6bfa91403f69ba694ccb54197bc
Author: Glenn Morris <rgm@gnu.org>
Date: Fri Feb 26 19:28:43 2021 -0800
Distribute the real source for some doc/misc manuals (bug#45143)
* doc/misc/modus-themes.texi, doc/misc/org.texi:
Remove generated files from repository.
* doc/misc/Makefile.in: Add rules for building .texi from .org.
(ORG_SRC, abs_top_builddir, EMACS, emacs):
New variables.
(org_template): New template.
(orgclean): New phony target.
* Makefile.in (info): Depend on lisp.
* lisp/org/ox-texinfo.el (org-texinfo-export-to-texinfo-batch):
New function.
* doc/misc/org.org, doc/misc/org-setup.org: New files.
Import from https://code.orgmode.org d8e8a97a14.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#52322: `make --question info` always fails
2021-12-06 0:54 bug#52322: `make --question info` always fails Stefan Kangas
@ 2021-12-06 16:42 ` Glenn Morris
2021-12-06 20:57 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2021-12-06 16:42 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 52322
ISTM that src/Makefile.in has a problem, in that it wants globals.h to
be newer than gl-stamp, but the rule that generates globals.h ensures
the opposite is always true. So it always tries to rebuild globals.h
(even if it is a no-op).
Working around that, one is left with the issue that compile-clean
always runs, and make can't tell that it can be a no-op.
Perhaps just get rid of the --question test.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#52322: `make --question info` always fails
2021-12-06 16:42 ` Glenn Morris
@ 2021-12-06 20:57 ` Stefan Kangas
2021-12-14 2:23 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2021-12-06 20:57 UTC (permalink / raw)
To: Glenn Morris; +Cc: 52322
Glenn Morris <rgm@gnu.org> writes:
> ISTM that src/Makefile.in has a problem, in that it wants globals.h to
> be newer than gl-stamp, but the rule that generates globals.h ensures
> the opposite is always true. So it always tries to rebuild globals.h
> (even if it is a no-op).
>
> Working around that, one is left with the issue that compile-clean
> always runs, and make can't tell that it can be a no-op.
>
> Perhaps just get rid of the --question test.
Fine by me. AFAICT, we will run "make info" anyways.
Any other comments?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#52322: `make --question info` always fails
2021-12-06 20:57 ` Stefan Kangas
@ 2021-12-14 2:23 ` Stefan Kangas
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2021-12-14 2:23 UTC (permalink / raw)
To: Glenn Morris; +Cc: 52322
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
close 52322 28.1
thanks
Stefan Kangas <stefan@marxist.se> writes:
> Glenn Morris <rgm@gnu.org> writes:
>
>> Perhaps just get rid of the --question test.
>
> Fine by me. AFAICT, we will run "make info" anyways.
>
> Any other comments?
There have been no further comments within over a week, so I've
installed the attached patch on the emacs-28 branch (commit 9de8eec3bc).
[-- Attachment #2: 0001-make-dist-Don-t-run-make-question-info-.-Bug-52322.patch --]
[-- Type: text/x-diff, Size: 786 bytes --]
From 9de8eec3bc9be2f6e7debf26159c1761c47df909 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Tue, 14 Dec 2021 03:08:37 +0100
Subject: [PATCH] * make-dist: Don't run "make --question info". (Bug#52322)
---
make-dist | 7 -------
1 file changed, 7 deletions(-)
diff --git a/make-dist b/make-dist
index b069130ca6..db7a74b82b 100755
--- a/make-dist
+++ b/make-dist
@@ -299,13 +299,6 @@ tempparent=
echo "${bogosities}"
fi
- ## This exits with non-zero status if any .info files need
- ## rebuilding.
- if [ -r Makefile ] && [ "$with_info" = "yes" ]; then
- echo "Checking to see if info files are up-to-date..."
- make --question info || error=yes
- fi
-
## Is this a release?
case $version in
[1-9][0-9].[0-9])
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-14 2:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-06 0:54 bug#52322: `make --question info` always fails Stefan Kangas
2021-12-06 16:42 ` Glenn Morris
2021-12-06 20:57 ` Stefan Kangas
2021-12-14 2:23 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).