unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Glenn Morris <rgm@gnu.org>
Cc: 52322@debbugs.gnu.org
Subject: bug#52322: `make --question info` always fails
Date: Mon, 13 Dec 2021 18:23:20 -0800	[thread overview]
Message-ID: <CADwFkmm7FdZ3SJntPeD-eZVh9Ta3xZmsN6uFiYGxb8tzP5cPuA@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmkwL3_3sh1UEJ=6SckrYrSg6ws59-wrkYN6RpB3chB+gw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

close 52322 28.1
thanks

Stefan Kangas <stefan@marxist.se> writes:

> Glenn Morris <rgm@gnu.org> writes:
>
>> Perhaps just get rid of the --question test.
>
> Fine by me.  AFAICT, we will run "make info" anyways.
>
> Any other comments?

There have been no further comments within over a week, so I've
installed the attached patch on the emacs-28 branch (commit 9de8eec3bc).

[-- Attachment #2: 0001-make-dist-Don-t-run-make-question-info-.-Bug-52322.patch --]
[-- Type: text/x-diff, Size: 786 bytes --]

From 9de8eec3bc9be2f6e7debf26159c1761c47df909 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Tue, 14 Dec 2021 03:08:37 +0100
Subject: [PATCH] * make-dist: Don't run "make --question info".  (Bug#52322)

---
 make-dist | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/make-dist b/make-dist
index b069130ca6..db7a74b82b 100755
--- a/make-dist
+++ b/make-dist
@@ -299,13 +299,6 @@ tempparent=
     echo "${bogosities}"
   fi
 
-  ## This exits with non-zero status if any .info files need
-  ## rebuilding.
-  if [ -r Makefile ] && [ "$with_info" = "yes" ]; then
-      echo "Checking to see if info files are up-to-date..."
-      make --question info || error=yes
-  fi
-
   ## Is this a release?
   case $version in
       [1-9][0-9].[0-9])
-- 
2.30.2


      reply	other threads:[~2021-12-14  2:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06  0:54 bug#52322: `make --question info` always fails Stefan Kangas
2021-12-06 16:42 ` Glenn Morris
2021-12-06 20:57   ` Stefan Kangas
2021-12-14  2:23     ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmm7FdZ3SJntPeD-eZVh9Ta3xZmsN6uFiYGxb8tzP5cPuA@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=52322@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).