unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Ernesto Alfonso <erjoalgo@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, Juri Linkov <juri@linkov.net>,
	Robert Pluim <rpluim@gmail.com>,
	32676@debbugs.gnu.org
Subject: bug#32676: [PATCH] Add option to highlight the 'next-error' error message
Date: Thu, 3 Sep 2020 03:40:30 -0700	[thread overview]
Message-ID: <CADwFkm=f+CkR483Fu+sAtjm5UrkLQ3wdsokb+umdEd_KwWm_2Q@mail.gmail.com> (raw)
In-Reply-To: <CAOckuXCHWB66tRfmwwuu_wc8HvWRd1it2qttKHO6fe3i-aeCeA@mail.gmail.com> (Ernesto Alfonso's message of "Thu, 3 Sep 2020 01:00:16 -0400")

Hi Ernesto,

Thanks for following up on this.

Ernesto Alfonso <erjoalgo@gmail.com> writes:

> I currently work for Google, and my understanding is that Google has a
> special agreement with the FSF. Please let me know if this is correct
> or if I still need to provide a copyright assignment.

Someone else will have to answer this.

> Also, I am not sure if this patch is still applicable.

In what way?  From reading the discussion, it seems like the feature was
considered useful, but there were some additional comments before it was
ready.  I copied in those comments below.  Could you have a look at
them?

Thanks in advance.

Juri Linkov <juri@linkov.net> writes:

>> I'd like to know if this patch is still being considered?
>
> Why not?  Your patch provides a helpful feature.  I see only 2 problems
> with its latest version:
>
> 1. compilation-current-error should be generalized not to be too
>    compilation-specific;
>
> 2. next-error-hook should not be used for core features,
>    you could call next-error-message-highlight directly
>    from next-error-found.
>
> PS: maybe a better name for defcustom would be next-error-message-highlight,
>     not next-error-message-highlight-p, to be more future-proof,
>     for the case when someone might want to add more choices later
>     (e.g. fringe, timers, etc.)

Best regards,
Stefan Kangas





  reply	other threads:[~2020-09-03 10:40 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10  5:08 bug#32676: [PATCH] Add option to highlight the 'next-error' error message Ernesto Alfonso
2018-09-13  7:10 ` bug#32676: Feature request Ernesto Alfonso
2018-09-13 13:59   ` Eli Zaretskii
2018-09-13 14:14     ` Robert Pluim
2018-09-13 15:02       ` Ernesto Alfonso
2018-09-13 16:44         ` Eli Zaretskii
2018-09-13 18:18           ` Ernesto Alfonso
2018-09-14 16:40             ` Ernesto Alfonso
2018-09-15 23:05               ` Juri Linkov
2018-09-16  0:37                 ` Ernesto Alfonso
2018-09-16 23:27                   ` Juri Linkov
2018-09-18  8:51                     ` Ernesto Alfonso
2019-04-07 21:56                       ` Ernesto Alfonso
2019-04-08 19:36                         ` bug#32676: [PATCH] Add option to highlight the 'next-error' error message Juri Linkov
2019-04-09  5:48                           ` Eli Zaretskii
2020-02-29 15:40                             ` Stefan Kangas
2020-08-10 12:38                               ` Lars Ingebrigtsen
2020-08-10 14:00                                 ` Ernesto Alfonso
2020-09-03  5:00                                   ` Ernesto Alfonso
2020-09-03 10:40                                     ` Stefan Kangas [this message]
2020-10-14  5:47                           ` Lars Ingebrigtsen
2020-10-14 19:30                             ` Juri Linkov
2020-10-15  7:19                               ` Lars Ingebrigtsen
2020-10-16  8:13                                 ` Juri Linkov
2020-10-16 14:48                                   ` Lars Ingebrigtsen
2020-10-17 20:24                                     ` Juri Linkov
2020-10-18  8:34                                       ` Lars Ingebrigtsen
2020-11-05 20:20                                   ` Juri Linkov
2020-11-05 22:05                                     ` Kévin Le Gouguec
2020-11-06  8:43                                       ` Juri Linkov
2020-11-06 22:06                                         ` bug#32676: Updating Org for 27.2 (was: bug#32676: [PATCH] Add option to highlight the 'next-error' error message) Kévin Le Gouguec
2020-11-09  9:03                                           ` bug#32676: Updating Org for 27.2 Juri Linkov
2020-11-09 12:17                                             ` Kévin Le Gouguec
2020-11-10  4:10                                               ` Kyle Meyer
2020-11-10 19:30                                               ` Juri Linkov
2020-11-10 20:02                                                 ` Glenn Morris
     [not found]   ` <CAOckuXD4--GF0E=eMWf-T74rEjrjt4CWfx97OWWszRay3P-ujQ@mail.gmail.com>
2018-09-13 16:14     ` bug#32676: Feature request Ernesto Alfonso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=f+CkR483Fu+sAtjm5UrkLQ3wdsokb+umdEd_KwWm_2Q@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=32676@debbugs.gnu.org \
    --cc=erjoalgo@gmail.com \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).