unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ernesto Alfonso <erjoalgo@gmail.com>
To: juri@linkov.net
Cc: Robert Pluim <rpluim@gmail.com>, 32676@debbugs.gnu.org
Subject: bug#32676: Feature request
Date: Sun, 7 Apr 2019 14:56:53 -0700	[thread overview]
Message-ID: <CAOckuXBZFSKh_oWRrVvaXO-72MYyo08Y1xWewnEZNZZXCL5iGQ@mail.gmail.com> (raw)
In-Reply-To: <CAOckuXBvsF59f_jxfTmpF6BGY+eRXBP9TofgwxY7+s72q8yARg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2424 bytes --]

I'd like to know if this patch is still being considered?

Ernesto

On Tue, Sep 18, 2018 at 1:51 AM Ernesto Alfonso <erjoalgo@gmail.com> wrote:

>
> I agree that a timer is not necessary in next-error-last-buffer.
>> I just wanted to emphasize that your new customization could be like
>> next-error-highlight defcustom (but without a timer option).
>
> Yes.
>
> It looks like (point) is always located
>> at this place because compilation-next-error-function sets
>> overlay-arrow-position to (point-marker), so it should be the
>> right place to highlight indeed.
>
> Yes. I tried replacing compilation-current-error with point and it works
> as expected. I am not sure how I would update the patch.
>
>
> While searching for this thread, I came across another time qhwn a user
> made a query for the same feature I am proposing.
>
> https://groups.google.com/forum/#!topic/gnu.emacs.help/q1QucyB1Nzw
>
> It provides another explanation of why hl-line doesn't work well in this
> case.
>
> Ernesto
> On Sun, Sep 16, 2018 at 4:38 PM Juri Linkov <juri@linkov.net> wrote:
>
>> >> Do I understand correctly that your proposed feature is like
>> >> next-error-highlight,
>> >> but instead of highlighting the error locus, it highlights the error
>> >> message?
>> >
>> > Yes, although I don't think it's important to support a timer to turn
>> off
>> > highlighting like next-error-highlight does since the error locus
>> > highlighting might get in the user's way in source buffers, but not in
>> the
>> > next-error buffer.
>>
>> I agree that a timer is not necessary in next-error-last-buffer.
>> I just wanted to emphasize that your new customization could be like
>> next-error-highlight defcustom (but without a timer option).
>>
>> > I don't see a reference to compilation-highlight-regexp or
>> > compilation-highlight-overlay in my patch or in this thread. Although I
>> did
>> > use compilation-current-error to find the mark at the error message
>> > location, which I think is not appropriate since that would be
>> > compilation-specific, and I think it should be (point) instead. Is this
>> > what you mean?
>>
>> I guess you need to highlight exactly the same place from where
>> the error was visited.  It looks like (point) is always located
>> at this place because compilation-next-error-function sets
>> overlay-arrow-position to (point-marker), so it should be the
>> right place to highlight indeed.
>>
>

[-- Attachment #2: Type: text/html, Size: 3717 bytes --]

  reply	other threads:[~2019-04-07 21:56 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10  5:08 bug#32676: [PATCH] Add option to highlight the 'next-error' error message Ernesto Alfonso
2018-09-13  7:10 ` bug#32676: Feature request Ernesto Alfonso
2018-09-13 13:59   ` Eli Zaretskii
2018-09-13 14:14     ` Robert Pluim
2018-09-13 15:02       ` Ernesto Alfonso
2018-09-13 16:44         ` Eli Zaretskii
2018-09-13 18:18           ` Ernesto Alfonso
2018-09-14 16:40             ` Ernesto Alfonso
2018-09-15 23:05               ` Juri Linkov
2018-09-16  0:37                 ` Ernesto Alfonso
2018-09-16 23:27                   ` Juri Linkov
2018-09-18  8:51                     ` Ernesto Alfonso
2019-04-07 21:56                       ` Ernesto Alfonso [this message]
2019-04-08 19:36                         ` bug#32676: [PATCH] Add option to highlight the 'next-error' error message Juri Linkov
2019-04-09  5:48                           ` Eli Zaretskii
2020-02-29 15:40                             ` Stefan Kangas
2020-08-10 12:38                               ` Lars Ingebrigtsen
2020-08-10 14:00                                 ` Ernesto Alfonso
2020-09-03  5:00                                   ` Ernesto Alfonso
2020-09-03 10:40                                     ` Stefan Kangas
2020-10-14  5:47                           ` Lars Ingebrigtsen
2020-10-14 19:30                             ` Juri Linkov
2020-10-15  7:19                               ` Lars Ingebrigtsen
2020-10-16  8:13                                 ` Juri Linkov
2020-10-16 14:48                                   ` Lars Ingebrigtsen
2020-10-17 20:24                                     ` Juri Linkov
2020-10-18  8:34                                       ` Lars Ingebrigtsen
2020-11-05 20:20                                   ` Juri Linkov
2020-11-05 22:05                                     ` Kévin Le Gouguec
2020-11-06  8:43                                       ` Juri Linkov
2020-11-06 22:06                                         ` bug#32676: Updating Org for 27.2 (was: bug#32676: [PATCH] Add option to highlight the 'next-error' error message) Kévin Le Gouguec
2020-11-09  9:03                                           ` bug#32676: Updating Org for 27.2 Juri Linkov
2020-11-09 12:17                                             ` Kévin Le Gouguec
2020-11-10  4:10                                               ` Kyle Meyer
2020-11-10 19:30                                               ` Juri Linkov
2020-11-10 20:02                                                 ` Glenn Morris
     [not found]   ` <CAOckuXD4--GF0E=eMWf-T74rEjrjt4CWfx97OWWszRay3P-ujQ@mail.gmail.com>
2018-09-13 16:14     ` bug#32676: Feature request Ernesto Alfonso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOckuXBZFSKh_oWRrVvaXO-72MYyo08Y1xWewnEZNZZXCL5iGQ@mail.gmail.com \
    --to=erjoalgo@gmail.com \
    --cc=32676@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).