From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#32676: [PATCH] Add option to highlight the 'next-error' error message Date: Thu, 3 Sep 2020 03:40:30 -0700 Message-ID: References: <20180910050802.25922-1-erjoalgo@gmail.com> <83a7ollcq2.fsf@gnu.org> <874let1o3k.fsf@gmail.com> <831s9xl54b.fsf@gnu.org> <874leq1hw4.fsf@mail.linkov.net> <87worlgh0k.fsf@mail.linkov.net> <878swkxqo1.fsf_-_@mail.linkov.net> <83wok37mqd.fsf@gnu.org> <878skl767i.fsf@stefankangas.se> <87blji65go.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32744"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Juri Linkov , Robert Pluim , 32676@debbugs.gnu.org To: Ernesto Alfonso Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 03 12:45:35 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDmkJ-0008QU-73 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Sep 2020 12:45:35 +0200 Original-Received: from localhost ([::1]:32940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDmkI-0006YM-4G for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Sep 2020 06:45:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDmfv-00063T-0m for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2020 06:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDmfu-0002Hl-GV for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2020 06:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kDmfu-0007O1-BU for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2020 06:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Sep 2020 10:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32676-submit@debbugs.gnu.org id=B32676.159912963928342 (code B ref 32676); Thu, 03 Sep 2020 10:41:02 +0000 Original-Received: (at 32676) by debbugs.gnu.org; 3 Sep 2020 10:40:39 +0000 Original-Received: from localhost ([127.0.0.1]:33603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDmfX-0007N3-4s for submit@debbugs.gnu.org; Thu, 03 Sep 2020 06:40:39 -0400 Original-Received: from mail-ej1-f46.google.com ([209.85.218.46]:43755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDmfV-0007Mr-1i for 32676@debbugs.gnu.org; Thu, 03 Sep 2020 06:40:37 -0400 Original-Received: by mail-ej1-f46.google.com with SMTP id m22so3124429eje.10 for <32676@debbugs.gnu.org>; Thu, 03 Sep 2020 03:40:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=SAaeT6AZVwsyZQSGxmaPbCy2w4Es22KvDQa/TDjZR3c=; b=tWTYxZzFPJNJkAhz07CrgZFEceABush9WZ4GJs0vyKEyIp59RXdW1C08lYZ5cW0fZ5 Ykm5T4QAaXK30WrHokPOA76a8VSZ/pPp0SqIzaFAle/u+XfAv1jZj7Ns04+TzW4osAMD dwWYMuadT09GNCZo+8ZgIpmD+4bOcTaQlhifGvSCaKlAwcfrXqSnIMyZ6HENFcaprEeA wyxd8TuVvJDLsEtzfBMV7oa1j9JygePjGiw+Bi1XVex7V6pKsWIx47EojoqwF2IZMSiF cDEiJmYKIzHFairMeAJQ/Zk6bBidhsckRgmD+szlca1oyLPVIkJx8AOYaTy1d/67/1hB O6FA== X-Gm-Message-State: AOAM532Ams2bOD3dBNmT2YHCkZWnk/6Ai0sFfmnPhGBLY7WBcvhza/OG pCfTSlTqhw2/vePRACPzjbGPs/hPBVjc2xXc/Wk= X-Google-Smtp-Source: ABdhPJxfuzySkboJEKEsiy7wMrZJU+3hi0DQRQY+plEkfZHFH6yUmjP+ACgGIoYfGtYG45hNzXcumAi6fkuJZJymgu0= X-Received: by 2002:a17:906:bb0e:: with SMTP id jz14mr1465059ejb.525.1599129631185; Thu, 03 Sep 2020 03:40:31 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 3 Sep 2020 03:40:30 -0700 In-Reply-To: (Ernesto Alfonso's message of "Thu, 3 Sep 2020 01:00:16 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186999 Archived-At: Hi Ernesto, Thanks for following up on this. Ernesto Alfonso writes: > I currently work for Google, and my understanding is that Google has a > special agreement with the FSF. Please let me know if this is correct > or if I still need to provide a copyright assignment. Someone else will have to answer this. > Also, I am not sure if this patch is still applicable. In what way? From reading the discussion, it seems like the feature was considered useful, but there were some additional comments before it was ready. I copied in those comments below. Could you have a look at them? Thanks in advance. Juri Linkov writes: >> I'd like to know if this patch is still being considered? > > Why not? Your patch provides a helpful feature. I see only 2 problems > with its latest version: > > 1. compilation-current-error should be generalized not to be too > compilation-specific; > > 2. next-error-hook should not be used for core features, > you could call next-error-message-highlight directly > from next-error-found. > > PS: maybe a better name for defcustom would be next-error-message-highlight, > not next-error-message-highlight-p, to be more future-proof, > for the case when someone might want to add more choices later > (e.g. fringe, timers, etc.) Best regards, Stefan Kangas