From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Ernesto Alfonso <erjoalgo@gmail.com>,
Robert Pluim <rpluim@gmail.com>,
32676@debbugs.gnu.org
Subject: bug#32676: [PATCH] Add option to highlight the 'next-error' error message
Date: Wed, 14 Oct 2020 22:30:55 +0300 [thread overview]
Message-ID: <874kmwy7k8.fsf@mail.linkov.net> (raw)
In-Reply-To: <874kmxz7e0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 14 Oct 2020 07:47:03 +0200")
> I've now applied the patch (after reworking slightly), and it seems to
> work well, so I've pushed it to Emacs 28.
>
>> 1. compilation-current-error should be generalized not to be too
>> compilation-specific;
>
> Reading the code, it looks like that variable is always set, even in
> grep buffers and the like? So it's a bad name, but...
Unsurprisingly, now using occur fails with the error
next-error-found: Symbol’s value as variable is void: compilation-current-error
and when compile.el is loaded, occur fails with the error
next-error-found: Wrong type argument: integer-or-marker-p, nil
This fails only when next-error-message-highlight is customized to t,
so there is no need to revert the patch, but it should be fixed ASAP.
> Is there a different variable that should be used instead?
I can't find another variable. Maybe a new variable should be created,
with a name like next-error-current.
Then compilation-current-error could be declared as an obsolete alias.
Or maybe there is no need to remove the old variable, so they both
could be used: compilation-current-error in compilation-mode,
and next-error-current elsewhere.
PS: I see compilation-current-error is used also in
next-error-follow-mode-post-command-hook, and it works fine
when 'C-c C-f' (next-error-follow-minor-mode)
in enabled in occur buffers.
next prev parent reply other threads:[~2020-10-14 19:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 5:08 bug#32676: [PATCH] Add option to highlight the 'next-error' error message Ernesto Alfonso
2018-09-13 7:10 ` bug#32676: Feature request Ernesto Alfonso
2018-09-13 13:59 ` Eli Zaretskii
2018-09-13 14:14 ` Robert Pluim
2018-09-13 15:02 ` Ernesto Alfonso
2018-09-13 16:44 ` Eli Zaretskii
2018-09-13 18:18 ` Ernesto Alfonso
2018-09-14 16:40 ` Ernesto Alfonso
2018-09-15 23:05 ` Juri Linkov
2018-09-16 0:37 ` Ernesto Alfonso
2018-09-16 23:27 ` Juri Linkov
2018-09-18 8:51 ` Ernesto Alfonso
2019-04-07 21:56 ` Ernesto Alfonso
2019-04-08 19:36 ` bug#32676: [PATCH] Add option to highlight the 'next-error' error message Juri Linkov
2019-04-09 5:48 ` Eli Zaretskii
2020-02-29 15:40 ` Stefan Kangas
2020-08-10 12:38 ` Lars Ingebrigtsen
2020-08-10 14:00 ` Ernesto Alfonso
2020-09-03 5:00 ` Ernesto Alfonso
2020-09-03 10:40 ` Stefan Kangas
2020-10-14 5:47 ` Lars Ingebrigtsen
2020-10-14 19:30 ` Juri Linkov [this message]
2020-10-15 7:19 ` Lars Ingebrigtsen
2020-10-16 8:13 ` Juri Linkov
2020-10-16 14:48 ` Lars Ingebrigtsen
2020-10-17 20:24 ` Juri Linkov
2020-10-18 8:34 ` Lars Ingebrigtsen
2020-11-05 20:20 ` Juri Linkov
2020-11-05 22:05 ` Kévin Le Gouguec
2020-11-06 8:43 ` Juri Linkov
2020-11-06 22:06 ` bug#32676: Updating Org for 27.2 (was: bug#32676: [PATCH] Add option to highlight the 'next-error' error message) Kévin Le Gouguec
2020-11-09 9:03 ` bug#32676: Updating Org for 27.2 Juri Linkov
2020-11-09 12:17 ` Kévin Le Gouguec
2020-11-10 4:10 ` Kyle Meyer
2020-11-10 19:30 ` Juri Linkov
2020-11-10 20:02 ` Glenn Morris
[not found] ` <CAOckuXD4--GF0E=eMWf-T74rEjrjt4CWfx97OWWszRay3P-ujQ@mail.gmail.com>
2018-09-13 16:14 ` bug#32676: Feature request Ernesto Alfonso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kmwy7k8.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=32676@debbugs.gnu.org \
--cc=erjoalgo@gmail.com \
--cc=larsi@gnus.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).