From: Stefan Kangas <stefankangas@gmail.com>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Robert Pluim <rpluim@gmail.com>, Dmitry Gutov <dgutov@yandex.ru>,
Protesilaos Stavrou <info@protesilaos.com>,
58092@debbugs.gnu.org
Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face
Date: Tue, 27 Sep 2022 12:15:29 -0400 [thread overview]
Message-ID: <CADwFkm=_ixgj4C1xm3AtVBrqbVqv42YeC80DaPya6=Nfhp2i3Q@mail.gmail.com> (raw)
In-Reply-To: <87h70szuig.fsf@melete.silentflame.com>
Sean Whitton <spwhitton@spwhitton.name> writes:
>>> amend no. revert yes, but itʼs overkill for just a commit message issue. You
>>> can always run 'make change-history' and fix it in the resulting
>>> ChangeLog file (see admin/notes/repo for the details)
>>
>> Please don't do that, it will make merging more tricky later.
>
> Hmm, so it's never okay to do that? Or is it to be saved for the more
> egregrious errors?
It's easier for me (or whoever is charge of merging and/or releases) if
we don't do that, so I'd prefer it if we could reserve it for
particularly nasty mistakes.
However, if it has to be done, please do it in two separate commits: one
that generates the ChangeLog and one that fixes the mistake.
next prev parent reply other threads:[~2022-09-27 16:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 12:44 bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Protesilaos Stavrou
2022-09-26 13:20 ` Lars Ingebrigtsen
2022-09-26 13:22 ` Stefan Kangas
2022-09-26 13:28 ` Dmitry Gutov
2022-09-26 14:06 ` Protesilaos Stavrou
2022-09-26 14:32 ` Dmitry Gutov
2022-09-26 14:40 ` Robert Pluim
2022-09-26 14:49 ` Stefan Kangas
2022-09-26 14:55 ` Protesilaos Stavrou
2022-09-27 15:50 ` Sean Whitton
2022-09-27 16:15 ` Stefan Kangas [this message]
2022-09-28 0:49 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=_ixgj4C1xm3AtVBrqbVqv42YeC80DaPya6=Nfhp2i3Q@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=58092@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=info@protesilaos.com \
--cc=larsi@gnus.org \
--cc=rpluim@gmail.com \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).