From: Protesilaos Stavrou <info@protesilaos.com>
To: 58092@debbugs.gnu.org
Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face
Date: Mon, 26 Sep 2022 15:44:50 +0300 [thread overview]
Message-ID: <87bkr2mhj1.fsf@protesilaos.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
Dear maintainers,
The attached patch replaces some hardcoded face properties in log-edit
buffers with a named face.
The named face allows users/themes to customise how this line is styled.
What do you think?
All the best,
Protesilaos (or simply "Prot")
--
Protesilaos Stavrou
https://protesilaos.com
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-log-edit-summary-separator-face.patch --]
[-- Type: text/x-patch, Size: 2078 bytes --]
From ea287b3d918c6a2cf6181c5671187143b3774bd5 Mon Sep 17 00:00:00 2001
Message-Id: <ea287b3d918c6a2cf6181c5671187143b3774bd5.1664196100.git.info@protesilaos.com>
From: Protesilaos Stavrou <info@protesilaos.com>
Date: Mon, 26 Sep 2022 15:41:18 +0300
Subject: [PATCH] Add log-edit-summary-separator face
* etc/NEWS: Report on it.
* lisp/vc/log-edit.el (log-edit-summary-separator): Add new face.
(log-edit-font-lock-keywords): Replace hardcoded face attributes with
named face.
---
etc/NEWS | 5 +++++
lisp/vc/log-edit.el | 6 +++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/etc/NEWS b/etc/NEWS
index 0a5b7bc29c..ced4ece35d 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1766,6 +1766,11 @@ Writing shorter summary lines avoids truncation in contexts in which
Git commands display summary lines. See the two new user options
'vc-git-log-edit-summary-target-len' and 'vc-git-log-edit-summary-max-len'.
+---
+*** New 'log-edit-summary-separator' face
+Styles the line that separates the log-edit headers from the log-edit
+summary.
+
** Message
---
diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el
index 5290616302..25b47a75af 100644
--- a/lisp/vc/log-edit.el
+++ b/lisp/vc/log-edit.el
@@ -325,6 +325,10 @@ ;;; Actual code
(defface log-edit-summary '((t :inherit font-lock-function-name-face))
"Face for the summary in `log-edit-mode' buffers.")
+(defface log-edit-summary-separator '((t :height 0.1 :inverse-video t :extend t))
+ "Face for the summary separator line in `log-edit-mode' buffers."
+ :version "29.1")
+
(defface log-edit-header '((t :inherit font-lock-keyword-face))
"Face for the headers in `log-edit-mode' buffers.")
@@ -393,7 +397,7 @@ (defvar log-edit-font-lock-keywords
nil lax))
("^\n"
(progn (goto-char (match-end 0)) (1+ (match-end 0))) nil
- (0 '(face (:height 0.1 :inverse-video t :extend t)
+ (0 '(face log-edit-summary-separator
display-line-numbers-disable t rear-nonsticky t))))
(log-edit--match-first-line (0 'log-edit-summary))))
--
2.37.3
next reply other threads:[~2022-09-26 12:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 12:44 Protesilaos Stavrou [this message]
2022-09-26 13:20 ` bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Lars Ingebrigtsen
2022-09-26 13:22 ` Stefan Kangas
2022-09-26 13:28 ` Dmitry Gutov
2022-09-26 14:06 ` Protesilaos Stavrou
2022-09-26 14:32 ` Dmitry Gutov
2022-09-26 14:40 ` Robert Pluim
2022-09-26 14:49 ` Stefan Kangas
2022-09-26 14:55 ` Protesilaos Stavrou
2022-09-27 15:50 ` Sean Whitton
2022-09-27 16:15 ` Stefan Kangas
2022-09-28 0:49 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkr2mhj1.fsf@protesilaos.com \
--to=info@protesilaos.com \
--cc=58092@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).