From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Date: Tue, 27 Sep 2022 12:15:29 -0400 Message-ID: References: <87bkr2mhj1.fsf@protesilaos.com> <87a66mdych.fsf@protesilaos.com> <87czbi9p23.fsf@gmail.com> <87h70szuig.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4682"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Robert Pluim , Dmitry Gutov , Protesilaos Stavrou , 58092@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 27 18:39:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odDbz-0000wr-Nt for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 18:39:11 +0200 Original-Received: from localhost ([::1]:33770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odDby-0002rK-Of for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 12:39:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odDFa-0006cg-Oz for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 12:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odDFa-0004Tv-DT for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 12:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odDFa-0003iE-19 for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 12:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Sep 2022 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.166429534014232 (code B ref 58092); Tue, 27 Sep 2022 16:16:01 +0000 Original-Received: (at 58092) by debbugs.gnu.org; 27 Sep 2022 16:15:40 +0000 Original-Received: from localhost ([127.0.0.1]:56618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odDFD-0003hU-VW for submit@debbugs.gnu.org; Tue, 27 Sep 2022 12:15:40 -0400 Original-Received: from mail-oa1-f46.google.com ([209.85.160.46]:39697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odDFA-0003hE-7C for 58092@debbugs.gnu.org; Tue, 27 Sep 2022 12:15:38 -0400 Original-Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-11e9a7135easo13904186fac.6 for <58092@debbugs.gnu.org>; Tue, 27 Sep 2022 09:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date; bh=t26rNQLSUXGq1b9OgMgZcmgwIlBqat7a3BSmmc304Ts=; b=VmwGc7AZeGLvZtHMInj3ucD3mF9MKyI9UZrZOhYYqmYEixC2NaBPfu42EHHAri5gog AUgRi5quiajtGghiraUOVNpRjQaFPof4fgYFj3YMXNal7sB6YZELwbSDvifw8+wEl0Zq Kh74vjQLn7adzt7FvLM6d0Lp7fLIkehELLWOQC9bDZDSOVwv0GrEbzvQDJQ3Qar+w168 H2WdEaBTbYgXGos0E9aGbwPaNUY/STXpx7tgLrpQPaSCpEmPX5Ngd3r0iGZVks5hTaS2 gl2iZpQBiaR+KF9mfVdBDBWtCLvhgDtD0quY8Yv/Fam2E3h8tMGdQDKm33sXzxEMal2b Sriw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date; bh=t26rNQLSUXGq1b9OgMgZcmgwIlBqat7a3BSmmc304Ts=; b=U747Y0jYgbCudpgN5Oljz3xsL9izdiqh0qQ481jUt7PT373QEJXGLVidB6l8pUKHho 29CENh4TWEk8SkW8aNW5SAqG34C9akIiKo7MFCt3n1cAPE6iZhaW2isc718JB1GgcCNB XDHGFaW7CEhZYfx0DaUsKGFEmPPgKFlDc3qg3PtAzRpdvpQt8EBYVi3iO17+Mqa07+Bn 9gWQcy9yCPCc6U+IlkWk3u5EH7EQ3/0gNuxs4f0klop/laXKzRbBs3df2ptYwzjxbC2c 9lD2/q1noWburvldIJ95PMdhyLXLKFx0TTOVzDyEFPffo+XG4Rbz8u1ZKTKr68LibDoe vxVA== X-Gm-Message-State: ACrzQf2TnKtyXYU+x1O0VLsa1IIlpC32t52dF/4+ackjvEal2eqqMGCT w2Dtue9IpOI/WQyW/Dy7kIu308cacTRPCXEJye0= X-Google-Smtp-Source: AMsMyM7ooJO2pGeqPwwsVtO5rgFl9NieooKg2WWvlcwEqu13Jrxo5JCuTkyvmyrx3loAMFSPAAVldjvNWHj1zP2VCOw= X-Received: by 2002:a05:6870:46a6:b0:12d:130c:2fd5 with SMTP id a38-20020a05687046a600b0012d130c2fd5mr2593346oap.92.1664295330308; Tue, 27 Sep 2022 09:15:30 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 27 Sep 2022 12:15:29 -0400 In-Reply-To: <87h70szuig.fsf@melete.silentflame.com> X-Hashcash: 1:20:220927:info@protesilaos.com::8SCy5IgRzDiHEa/8:6JSg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243742 Archived-At: Sean Whitton writes: >>> amend no. revert yes, but it=CA=BCs overkill for just a commit message = issue. You >>> can always run 'make change-history' and fix it in the resulting >>> ChangeLog file (see admin/notes/repo for the details) >> >> Please don't do that, it will make merging more tricky later. > > Hmm, so it's never okay to do that? Or is it to be saved for the more > egregrious errors? It's easier for me (or whoever is charge of merging and/or releases) if we don't do that, so I'd prefer it if we could reserve it for particularly nasty mistakes. However, if it has to be done, please do it in two separate commits: one that generates the ChangeLog and one that fixes the mistake.