From: Dmitry Gutov <dgutov@yandex.ru>
To: Protesilaos Stavrou <info@protesilaos.com>, 58092@debbugs.gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Stefan Kangas <stefankangas@gmail.com>
Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face
Date: Mon, 26 Sep 2022 17:32:32 +0300 [thread overview]
Message-ID: <7685a637-aa8f-3746-a0ad-7d07cce003be@yandex.ru> (raw)
In-Reply-To: <87a66mdych.fsf@protesilaos.com>
On 26.09.2022 17:06, Protesilaos Stavrou wrote:
>> From: Dmitry Gutov<dgutov@yandex.ru>
>> Date: Mon, 26 Sep 2022 16:28:56 +0300
>>
>> Hi!
>>
>> On 26.09.2022 15:44, Protesilaos Stavrou wrote:
>>> Dear maintainers,
>>>
>>> The attached patch replaces some hardcoded face properties in log-edit
>>> buffers with a named face.
>>>
>>> The named face allows users/themes to customise how this line is styled.
>>>
>>> What do you think?
>> LGTM, except perhaps call it headers-separator? It's used to separate
>> all the headers, not just summary.
> Hello everyone,
>
> I made the changes as you suggested and pushed them as commit
> a386833503. However, I forgot to update the commit message of the
> patch: it still mentions the old name of the face
> 'log-edit-summary-separator' instead of 'log-edit-headers-separator'.
>
> Sorry for this mistake! Can I revert or amend it?
If it's just in the commit message, then a revert won't help.
And I don't think we have any tools for amending the change log so far.
In any case, NEWS is more important than the commit message. So it's
probably fine.
next prev parent reply other threads:[~2022-09-26 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 12:44 bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Protesilaos Stavrou
2022-09-26 13:20 ` Lars Ingebrigtsen
2022-09-26 13:22 ` Stefan Kangas
2022-09-26 13:28 ` Dmitry Gutov
2022-09-26 14:06 ` Protesilaos Stavrou
2022-09-26 14:32 ` Dmitry Gutov [this message]
2022-09-26 14:40 ` Robert Pluim
2022-09-26 14:49 ` Stefan Kangas
2022-09-26 14:55 ` Protesilaos Stavrou
2022-09-27 15:50 ` Sean Whitton
2022-09-27 16:15 ` Stefan Kangas
2022-09-28 0:49 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7685a637-aa8f-3746-a0ad-7d07cce003be@yandex.ru \
--to=dgutov@yandex.ru \
--cc=58092@debbugs.gnu.org \
--cc=info@protesilaos.com \
--cc=larsi@gnus.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).