From: Allen Li <darkfeline@felesatra.moe>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 46884@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#46884: [PATCH] 27.1; Cannot run find-dired with -maxdepth
Date: Fri, 12 Mar 2021 08:08:55 +0000 [thread overview]
Message-ID: <CADbSrJyGXYw6O-=s_FjiG3QFKu2erSDrHNUdQPNnCEcxU8rE3w@mail.gmail.com> (raw)
In-Reply-To: <835z26ysa5.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 636 bytes --]
Attached patch, does this approach look good?
On Fri, Mar 5, 2021 at 7:27 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Allen Li <darkfeline@felesatra.moe>
> > Cc: Eli Zaretskii <eliz@gnu.org>, 46884@debbugs.gnu.org
> > Date: Thu, 04 Mar 2021 19:21:39 -0800
> >
> > For comparison:
> >
> > (find-dired DIR ARGS)
> >
> > I guess we could make ARGS optional and overload DIR to take a command?
> > What do you think, Eli?
> >
> > The new signature would look like:
> >
> > (find-dired DIR &optional ARGS CONFIRM)
>
> Sounds fine, I think, but could you post a more detailed proposal, or
> show a patch to that effect?
>
> Thanks.
>
[-- Attachment #1.2: Type: text/html, Size: 1138 bytes --]
[-- Attachment #2: 0001-find-dired-Add-global-args-to-find-dired.patch --]
[-- Type: text/x-patch, Size: 2418 bytes --]
From 3831be3067f97734137134e40e3e4467abd49816 Mon Sep 17 00:00:00 2001
From: Allen Li <darkfeline@felesatra.moe>
Date: Tue, 2 Mar 2021 14:24:16 -0800
Subject: [PATCH] find-dired: Add global-args to find-dired
The original find-dired does not allow for constructing queries like
find . -maxdepth 3 \( OTHER-ARGS \) -ls
* lisp/find-dired.el (find-dired): Added optional parameter.
---
etc/NEWS | 4 ++++
lisp/find-dired.el | 10 ++++++----
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/etc/NEWS b/etc/NEWS
index 73f136cfa7..40f79f8232 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -653,6 +653,10 @@ keys, add the following to your init file:
(global-set-key "\C-x\C-j" nil)
(global-set-key "\C-x4\C-j" nil)
+---
+*** Optional 'global-args' parameter added to 'find-dired'.
+This allows passing find global options like -maxdepth.
+
** Change Logs and VC
*** More VC commands can be used from non-file buffers.
diff --git a/lisp/find-dired.el b/lisp/find-dired.el
index adc5672eca..fc35cccddd 100644
--- a/lisp/find-dired.el
+++ b/lisp/find-dired.el
@@ -157,14 +157,15 @@ find-args-history
(defvar dired-sort-inhibit)
;;;###autoload
-(defun find-dired (dir args)
+(defun find-dired (dir args &optional global-args)
"Run `find' and go into Dired mode on a buffer of the output.
The command run (after changing into DIR) is essentially
- find . \\( ARGS \\) -ls
+ find . GLOBAL-ARGS \\( ARGS \\) -ls
except that the car of the variable `find-ls-option' specifies what to
-use in place of \"-ls\" as the final argument.
+use in place of \"-ls\" as the final argument. GLOBAL-ARGS is empty
+when called interactively.
Collect output in the \"*Find*\" buffer. To kill the job before
it finishes, type \\[kill-find]."
@@ -202,6 +203,7 @@ find-dired
(setq default-directory dir
find-args args ; save for next interactive call
args (concat find-program " . "
+ (if global-args global-args "")
(if (string= args "")
""
(concat
@@ -393,7 +395,7 @@ find-dired-sentinel
;; will stay around until M-x `list-processes'.
(delete-process proc)
(force-mode-line-update))))
- (message "find-dired %s finished." buf))))
+ (message "find-dired %s finished." buf))))
(defun find-dired-sort-by-filename ()
"Sort entries in *Find* buffer by file name lexicographically."
--
2.30.1
next prev parent reply other threads:[~2021-03-12 8:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 1:12 bug#46884: 27.1; Cannot run find-dired with -maxdepth Allen Li
2021-03-03 1:20 ` bug#46884: [PATCH] " Allen Li
2021-03-03 3:38 ` Allen Li
2021-03-03 6:28 ` Eli Zaretskii
2021-03-03 8:22 ` Allen Li
2021-03-03 8:55 ` Eli Zaretskii
2021-03-04 4:50 ` Allen Li
2021-03-04 9:35 ` Juri Linkov
2021-03-05 3:21 ` Allen Li
2021-03-05 7:27 ` Eli Zaretskii
2021-03-12 8:08 ` Allen Li [this message]
2021-03-12 15:49 ` bug#46884: [External] : " Drew Adams
2021-03-13 0:42 ` Allen Li
2021-03-13 1:09 ` Drew Adams
2021-03-13 9:46 ` Eli Zaretskii
2021-03-13 9:58 ` Andreas Schwab
2021-03-13 21:38 ` Allen Li
2021-03-13 21:53 ` Juri Linkov
2021-03-14 0:40 ` Allen Li
2021-03-18 18:52 ` Juri Linkov
2022-06-19 23:55 ` bug#46884: " Lars Ingebrigtsen
2022-06-26 3:54 ` Allen Li
2022-06-27 7:46 ` Lars Ingebrigtsen
2021-03-04 13:53 ` bug#46884: [PATCH] " Eli Zaretskii
2021-03-03 9:03 ` Juri Linkov
2021-03-03 15:42 ` bug#46884: [External] : " Drew Adams
2021-03-03 16:20 ` Eli Zaretskii
2021-03-03 6:15 ` Eli Zaretskii
2021-03-03 1:34 ` bug#46884: [External] : bug#46884: " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADbSrJyGXYw6O-=s_FjiG3QFKu2erSDrHNUdQPNnCEcxU8rE3w@mail.gmail.com' \
--to=darkfeline@felesatra.moe \
--cc=46884@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).