From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#46884: [PATCH] 27.1; Cannot run find-dired with -maxdepth Date: Fri, 12 Mar 2021 08:08:55 +0000 Message-ID: References: <83k0qo699n.fsf@gnu.org> <83ft1c62hk.fsf@gnu.org> <80ft1bed4g.fsf@felesatra.moe> <87r1kv8dnt.fsf@mail.linkov.net> <808s72e14s.fsf@felesatra.moe> <835z26ysa5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000f3ffe305bd5269b6" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2539"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46884@debbugs.gnu.org, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 12 09:10:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKcsI-0000YR-G8 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Mar 2021 09:10:22 +0100 Original-Received: from localhost ([::1]:36998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKcsH-0000bo-JH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Mar 2021 03:10:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKcry-0000bf-Gy for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 03:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKcry-0001Je-8v for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 03:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lKcry-0005r0-34 for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 03:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Mar 2021 08:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46884 X-GNU-PR-Package: emacs Original-Received: via spool by 46884-submit@debbugs.gnu.org id=B46884.161553655422445 (code B ref 46884); Fri, 12 Mar 2021 08:10:02 +0000 Original-Received: (at 46884) by debbugs.gnu.org; 12 Mar 2021 08:09:14 +0000 Original-Received: from localhost ([127.0.0.1]:55968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKcrB-0005px-Pu for submit@debbugs.gnu.org; Fri, 12 Mar 2021 03:09:14 -0500 Original-Received: from mail-oo1-f45.google.com ([209.85.161.45]:38636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKcr9-0005pl-Qh for 46884@debbugs.gnu.org; Fri, 12 Mar 2021 03:09:12 -0500 Original-Received: by mail-oo1-f45.google.com with SMTP id n12-20020a4ad12c0000b02901b63e7bc1b4so1332647oor.5 for <46884@debbugs.gnu.org>; Fri, 12 Mar 2021 00:09:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WQdn/atAxpd2zi6eKnKMCjRqFSiR3M96kFVV9Nu+VRw=; b=RNN891WFpHyI7p9AmSNrI/h8FOdcJ+YEyNCOJLauEunvC5aeRtM69qob4Jv4D51vyd rNi/mJr6OFEDGKo059OjLITXDbZeTK7T0RGmW0UHUBFKw6sznnttwyRhOgewzIfVv1AZ YCEsuW5Qj9Xwb1VEYzO5+ENJdi4BHfk/i9cXO/ncbPMCgblIG9sQgpG5x3WxwllNsaFM SsVJoN9lLHLVcoiAlyxnAZoPSOXM0u3dXvg21nVGTPS4J1YQ66nRht5ooFa2M5KhDy7B x7eryCpnKCXAQ1DRVvSGIVSasWOyakG0bC35x8Mg2+8dFJL2VYWGYswDGQJGemuzzwzn aOGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WQdn/atAxpd2zi6eKnKMCjRqFSiR3M96kFVV9Nu+VRw=; b=TIWedRakEbJKgOEPHZlaJrNqLnQuKL0IiAAQXru2yNnC/Q8xOTqHHDlxufr7yo8O+8 oEb4iNGMJUG/+ixIopt3tnFX7N+U5H9xvUn9voolhQHsFS8VuhGiOTptVw/yKZXkrP+7 OGAPBTuMoJPcQcM2doI1DekRDx/9S/aikW/LxhWEVcnC0oKl+A1dVNcD/gElR4OvuJ+B GGyk48yOumgZL0jlROuT1D7oztclAbZh5SsDdBlqSIEAcI0+Ly5F0oS9u/QarbswV5/B zERqNRvUq08sFxDW1KKBc7SDBE3JbJk+VC8oX9E2/JpEFARXaajNaQR79N8FmMUQpIu/ nohA== X-Gm-Message-State: AOAM530VLONxZLrEPPKUKBFNWK52QZmzRc1aBqH3r6CA53GCRjc57jHW 7ju3LAnDReBMk4m8uGmb4L874J3lZc73ytWgGdRUqA== X-Google-Smtp-Source: ABdhPJxOqS6r0SBY5bJTvq9CHp4AmC/MnIwMj8ER0SqYuLOsY1tuNHVU3IwEUGHDqHW4e/5jQk6c6xTvD/0iPwtKVxA= X-Received: by 2002:a4a:d1da:: with SMTP id a26mr2429214oos.58.1615536546109; Fri, 12 Mar 2021 00:09:06 -0800 (PST) In-Reply-To: <835z26ysa5.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202147 Archived-At: --000000000000f3ffe305bd5269b6 Content-Type: multipart/alternative; boundary="000000000000f3ffe105bd5269b4" --000000000000f3ffe105bd5269b4 Content-Type: text/plain; charset="UTF-8" Attached patch, does this approach look good? On Fri, Mar 5, 2021 at 7:27 AM Eli Zaretskii wrote: > > From: Allen Li > > Cc: Eli Zaretskii , 46884@debbugs.gnu.org > > Date: Thu, 04 Mar 2021 19:21:39 -0800 > > > > For comparison: > > > > (find-dired DIR ARGS) > > > > I guess we could make ARGS optional and overload DIR to take a command? > > What do you think, Eli? > > > > The new signature would look like: > > > > (find-dired DIR &optional ARGS CONFIRM) > > Sounds fine, I think, but could you post a more detailed proposal, or > show a patch to that effect? > > Thanks. > --000000000000f3ffe105bd5269b4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Attached patch, does this approach look good?

On Fri, Mar 5= , 2021 at 7:27 AM Eli Zaretskii <eliz@gn= u.org> wrote:
> From: Allen Li <darkfeline@felesatra.moe>
> Cc: Eli Zaretskii <eliz@gnu.org>,=C2=A0 46884@debbugs.gnu.org
> Date: Thu, 04 Mar 2021 19:21:39 -0800
>
> For comparison:
>
> (find-dired DIR ARGS)
>
> I guess we could make ARGS optional and overload DIR to take a command= ?
> What do you think, Eli?
>
> The new signature would look like:
>
> (find-dired DIR &optional ARGS CONFIRM)

Sounds fine, I think, but could you post a more detailed proposal, or
show a patch to that effect?

Thanks.
--000000000000f3ffe105bd5269b4-- --000000000000f3ffe305bd5269b6 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-find-dired-Add-global-args-to-find-dired.patch" Content-Disposition: attachment; filename="0001-find-dired-Add-global-args-to-find-dired.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_km60qlpa0 RnJvbSAzODMxYmUzMDY3Zjk3NzM0MTM3MTM0ZTQwZTNlNDQ2N2FiZDQ5ODE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBUdWUsIDIgTWFyIDIwMjEgMTQ6MjQ6MTYgLTA4MDAKU3ViamVjdDogW1BBVENIXSBmaW5k LWRpcmVkOiBBZGQgZ2xvYmFsLWFyZ3MgdG8gZmluZC1kaXJlZAoKVGhlIG9yaWdpbmFsIGZpbmQt ZGlyZWQgZG9lcyBub3QgYWxsb3cgZm9yIGNvbnN0cnVjdGluZyBxdWVyaWVzIGxpa2UKCiBmaW5k IC4gLW1heGRlcHRoIDMgXCggT1RIRVItQVJHUyBcKSAtbHMKCiogbGlzcC9maW5kLWRpcmVkLmVs IChmaW5kLWRpcmVkKTogQWRkZWQgb3B0aW9uYWwgcGFyYW1ldGVyLgotLS0KIGV0Yy9ORVdTICAg ICAgICAgICB8ICA0ICsrKysKIGxpc3AvZmluZC1kaXJlZC5lbCB8IDEwICsrKysrKy0tLS0KIDIg ZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IDczZjEzNmNmYTcuLjQwZjc5ZjgyMzIgMTAw NjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC02NTMsNiArNjUzLDEwIEBAIGtl eXMsIGFkZCB0aGUgZm9sbG93aW5nIHRvIHlvdXIgaW5pdCBmaWxlOgogKGdsb2JhbC1zZXQta2V5 ICJcQy14XEMtaiIgbmlsKQogKGdsb2JhbC1zZXQta2V5ICJcQy14NFxDLWoiIG5pbCkKIAorLS0t CisqKiogT3B0aW9uYWwgJ2dsb2JhbC1hcmdzJyBwYXJhbWV0ZXIgYWRkZWQgdG8gJ2ZpbmQtZGly ZWQnLgorVGhpcyBhbGxvd3MgcGFzc2luZyBmaW5kIGdsb2JhbCBvcHRpb25zIGxpa2UgLW1heGRl cHRoLgorCiAqKiBDaGFuZ2UgTG9ncyBhbmQgVkMKIAogKioqIE1vcmUgVkMgY29tbWFuZHMgY2Fu IGJlIHVzZWQgZnJvbSBub24tZmlsZSBidWZmZXJzLgpkaWZmIC0tZ2l0IGEvbGlzcC9maW5kLWRp cmVkLmVsIGIvbGlzcC9maW5kLWRpcmVkLmVsCmluZGV4IGFkYzU2NzJlY2EuLmZjMzVjY2NkZGQg MTAwNjQ0Ci0tLSBhL2xpc3AvZmluZC1kaXJlZC5lbAorKysgYi9saXNwL2ZpbmQtZGlyZWQuZWwK QEAgLTE1NywxNCArMTU3LDE1IEBAIGZpbmQtYXJncy1oaXN0b3J5CiAoZGVmdmFyIGRpcmVkLXNv cnQtaW5oaWJpdCkKIAogOzs7IyMjYXV0b2xvYWQKLShkZWZ1biBmaW5kLWRpcmVkIChkaXIgYXJn cykKKyhkZWZ1biBmaW5kLWRpcmVkIChkaXIgYXJncyAmb3B0aW9uYWwgZ2xvYmFsLWFyZ3MpCiAg ICJSdW4gYGZpbmQnIGFuZCBnbyBpbnRvIERpcmVkIG1vZGUgb24gYSBidWZmZXIgb2YgdGhlIG91 dHB1dC4KIFRoZSBjb21tYW5kIHJ1biAoYWZ0ZXIgY2hhbmdpbmcgaW50byBESVIpIGlzIGVzc2Vu dGlhbGx5CiAKLSAgICBmaW5kIC4gXFwoIEFSR1MgXFwpIC1scworICAgIGZpbmQgLiBHTE9CQUwt QVJHUyBcXCggQVJHUyBcXCkgLWxzCiAKIGV4Y2VwdCB0aGF0IHRoZSBjYXIgb2YgdGhlIHZhcmlh YmxlIGBmaW5kLWxzLW9wdGlvbicgc3BlY2lmaWVzIHdoYXQgdG8KLXVzZSBpbiBwbGFjZSBvZiBc Ii1sc1wiIGFzIHRoZSBmaW5hbCBhcmd1bWVudC4KK3VzZSBpbiBwbGFjZSBvZiBcIi1sc1wiIGFz IHRoZSBmaW5hbCBhcmd1bWVudC4gIEdMT0JBTC1BUkdTIGlzIGVtcHR5Cit3aGVuIGNhbGxlZCBp bnRlcmFjdGl2ZWx5LgogCiBDb2xsZWN0IG91dHB1dCBpbiB0aGUgXCIqRmluZCpcIiBidWZmZXIu ICBUbyBraWxsIHRoZSBqb2IgYmVmb3JlCiBpdCBmaW5pc2hlcywgdHlwZSBcXFtraWxsLWZpbmRd LiIKQEAgLTIwMiw2ICsyMDMsNyBAQCBmaW5kLWRpcmVkCiAgICAgKHNldHEgZGVmYXVsdC1kaXJl Y3RvcnkgZGlyCiAJICBmaW5kLWFyZ3MgYXJncwkgICAgICA7IHNhdmUgZm9yIG5leHQgaW50ZXJh Y3RpdmUgY2FsbAogCSAgYXJncyAoY29uY2F0IGZpbmQtcHJvZ3JhbSAiIC4gIgorICAgICAgICAg ICAgICAgICAgICAgICAoaWYgZ2xvYmFsLWFyZ3MgZ2xvYmFsLWFyZ3MgIiIpCiAJCSAgICAgICAo aWYgKHN0cmluZz0gYXJncyAiIikKIAkJCSAgICIiCiAJCQkgKGNvbmNhdApAQCAtMzkzLDcgKzM5 NSw3IEBAIGZpbmQtZGlyZWQtc2VudGluZWwKIAkgICAgICA7OyB3aWxsIHN0YXkgYXJvdW5kIHVu dGlsIE0teCBgbGlzdC1wcm9jZXNzZXMnLgogCSAgICAgIChkZWxldGUtcHJvY2VzcyBwcm9jKQog CSAgICAgIChmb3JjZS1tb2RlLWxpbmUtdXBkYXRlKSkpKQotCSAgKG1lc3NhZ2UgImZpbmQtZGly ZWQgJXMgZmluaXNoZWQuIiBidWYpKSkpCisgICAgICAobWVzc2FnZSAiZmluZC1kaXJlZCAlcyBm aW5pc2hlZC4iIGJ1ZikpKSkKIAogKGRlZnVuIGZpbmQtZGlyZWQtc29ydC1ieS1maWxlbmFtZSAo KQogICAiU29ydCBlbnRyaWVzIGluICpGaW5kKiBidWZmZXIgYnkgZmlsZSBuYW1lIGxleGljb2dy YXBoaWNhbGx5LiIKLS0gCjIuMzAuMQoK --000000000000f3ffe305bd5269b6--