unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Allen Li <darkfeline@felesatra.moe>
Cc: 46884@debbugs.gnu.org, juri@linkov.net
Subject: bug#46884: [PATCH] 27.1; Cannot run find-dired with -maxdepth
Date: Sat, 13 Mar 2021 11:46:38 +0200	[thread overview]
Message-ID: <831rcjjsht.fsf@gnu.org> (raw)
In-Reply-To: <CADbSrJyGXYw6O-=s_FjiG3QFKu2erSDrHNUdQPNnCEcxU8rE3w@mail.gmail.com> (message from Allen Li on Fri, 12 Mar 2021 08:08:55 +0000)

> From: Allen Li <darkfeline@felesatra.moe>
> Date: Fri, 12 Mar 2021 08:08:55 +0000
> Cc: Juri Linkov <juri@linkov.net>, 46884@debbugs.gnu.org
> 
> Attached patch, does this approach look good?

I guess my suggestion to additionally allow specification of
GLOBAL-ARGS interactively (via prefix arg) got voted down?

> +---
> +*** Optional 'global-args' parameter added to 'find-dired'.
> +This allows passing find global options like -maxdepth.

"find" should be in quotes: 'find'

> @@ -202,6 +203,7 @@ find-dired
>      (setq default-directory dir
>  	  find-args args	      ; save for next interactive call
>  	  args (concat find-program " . "
> +                       (if global-args global-args "")

'concat' knows how to handle nil arguments, so you don't need the
empty string alternative here.  Just (if global-args global-args)
should do.





  parent reply	other threads:[~2021-03-13  9:46 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03  1:12 bug#46884: 27.1; Cannot run find-dired with -maxdepth Allen Li
2021-03-03  1:20 ` bug#46884: [PATCH] " Allen Li
2021-03-03  3:38   ` Allen Li
2021-03-03  6:28     ` Eli Zaretskii
2021-03-03  8:22       ` Allen Li
2021-03-03  8:55         ` Eli Zaretskii
2021-03-04  4:50           ` Allen Li
2021-03-04  9:35             ` Juri Linkov
2021-03-05  3:21               ` Allen Li
2021-03-05  7:27                 ` Eli Zaretskii
2021-03-12  8:08                   ` Allen Li
2021-03-12 15:49                     ` bug#46884: [External] : " Drew Adams
2021-03-13  0:42                       ` Allen Li
2021-03-13  1:09                         ` Drew Adams
2021-03-13  9:46                     ` Eli Zaretskii [this message]
2021-03-13  9:58                       ` Andreas Schwab
2021-03-13 21:38                       ` Allen Li
2021-03-13 21:53                         ` Juri Linkov
2021-03-14  0:40                           ` Allen Li
2021-03-18 18:52                             ` Juri Linkov
2022-06-19 23:55                               ` bug#46884: " Lars Ingebrigtsen
2022-06-26  3:54                                 ` Allen Li
2022-06-27  7:46                                   ` Lars Ingebrigtsen
2021-03-04 13:53             ` bug#46884: [PATCH] " Eli Zaretskii
2021-03-03  9:03         ` Juri Linkov
2021-03-03 15:42         ` bug#46884: [External] : " Drew Adams
2021-03-03 16:20           ` Eli Zaretskii
2021-03-03  6:15   ` Eli Zaretskii
2021-03-03  1:34 ` bug#46884: [External] : bug#46884: " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831rcjjsht.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=46884@debbugs.gnu.org \
    --cc=darkfeline@felesatra.moe \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).