From: Allen Li <darkfeline@felesatra.moe>
To: Drew Adams <drew.adams@oracle.com>
Cc: Phil Sainty <psainty@orcon.net.nz>,
"46884@debbugs.gnu.org" <46884@debbugs.gnu.org>,
Juri Linkov <juri@linkov.net>
Subject: bug#46884: [External] : bug#46884: [PATCH] 27.1; Cannot run find-dired with -maxdepth
Date: Fri, 12 Mar 2021 16:42:18 -0800 [thread overview]
Message-ID: <80blbn28b9.fsf@felesatra.moe> (raw)
In-Reply-To: <SA2PR10MB4474E02F6C0774DE4D45E91DF36F9@SA2PR10MB4474.namprd10.prod.outlook.com> (Drew Adams's message of "Fri, 12 Mar 2021 15:49:04 +0000")
Drew Adams <drew.adams@oracle.com> writes:
>> Attached patch, does this approach look good?
>
> What did you find wrong or missing with the
> code I cited? It accepts DEPTH-LIMITS and
> EXCLUDED-PATHS as optional args.
Personally, I find it weirdly specialized and incomplete. There are
many global options beside -mindepth and -maxdepth; your version
supports none of those options. There is also no need to support
EXCLUDED-PATHS separately; that can already be accomplished with the
current find-dired API. I prefer a more flexible, general API, which is
the current rgrep approach proposed by Juri and Phil on another bug [1].
There's also another bug open which can be closed if we adopt the rgrep
approach [2].
[1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27456
[2]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32668
next prev parent reply other threads:[~2021-03-13 0:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 1:12 bug#46884: 27.1; Cannot run find-dired with -maxdepth Allen Li
2021-03-03 1:20 ` bug#46884: [PATCH] " Allen Li
2021-03-03 3:38 ` Allen Li
2021-03-03 6:28 ` Eli Zaretskii
2021-03-03 8:22 ` Allen Li
2021-03-03 8:55 ` Eli Zaretskii
2021-03-04 4:50 ` Allen Li
2021-03-04 9:35 ` Juri Linkov
2021-03-05 3:21 ` Allen Li
2021-03-05 7:27 ` Eli Zaretskii
2021-03-12 8:08 ` Allen Li
2021-03-12 15:49 ` bug#46884: [External] : " Drew Adams
2021-03-13 0:42 ` Allen Li [this message]
2021-03-13 1:09 ` Drew Adams
2021-03-13 9:46 ` Eli Zaretskii
2021-03-13 9:58 ` Andreas Schwab
2021-03-13 21:38 ` Allen Li
2021-03-13 21:53 ` Juri Linkov
2021-03-14 0:40 ` Allen Li
2021-03-18 18:52 ` Juri Linkov
2022-06-19 23:55 ` bug#46884: " Lars Ingebrigtsen
2022-06-26 3:54 ` Allen Li
2022-06-27 7:46 ` Lars Ingebrigtsen
2021-03-04 13:53 ` bug#46884: [PATCH] " Eli Zaretskii
2021-03-03 9:03 ` Juri Linkov
2021-03-03 15:42 ` bug#46884: [External] : " Drew Adams
2021-03-03 16:20 ` Eli Zaretskii
2021-03-03 6:15 ` Eli Zaretskii
2021-03-03 1:34 ` bug#46884: [External] : bug#46884: " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80blbn28b9.fsf@felesatra.moe \
--to=darkfeline@felesatra.moe \
--cc=46884@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=juri@linkov.net \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).