* bug#55849: 29.0.50; process-async-https-with-delay error detection is wrong
@ 2022-06-08 16:30 Ken Brown
2022-06-08 16:52 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Ken Brown @ 2022-06-08 16:30 UTC (permalink / raw)
To: 55849
process-async-https-with-delay in test/src/process-tests.el fails on
Cygwin as follows:
Test process-async-https-with-delay condition:
(ert-test-failed
((should
(>
(buffer-size buf)
0))
:form
(> 0 0)
:value nil))
I haven't yet figured out why, but in attempting to debug this I
discovered that the error reporting in the test is faulty. What
actually happens is that the connection fails, and this failure is
indicated by the 'status' variable. The latter is a plist, but the test
uses '(should-not (assq :error status))' as though it were an alist.
The following patch fixes the problem:
diff --git a/test/src/process-tests.el b/test/src/process-tests.el
index f5908d3cda..824c6da119 100644
--- a/test/src/process-tests.el
+++ b/test/src/process-tests.el
@@ -931,7 +931,7 @@ process-async-https-with-delay
(< (float-time) (+ t0 limit)))
(sit-for 0.1)))
(should status)
- (should-not (assq :error status))
+ (should-not (plist-get status ':error))
(should buf)
(should (> (buffer-size buf) 0))
)
With this patch the correct reason for the failure is shown:
Test process-async-https-with-delay condition:
(ert-test-failed
((should-not
(plist-get status ':error))
:form
(plist-get
(:error
(error connection-failed "deleted\n" :host "elpa.gnu.org" :service 443))
:error)
:value
(error connection-failed "deleted\n" :host "elpa.gnu.org" :service 443)))
OK to apply? If so, to which branch? The problem exists on both master
and the release branch.
Ken
^ permalink raw reply related [flat|nested] 3+ messages in thread* bug#55849: 29.0.50; process-async-https-with-delay error detection is wrong
2022-06-08 16:30 bug#55849: 29.0.50; process-async-https-with-delay error detection is wrong Ken Brown
@ 2022-06-08 16:52 ` Eli Zaretskii
2022-06-08 17:12 ` Ken Brown
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2022-06-08 16:52 UTC (permalink / raw)
To: Ken Brown; +Cc: 55849
> Date: Wed, 8 Jun 2022 12:30:31 -0400
> From: Ken Brown <kbrown@cornell.edu>
>
> diff --git a/test/src/process-tests.el b/test/src/process-tests.el
> index f5908d3cda..824c6da119 100644
> --- a/test/src/process-tests.el
> +++ b/test/src/process-tests.el
> @@ -931,7 +931,7 @@ process-async-https-with-delay
> (< (float-time) (+ t0 limit)))
> (sit-for 0.1)))
> (should status)
> - (should-not (assq :error status))
> + (should-not (plist-get status ':error))
> (should buf)
> (should (> (buffer-size buf) 0))
> )
>
> With this patch the correct reason for the failure is shown:
>
> Test process-async-https-with-delay condition:
> (ert-test-failed
> ((should-not
> (plist-get status ':error))
> :form
> (plist-get
> (:error
> (error connection-failed "deleted\n" :host "elpa.gnu.org" :service 443))
> :error)
> :value
> (error connection-failed "deleted\n" :host "elpa.gnu.org" :service 443)))
>
> OK to apply?
Yes, please.
> If so, to which branch? The problem exists on both master
> and the release branch.
Please install on the release branch, and thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-08 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-08 16:30 bug#55849: 29.0.50; process-async-https-with-delay error detection is wrong Ken Brown
2022-06-08 16:52 ` Eli Zaretskii
2022-06-08 17:12 ` Ken Brown
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).