From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#55849: 29.0.50; process-async-https-with-delay error detection is wrong Date: Wed, 8 Jun 2022 12:30:31 -0400 Message-ID: <91f2d666-8d1b-9e23-00e7-afc8b171699f@cornell.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35032"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 To: 55849@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 08 18:36:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyyfM-0008rw-RI for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jun 2022 18:36:21 +0200 Original-Received: from localhost ([::1]:50932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyyfK-0005EJ-5W for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jun 2022 12:36:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyyf4-0005Cl-5f for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2022 12:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50170) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyyf3-0006FF-Sm for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2022 12:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nyyf3-0000BC-MK for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2022 12:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jun 2022 16:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55849 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.1654706148662 (code B ref -1); Wed, 08 Jun 2022 16:36:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Jun 2022 16:35:48 +0000 Original-Received: from localhost ([127.0.0.1]:44067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyyep-0000Ac-PD for submit@debbugs.gnu.org; Wed, 08 Jun 2022 12:35:48 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:58102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyyel-0000AP-RI for submit@debbugs.gnu.org; Wed, 08 Jun 2022 12:35:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyyel-0004wK-GB for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2022 12:35:43 -0400 Original-Received: from mail-co1nam11on2072c.outbound.protection.outlook.com ([2a01:111:f400:7eab::72c]:47425 helo=NAM11-CO1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyyef-00066k-IN for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2022 12:35:43 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mi1Su729h6akJfebYvIX/Q+bniVbrJcWVqGL9cztXO18/hZub+PgfoYCkYqwDwRD87fCz8/F2KRoycr8HFC+uhbenvfl8WFX5/g5qWBxySYB166RNBFs1eka4jS9ht4wRPHZqkGRESqpe8icbCSdI5QK3sOgPRsGbKCoGgmYMVPvDfc1bsxZY6KbkvsEf67+USHM8SEHnz8XLWGNzrCN+cL1hcw3ux07mOn87W0pp58omFp9Cp6Gt5VG35Fu1gRhrMrLBsqmBcuE81iyPn17S9noIwGpn0Me+rkJ2kj8UJfigJptFjMQO6XgD0of8J7F3Mw3s9UUtREKEfowrZ30qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=220XdP0NyFXMjoLRiWddWZeN+GTLpOSc7yXGCcmFzcw=; b=OqC3p02dQXFmBPOd+jw2ZUHlGet4duRN4baJuutv6zeR5OM9O0ILJCwfEtEjjlEFWMFI7zwYIiGLnvzw11hcjP6HVTn/sKuy0aBCL/HSNeq/1k4YmZkBVFEK4h8gSZn0vECz0bgEJCqKcDkcD2jrTIP/nZzt2gzQ9Az9xT7vPe/fVKTaVyZwHKiYQO49HE7lMsGTm2yDLfTx0A510ReHjW7J9AEwgj4DWZ1B5n4q9nCM9gPYAToUJjAPIVfs7C6aSW31zcsuRxVWP3NhWGFvNEaAA8GZGqkbwAbgVlpzRBv+99KggvnOwC55pKEGzVtzmlcvTn6aOvZyfwqQUPm2Gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=220XdP0NyFXMjoLRiWddWZeN+GTLpOSc7yXGCcmFzcw=; b=Ypfz4kestzSocNGUasK75cl1PqSWRxBMEd3pXgzaLzlYO0Zcb01PHYi9BhgJnjvHwjemA4MyfY5BELwrS9WnrqN7Mer5EfwVPFylDvmm1EfOEWL3CEGeNROWOncVwHstJHUsTGndBBrx1h1Hc9gf3krSb1UEY6UoL+LkXZyey5g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Original-Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by SN6PR04MB4670.namprd04.prod.outlook.com (2603:10b6:805:b1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.17; Wed, 8 Jun 2022 16:30:33 +0000 Original-Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::e48c:b440:3098:a050]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::e48c:b440:3098:a050%6]) with mapi id 15.20.5314.019; Wed, 8 Jun 2022 16:30:33 +0000 Content-Language: en-US X-ClientProxiedBy: BL0PR02CA0097.namprd02.prod.outlook.com (2603:10b6:208:51::38) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 90af6e0c-4f6e-43a4-74cc-08da496c35bd X-MS-TrafficTypeDiagnostic: SN6PR04MB4670:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QqM0t1Mu2KS7xpQ2ziU2zavgr7Z6AKOFKzJq2YisnU4vxHHdXpeU+DCuJFzj8UvMcPiBvGprYA5v/mJWPYhlWZzEUzGuutzcrrG4gOIE5xAQiGxCIV3LxlhX1gd1OKjyPduH1NdaSbOxVFg/rp2IBEoN7A9GPbqED5HKTYAxul1pObs5eJ+dMrz1fxlvEJsXCjuTfVR8QR3eWvIe2YqTU6RxcBk4pnQX3s59fgtL6mAy/3ONJn3WwYkArtxCcAcsW4rxzJZSx1ptIvBeTosk+1BLBotaGoCY+6AUIvwFn2AxcI05JzIVapUH5yYD4bnnimAt3p8ExKvUfWdeiYFrRIumKqZdgZAY3avPboxjF/fd6+twCaWFefmMxjg67j6acQGNcbDw8oEXU0Q2qqq0vTvH42BSx0BvvI7uYkaoVl7jxHA8EaY+R/FZ51AEsM7FdUXruK8JW7OAPhxGV6LLxEU6Qh7flhn9CDKP1cSIloO/WpIy91n+LbOY6gL0eo4jgPqOLe+ptoXQu9Fe4WcdZ1TNFCH/QSh6EAGKfL1LSYA91VcB1eab44OjjvIHoY4O6AjrhNhQLX0Ro/mapYEvdT0kLA8pb7zu+etOImDzpej84QOUlmGrKxYWAtR6n54xi4yo+PrqDw+/QuKgw3ADZiptOj5eD1dTXxrPoGu+x4VJa1YxYHd6E2Nq9Jbc3uVXTJ483pvFDdAh607eVqzlBzyvUsj+jSswB6iBo3FugRc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(2906002)(6506007)(31696002)(8676002)(8936002)(83380400001)(6916009)(6512007)(508600001)(36756003)(66476007)(86362001)(5660300002)(6486002)(66556008)(66946007)(2616005)(38100700002)(186003)(786003)(31686004)(75432002)(316002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: WBfSuXQ6iRCMFaLpINZyKL1J1V2z9wtAXln2XeKuv6a2lJRN21MD6pkAETWOOxZlrJwtLKvW5XzB0zjjkMzZlfK4C7k+9woojwlEWmDO17Z6axtDjbHkTbZmxQD18n/9MYhhemVJ4cbREISWWwDuqboL2JfUfxlIY8RCd5LFXGdWedH8WgPaV8Z9P6iWhi1eR127YDuDQU+zSr2/90ITdsEL8WAHFul8MTgksJrCP/EmSfWKbv4LbEgYmHaTSVTRosTUxZPp+4PbOjMw8smQD1rLSsIYH3jSGWxqEQi7AcnFBAZEL5PXJrxHEujN4+h9VblPRGqMfZ3w8TJyNBzR05ip/mi93vRZY1O/1GgHB0j+iZNIJw/lSCBrhz/7e1F9aGSjM8UnnrPpyei1lmdfU+ERM/1skSlhiZUoJCfrySiNEGb58fvoceBhzxHLj2q46WDHSn7AxiNWZIBSoWXgUHnHbHg+BmNAKqSBdDO3AEqcFnPtgFbLI3hWu+JEqFf1bJDh8/Lh7SgAQzJeiBs3a0aRwa6x5cYpuV+aeTd4e2zWkCYSyWDlgrDfXJts8ngwp+4AHt3r2CMQXx7HrKcJMlUVSELM3Mg8q9/ePOp2ypaGiu9JPaEv1Vd7rr0TgNlzg66QvHl7c7xSXHJtFxHVR//CCvFp63+eKYCilduQNCk9ow3F5xWOrzSNFwxSxC+NkK/x6b6i4cHcFm0FU8uGBSPyuQSEhZylWhsBP3lKcM2LU45DKGc3R57maS bmXsv04b26UM/NXdArxW5LrcoKub1WVvG048EGp8jtKzKtC3X4mHfoLAGm8nnJ6FUNnbqH4Z9gN5wrcxO9NXa27XPVf6cxL95Q X-MS-Exchange-AntiSpam-MessageData-1: vSLL2bKIh3QGuw== X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 90af6e0c-4f6e-43a4-74cc-08da496c35bd X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2022 16:30:33.4500 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QZvWVyMxxHGaFOE+yyKobmvtJNPcyzFqxqPj7OlpXFKHdvHL+zFfyrkAjUUIiiq2TYUMxjqM3nozciVrLcF5zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4670 Received-SPF: pass client-ip=2a01:111:f400:7eab::72c; envelope-from=kbrown@cornell.edu; helo=NAM11-CO1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233982 Archived-At: process-async-https-with-delay in test/src/process-tests.el fails on Cygwin as follows: Test process-async-https-with-delay condition: (ert-test-failed ((should (> (buffer-size buf) 0)) :form (> 0 0) :value nil)) I haven't yet figured out why, but in attempting to debug this I discovered that the error reporting in the test is faulty. What actually happens is that the connection fails, and this failure is indicated by the 'status' variable. The latter is a plist, but the test uses '(should-not (assq :error status))' as though it were an alist. The following patch fixes the problem: diff --git a/test/src/process-tests.el b/test/src/process-tests.el index f5908d3cda..824c6da119 100644 --- a/test/src/process-tests.el +++ b/test/src/process-tests.el @@ -931,7 +931,7 @@ process-async-https-with-delay (< (float-time) (+ t0 limit))) (sit-for 0.1))) (should status) - (should-not (assq :error status)) + (should-not (plist-get status ':error)) (should buf) (should (> (buffer-size buf) 0)) ) With this patch the correct reason for the failure is shown: Test process-async-https-with-delay condition: (ert-test-failed ((should-not (plist-get status ':error)) :form (plist-get (:error (error connection-failed "deleted\n" :host "elpa.gnu.org" :service 443)) :error) :value (error connection-failed "deleted\n" :host "elpa.gnu.org" :service 443))) OK to apply? If so, to which branch? The problem exists on both master and the release branch. Ken