From: Ken Brown <kbrown@cornell.edu>
To: 55849@debbugs.gnu.org
Subject: bug#55849: 29.0.50; process-async-https-with-delay error detection is wrong
Date: Wed, 8 Jun 2022 12:30:31 -0400 [thread overview]
Message-ID: <91f2d666-8d1b-9e23-00e7-afc8b171699f@cornell.edu> (raw)
process-async-https-with-delay in test/src/process-tests.el fails on
Cygwin as follows:
Test process-async-https-with-delay condition:
(ert-test-failed
((should
(>
(buffer-size buf)
0))
:form
(> 0 0)
:value nil))
I haven't yet figured out why, but in attempting to debug this I
discovered that the error reporting in the test is faulty. What
actually happens is that the connection fails, and this failure is
indicated by the 'status' variable. The latter is a plist, but the test
uses '(should-not (assq :error status))' as though it were an alist.
The following patch fixes the problem:
diff --git a/test/src/process-tests.el b/test/src/process-tests.el
index f5908d3cda..824c6da119 100644
--- a/test/src/process-tests.el
+++ b/test/src/process-tests.el
@@ -931,7 +931,7 @@ process-async-https-with-delay
(< (float-time) (+ t0 limit)))
(sit-for 0.1)))
(should status)
- (should-not (assq :error status))
+ (should-not (plist-get status ':error))
(should buf)
(should (> (buffer-size buf) 0))
)
With this patch the correct reason for the failure is shown:
Test process-async-https-with-delay condition:
(ert-test-failed
((should-not
(plist-get status ':error))
:form
(plist-get
(:error
(error connection-failed "deleted\n" :host "elpa.gnu.org" :service 443))
:error)
:value
(error connection-failed "deleted\n" :host "elpa.gnu.org" :service 443)))
OK to apply? If so, to which branch? The problem exists on both master
and the release branch.
Ken
next reply other threads:[~2022-06-08 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 16:30 Ken Brown [this message]
2022-06-08 16:52 ` bug#55849: 29.0.50; process-async-https-with-delay error detection is wrong Eli Zaretskii
2022-06-08 17:12 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91f2d666-8d1b-9e23-00e7-afc8b171699f@cornell.edu \
--to=kbrown@cornell.edu \
--cc=55849@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).