From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@linkov.net>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: Alan Mackenzie <acm@muc.de>, 43702@debbugs.gnu.org
Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch.
Date: Thu, 1 Oct 2020 12:39:50 -0700 (PDT) [thread overview]
Message-ID: <899b2057-7389-464b-91f3-12d23125fdee@default> (raw)
In-Reply-To: <878scp92mo.fsf@mail.linkov.net>
> >> Maybe better to do what Drew proposed: to distinguish the odd groups
> >> from the even groups, i.e. to have only 2 additional faces
> >> (a brighter face like the current isearch-group-1 for the odd groups,
> >> and a darker face for the even groups).
> >
> > I like the idea.
>
> Implemented now on the trunk where isearch-group-odd is created
> from the isearch-group-1 face, and isearch-group-even
> from the isearch-group-4 face.
>
> The result is quite nice:
Sorry, but IMO that's horrible. And you really should
show more regexps, not just a sequence of groups, but
nested groups etc.
Regexp matching is complex. And that's the point:
WYSIWYG visualization of a user's regexp on the fly.
My suggestion: provide a fair number of group faces,
to make it easy to identify which parts of a regexp
correspond to which parts of the current search hit.
This should be simple. I've done it. And used it,
for a long time. Why reinvent the wheel, replacing
a circle with an octagon?
next prev parent reply other threads:[~2020-10-01 19:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 12:13 bug#43702: Emacs master: Incorrect highlighting in regexp isearch Alan Mackenzie
2020-09-29 14:43 ` Eli Zaretskii
2020-09-29 15:33 ` Alan Mackenzie
2020-09-29 16:07 ` Eli Zaretskii
2020-09-30 2:08 ` Lars Ingebrigtsen
2020-09-30 19:16 ` Juri Linkov
2020-09-30 21:28 ` Drew Adams
2020-10-01 19:11 ` Juri Linkov
2020-10-01 19:38 ` Drew Adams
2020-10-01 22:41 ` Drew Adams
2020-10-06 20:01 ` Juri Linkov
2020-10-06 22:40 ` Drew Adams
2020-10-07 8:13 ` Juri Linkov
2020-10-07 15:42 ` Drew Adams
2020-10-12 19:59 ` Juri Linkov
2020-10-12 23:07 ` Drew Adams
2020-10-13 20:14 ` Juri Linkov
2020-10-13 20:54 ` Drew Adams
2020-10-14 8:57 ` Juri Linkov
2020-10-14 17:03 ` Drew Adams
2020-10-07 7:16 ` Eli Zaretskii
2020-10-07 8:09 ` Juri Linkov
2020-10-07 9:14 ` Eli Zaretskii
2020-10-07 19:09 ` Juri Linkov
2020-10-07 20:02 ` Drew Adams
2020-10-07 20:22 ` Juri Linkov
2020-10-07 20:56 ` Drew Adams
2020-10-01 1:12 ` Lars Ingebrigtsen
2020-10-01 19:20 ` Juri Linkov
2020-10-01 19:23 ` Lars Ingebrigtsen
2020-10-01 19:26 ` Eli Zaretskii
2020-10-01 19:39 ` Drew Adams [this message]
2020-10-02 6:57 ` Juri Linkov
2020-10-06 20:17 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=899b2057-7389-464b-91f3-12d23125fdee@default \
--to=drew.adams@oracle.com \
--cc=43702@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).