From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch. Date: Thu, 1 Oct 2020 12:39:50 -0700 (PDT) Message-ID: <899b2057-7389-464b-91f3-12d23125fdee@default> References: <20200929121317.GA27007@ACM> <83wo0ck5ig.fsf@gnu.org> <20200929153355.GB27007@ACM> <87y2ks819k.fsf@gnus.org> <87y2krdqsk.fsf@mail.linkov.net> <87pn62wxz6.fsf@gnus.org> <878scp92mo.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19723"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Mackenzie , 43702@debbugs.gnu.org To: Juri Linkov , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 01 21:41:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO4Ry-00053S-92 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 21:41:10 +0200 Original-Received: from localhost ([::1]:48152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO4Rx-0003Px-By for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 15:41:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO4Rq-0003Pb-CX for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 15:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55124) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kO4Rq-0004UU-3P for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 15:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kO4Rq-0005Sv-2A for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 15:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 19:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43702 X-GNU-PR-Package: emacs Original-Received: via spool by 43702-submit@debbugs.gnu.org id=B43702.160158120520931 (code B ref 43702); Thu, 01 Oct 2020 19:41:02 +0000 Original-Received: (at 43702) by debbugs.gnu.org; 1 Oct 2020 19:40:05 +0000 Original-Received: from localhost ([127.0.0.1]:38437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO4Qv-0005RW-B2 for submit@debbugs.gnu.org; Thu, 01 Oct 2020 15:40:05 -0400 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:48196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO4Qq-0005Qm-Gd for 43702@debbugs.gnu.org; Thu, 01 Oct 2020 15:40:04 -0400 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 091JdsHM137446; Thu, 1 Oct 2020 19:39:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=Gw5ajv7yp+XqrdHNGbtldtKil5gdBhJ4v77gg4KEDvI=; b=jzp5q6YARrrSzQWDOvG7tLZjiwmSCQS3KY4XVVjytfc5JjxdtCNHSzuVEQSgCm8zkRjD AOMwljBQG65tjh5S5u7U+tejcffuyQL073kfOlWm/kJacKUIGFL/kf7B5PfWx8iqLctP thDYImMFg6GYw7yNfpCxxpYuVuDP9jae+Y4nK/ghln+gXpULYZ2s5M/WiW6cIr7WS/TQ icfJ1KE4uQqo/jiFV+7/PFRjOsbtX5/j7DDQHj0ZXYTTQvMObDBt0ni39MgDwZd/YfpE 9gTEFq1BCpuFSl6XiqhAa4atF/nkVN2qDiScDLWGrcWKgF1CjX+wZ01AEAx17R678Eg5 mg== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 33su5b832q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 01 Oct 2020 19:39:54 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 091JdqCU128969; Thu, 1 Oct 2020 19:39:53 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 33tfk24p2h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 01 Oct 2020 19:39:53 +0000 Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 091JdpmE022834; Thu, 1 Oct 2020 19:39:51 GMT In-Reply-To: <878scp92mo.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9761 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010010158 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9761 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 mlxscore=0 impostorscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010010158 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189579 Archived-At: > >> Maybe better to do what Drew proposed: to distinguish the odd groups > >> from the even groups, i.e. to have only 2 additional faces > >> (a brighter face like the current isearch-group-1 for the odd groups, > >> and a darker face for the even groups). > > > > I like the idea. >=20 > Implemented now on the trunk where isearch-group-odd is created > from the isearch-group-1 face, and isearch-group-even > from the isearch-group-4 face. >=20 > The result is quite nice: Sorry, but IMO that's horrible. And you really should show more regexps, not just a sequence of groups, but nested groups etc. Regexp matching is complex. And that's the point: WYSIWYG visualization of a user's regexp on the fly. My suggestion: provide a fair number of group faces, to make it easy to identify which parts of a regexp correspond to which parts of the current search hit. This should be simple. I've done it. And used it, for a long time. Why reinvent the wheel, replacing a circle with an octagon?