From: Juri Linkov <juri@linkov.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: Alan Mackenzie <acm@muc.de>, Lars Ingebrigtsen <larsi@gnus.org>,
43702@debbugs.gnu.org
Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch.
Date: Wed, 07 Oct 2020 11:13:35 +0300 [thread overview]
Message-ID: <871riav4os.fsf@mail.linkov.net> (raw)
In-Reply-To: <f4a417d9-07c3-476c-bb8f-07f25e9f4533@default> (Drew Adams's message of "Tue, 6 Oct 2020 15:40:43 -0700 (PDT)")
> See attached, which are the faces I use by default
> (for a light background mode).
>
> It's harder to tell 3 from 7, but needing to do that will be
> relatively rare.
I agree, it's hard to tell 3 from 7 when highlighting a complex nested regexp.
>> I started implementing group matches highlighting for lazy-highlight and also
>> for query-replace, but then realized neither lazy-highlight nor query-replace
>> need no such thing because this highlighting is only useful while
>> incrementally constructing/inspecting a complex regexp for the current match
>> in incremental isearch mode.
>
> I don't agree, but won't argue about it. I redefined
> `replace-highlight' and `replace-dehighlight' so they
> do highlight regexp groups, and I think it's helpful.
After query-replace is started, the regexp is already created
(either with the help of isearch group submatches highlighting
or typed directly on the query-replace prompt), so during replacements
the user has only to decide for each match whether to replace it or not
by answering the y/n question for the currently highlighted regexp.
How highlighting the replacement submatches will help the user to decide
whether to replace the current match or not?
next prev parent reply other threads:[~2020-10-07 8:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 12:13 bug#43702: Emacs master: Incorrect highlighting in regexp isearch Alan Mackenzie
2020-09-29 14:43 ` Eli Zaretskii
2020-09-29 15:33 ` Alan Mackenzie
2020-09-29 16:07 ` Eli Zaretskii
2020-09-30 2:08 ` Lars Ingebrigtsen
2020-09-30 19:16 ` Juri Linkov
2020-09-30 21:28 ` Drew Adams
2020-10-01 19:11 ` Juri Linkov
2020-10-01 19:38 ` Drew Adams
2020-10-01 22:41 ` Drew Adams
2020-10-06 20:01 ` Juri Linkov
2020-10-06 22:40 ` Drew Adams
2020-10-07 8:13 ` Juri Linkov [this message]
2020-10-07 15:42 ` Drew Adams
2020-10-12 19:59 ` Juri Linkov
2020-10-12 23:07 ` Drew Adams
2020-10-13 20:14 ` Juri Linkov
2020-10-13 20:54 ` Drew Adams
2020-10-14 8:57 ` Juri Linkov
2020-10-14 17:03 ` Drew Adams
2020-10-07 7:16 ` Eli Zaretskii
2020-10-07 8:09 ` Juri Linkov
2020-10-07 9:14 ` Eli Zaretskii
2020-10-07 19:09 ` Juri Linkov
2020-10-07 20:02 ` Drew Adams
2020-10-07 20:22 ` Juri Linkov
2020-10-07 20:56 ` Drew Adams
2020-10-01 1:12 ` Lars Ingebrigtsen
2020-10-01 19:20 ` Juri Linkov
2020-10-01 19:23 ` Lars Ingebrigtsen
2020-10-01 19:26 ` Eli Zaretskii
2020-10-01 19:39 ` Drew Adams
2020-10-02 6:57 ` Juri Linkov
2020-10-06 20:17 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871riav4os.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=43702@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=drew.adams@oracle.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).