From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: acm@muc.de, larsi@gnus.org, 43702@debbugs.gnu.org
Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch.
Date: Wed, 07 Oct 2020 11:09:09 +0300 [thread overview]
Message-ID: <87imbmqvki.fsf@mail.linkov.net> (raw)
In-Reply-To: <83ft6qa4ky.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 07 Oct 2020 10:16:29 +0300")
>> > As I mentioned, it's simple to just repeat the use
>> > of the same 8 faces, for 9-16, 17-24, etc.
>>
>> This is a very good idea. Now this is implemented in isearch.
>
> I don't think I understand the change, and the documentation doesn't
> seem to help. It seems like now there are just two faces that are
> used alternately, i.e. one face for odd-numbered groups, the other for
> even-numbered groups? If this is the case, why doesn't the
> documentation say so explicitly? And if this is not the case, what
> did I miss?
Yes, by default isearch-group-1 is used for odd-numbered groups,
and isearch-group-2 for even-numbered groups.
But when a user or a theme author will define a new face
isearch-group-3, then isearch-group-3 will be used to highlight
groups 3, 6, 9, 12, ..., the isearch-group-2 face to highlight
groups 2, 5, 8, 11, ..., the isearch-group-1 face to highlight
groups 1, 4, 7, 10, ...
A user or a theme author can define more faces, e.g.
isearch-group-4, isearch-group-5, isearch-group-6,
and these faces will be recycled:
submatches: 1 2 3 4 5 6 7 8 9 10 11 12
group faces: 1 2 3 4 5 6 1 2 3 4 5 6
>> I suppose you agree that the previous color palette in isearch
>> with a color gradient is not suitable for highlighting of group matches
>> because while looking at highlighted matches it's quite impossible to
>> say which color corresponds to which group number.
>
> And with the current implementation on master it is possible? If so,
> how?
With only 2 default group faces it's possible to see that one of them
isearch-group-1 is brighter than the default isearch face, and another
isearch-group-2 is darker than the default isearch face.
next prev parent reply other threads:[~2020-10-07 8:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 12:13 bug#43702: Emacs master: Incorrect highlighting in regexp isearch Alan Mackenzie
2020-09-29 14:43 ` Eli Zaretskii
2020-09-29 15:33 ` Alan Mackenzie
2020-09-29 16:07 ` Eli Zaretskii
2020-09-30 2:08 ` Lars Ingebrigtsen
2020-09-30 19:16 ` Juri Linkov
2020-09-30 21:28 ` Drew Adams
2020-10-01 19:11 ` Juri Linkov
2020-10-01 19:38 ` Drew Adams
2020-10-01 22:41 ` Drew Adams
2020-10-06 20:01 ` Juri Linkov
2020-10-06 22:40 ` Drew Adams
2020-10-07 8:13 ` Juri Linkov
2020-10-07 15:42 ` Drew Adams
2020-10-12 19:59 ` Juri Linkov
2020-10-12 23:07 ` Drew Adams
2020-10-13 20:14 ` Juri Linkov
2020-10-13 20:54 ` Drew Adams
2020-10-14 8:57 ` Juri Linkov
2020-10-14 17:03 ` Drew Adams
2020-10-07 7:16 ` Eli Zaretskii
2020-10-07 8:09 ` Juri Linkov [this message]
2020-10-07 9:14 ` Eli Zaretskii
2020-10-07 19:09 ` Juri Linkov
2020-10-07 20:02 ` Drew Adams
2020-10-07 20:22 ` Juri Linkov
2020-10-07 20:56 ` Drew Adams
2020-10-01 1:12 ` Lars Ingebrigtsen
2020-10-01 19:20 ` Juri Linkov
2020-10-01 19:23 ` Lars Ingebrigtsen
2020-10-01 19:26 ` Eli Zaretskii
2020-10-01 19:39 ` Drew Adams
2020-10-02 6:57 ` Juri Linkov
2020-10-06 20:17 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imbmqvki.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=43702@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).