* bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer
@ 2019-10-10 23:17 Stefan Kangas
2019-10-20 22:34 ` Juri Linkov
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2019-10-10 23:17 UTC (permalink / raw)
To: 37699
Steps to reproduce:
0. emacs -Q
1. M-x dired RET RET
2. M-x global-tab-line-mode
2. Mark some files using "m"
3. Type some command e.g. "!"
Result: There are tabs in the window showing the "*Marked Files*" buffer.
There should be no tabs in this window. I believe the function
dired-mark-pop-up is where we show the marked files.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer
2019-10-10 23:17 bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer Stefan Kangas
@ 2019-10-20 22:34 ` Juri Linkov
2019-10-23 21:34 ` Juri Linkov
0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2019-10-20 22:34 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 37699
> Steps to reproduce:
>
> 0. emacs -Q
> 1. M-x dired RET RET
> 2. M-x global-tab-line-mode
> 2. Mark some files using "m"
> 3. Type some command e.g. "!"
>
> Result: There are tabs in the window showing the "*Marked Files*" buffer.
>
> There should be no tabs in this window. I believe the function
> dired-mark-pop-up is where we show the marked files.
I propose the following patch:
diff --git a/lisp/dired.el b/lisp/dired.el
index 3146511305..75dfbc4b9a 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -3436,7 +3436,8 @@ dired-mark-pop-up
(dired-format-columns-of-files
(if (eq (car files) t) (cdr files) files))
(remove-text-properties (point-min) (point-max)
- '(mouse-face nil help-echo nil)))))))
+ '(mouse-face nil help-echo nil))
+ (setq tab-line-format nil))))))
(defun dired-format-columns-of-files (files)
(let ((beg (point)))
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer
2019-10-20 22:34 ` Juri Linkov
@ 2019-10-23 21:34 ` Juri Linkov
2019-10-26 22:41 ` Juri Linkov
0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2019-10-23 21:34 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 37699
>> Steps to reproduce:
>>
>> 0. emacs -Q
>> 1. M-x dired RET RET
>> 2. M-x global-tab-line-mode
>> 2. Mark some files using "m"
>> 3. Type some command e.g. "!"
>>
>> Result: There are tabs in the window showing the "*Marked Files*" buffer.
>>
>> There should be no tabs in this window. I believe the function
>> dired-mark-pop-up is where we show the marked files.
>
> I propose the following patch:
This is pushed now. Please confirm if everything is right before closing.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer
2019-10-23 21:34 ` Juri Linkov
@ 2019-10-26 22:41 ` Juri Linkov
2019-11-06 23:24 ` Stefan Kangas
0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2019-10-26 22:41 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 37699
>>> Steps to reproduce:
>>>
>>> 0. emacs -Q
>>> 1. M-x dired RET RET
>>> 2. M-x global-tab-line-mode
>>> 2. Mark some files using "m"
>>> 3. Type some command e.g. "!"
>>>
>>> Result: There are tabs in the window showing the "*Marked Files*" buffer.
>>>
>>> There should be no tabs in this window. I believe the function
>>> dired-mark-pop-up is where we show the marked files.
>>
>> I propose the following patch:
>
> This is pushed now. Please confirm if everything is right before closing.
Now pushed a better fix to set tab-line-exclude to nil
(instead of setting tab-line-format).
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer
2019-10-26 22:41 ` Juri Linkov
@ 2019-11-06 23:24 ` Stefan Kangas
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Kangas @ 2019-11-06 23:24 UTC (permalink / raw)
To: Juri Linkov; +Cc: 37699
close 37699 27.1
thanks
Juri Linkov <juri@linkov.net> writes:
>> This is pushed now. Please confirm if everything is right before closing.
>
> Now pushed a better fix to set tab-line-exclude to nil
> (instead of setting tab-line-format).
I can confirm that this is working now, so I'll just go ahead and
close this bug. Thanks Juri for fixing it.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-06 23:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-10 23:17 bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer Stefan Kangas
2019-10-20 22:34 ` Juri Linkov
2019-10-23 21:34 ` Juri Linkov
2019-10-26 22:41 ` Juri Linkov
2019-11-06 23:24 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).