From: Juri Linkov <juri@linkov.net>
To: Stefan Kangas <stefan@marxist.se>
Cc: 37699@debbugs.gnu.org
Subject: bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer
Date: Mon, 21 Oct 2019 01:34:16 +0300 [thread overview]
Message-ID: <87imojdqfz.fsf@mail.linkov.net> (raw)
In-Reply-To: <CADwFkmmRZgvLwee+KL305TSbXbU65xGeo90toD0S0LYUn17_XQ@mail.gmail.com> (Stefan Kangas's message of "Fri, 11 Oct 2019 01:17:08 +0200")
> Steps to reproduce:
>
> 0. emacs -Q
> 1. M-x dired RET RET
> 2. M-x global-tab-line-mode
> 2. Mark some files using "m"
> 3. Type some command e.g. "!"
>
> Result: There are tabs in the window showing the "*Marked Files*" buffer.
>
> There should be no tabs in this window. I believe the function
> dired-mark-pop-up is where we show the marked files.
I propose the following patch:
diff --git a/lisp/dired.el b/lisp/dired.el
index 3146511305..75dfbc4b9a 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -3436,7 +3436,8 @@ dired-mark-pop-up
(dired-format-columns-of-files
(if (eq (car files) t) (cdr files) files))
(remove-text-properties (point-min) (point-max)
- '(mouse-face nil help-echo nil)))))))
+ '(mouse-face nil help-echo nil))
+ (setq tab-line-format nil))))))
(defun dired-format-columns-of-files (files)
(let ((beg (point)))
next prev parent reply other threads:[~2019-10-20 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 23:17 bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer Stefan Kangas
2019-10-20 22:34 ` Juri Linkov [this message]
2019-10-23 21:34 ` Juri Linkov
2019-10-26 22:41 ` Juri Linkov
2019-11-06 23:24 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imojdqfz.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=37699@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).