From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#37699: global-tab-line-mode and dired "*Marked Files*" buffer Date: Mon, 21 Oct 2019 01:34:16 +0300 Organization: LINKOV.NET Message-ID: <87imojdqfz.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="29459"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 37699@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 21 00:43:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMJuk-0007Wp-Ee for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 00:43:06 +0200 Original-Received: from localhost ([::1]:50470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMJui-0003Ei-VO for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 18:43:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32893) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMJtk-0002bG-8V for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 18:42:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMJtj-0003Fc-70 for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 18:42:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMJtj-0003FY-4H for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 18:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMJtj-0005HD-17 for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 18:42:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2019 22:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37699 X-GNU-PR-Package: emacs Original-Received: via spool by 37699-submit@debbugs.gnu.org id=B37699.157161130820243 (code B ref 37699); Sun, 20 Oct 2019 22:42:02 +0000 Original-Received: (at 37699) by debbugs.gnu.org; 20 Oct 2019 22:41:48 +0000 Original-Received: from localhost ([127.0.0.1]:55439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMJtT-0005GQ-JS for submit@debbugs.gnu.org; Sun, 20 Oct 2019 18:41:47 -0400 Original-Received: from buffalo.birch.relay.mailchannels.net ([23.83.209.24]:48223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMJtQ-0005GG-PO for 37699@debbugs.gnu.org; Sun, 20 Oct 2019 18:41:46 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 2C4656A12BD; Sun, 20 Oct 2019 22:41:42 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a8.g.dreamhost.com (100-96-87-223.trex.outbound.svc.cluster.local [100.96.87.223]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BD4E36A135F; Sun, 20 Oct 2019 22:41:41 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a8.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sun, 20 Oct 2019 22:41:42 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Squirrel-Abaft: 294b06562309620f_1571611301981_335996452 X-MC-Loop-Signature: 1571611301981:141788628 X-MC-Ingress-Time: 1571611301980 Original-Received: from pdx1-sub0-mail-a8.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a8.g.dreamhost.com (Postfix) with ESMTP id C0EF097EDA; Sun, 20 Oct 2019 15:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=DJXlDdrKExndXsaspS2JB5KziY0=; b= pyODPngCUZvRo5Yqt1mRnSxHo0VckWlsiuwLMFr1l7PXHth8Z2gl01AwmgrOQFdo MO4xGSNKqHH8HxxHsbIlIqCNJ/8sVT8ASPzVnRb/LMXVAg17neBZmQfJ3IAsiWfP QGxJGkAfaO/f/rATgzqUupnpwLVGM8JqHxh5g2e4CWU= Original-Received: from mail.jurta.org (m91-129-98-153.cust.tele2.ee [91.129.98.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a8.g.dreamhost.com (Postfix) with ESMTPSA id C53EE97ED7; Sun, 20 Oct 2019 15:41:37 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a8 In-Reply-To: (Stefan Kangas's message of "Fri, 11 Oct 2019 01:17:08 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169871 Archived-At: > Steps to reproduce: > > 0. emacs -Q > 1. M-x dired RET RET > 2. M-x global-tab-line-mode > 2. Mark some files using "m" > 3. Type some command e.g. "!" > > Result: There are tabs in the window showing the "*Marked Files*" buffer. > > There should be no tabs in this window. I believe the function > dired-mark-pop-up is where we show the marked files. I propose the following patch: diff --git a/lisp/dired.el b/lisp/dired.el index 3146511305..75dfbc4b9a 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -3436,7 +3436,8 @@ dired-mark-pop-up (dired-format-columns-of-files (if (eq (car files) t) (cdr files) files)) (remove-text-properties (point-min) (point-max) - '(mouse-face nil help-echo nil))))))) + '(mouse-face nil help-echo nil)) + (setq tab-line-format nil)))))) (defun dired-format-columns-of-files (files) (let ((beg (point)))