bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets

bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets

[Alex Bochannek]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

When using an expiry target mailbox and an IMAP server that does not
support move (Dovecot as per nnimap-quirks), messages will be copied,
but not deleted after expiry.

This was introduced with use of lexical-binding in Gnus and the
difference between set and setq.

The below patch fixes the problem.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 670 bytes --]

diff --git a/lisp/gnus/nnimap.el b/lisp/gnus/nnimap.el
index 570be49094..f869f586d9 100644
--- a/lisp/gnus/nnimap.el
+++ b/lisp/gnus/nnimap.el
@@ -1076,7 +1076,9 @@ nnimap-process-expiry-targets
                   "UID COPY %s %S")
                 (nnimap-article-ranges (gnus-compress-sequence articles))
                 (nnimap-group-to-imap (gnus-group-real-name nnmail-expiry-target)))
-               (set (if can-move 'deleted-articles 'articles-to-delete) articles))))
+               (if can-move
+                   (setq deleted-articles articles)
+                 (setq articles-to-delete articles)))))
       t)
      (t
       (dolist (article articles)

[-- Attachment #3: Type: text/plain, Size: 11 bytes --]


-- 
Alex.

bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets

[Lars Ingebrigtsen]

Alex Bochannek <alex@bochannek.com> writes:

> When using an expiry target mailbox and an IMAP server that does not
> support move (Dovecot as per nnimap-quirks), messages will be copied,
> but not deleted after expiry.
>
> This was introduced with use of lexical-binding in Gnus and the
> difference between set and setq.
>
> The below patch fixes the problem.

Thanks; looks good.

I thought we had FSF copyright assignment paperwork on file (as there's
been several patches applied from you before), but I can't see your name
in the copyright file now.  Have you been through the copyright
assignment process?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Have you been through the copyright assignment process?

Never mind -- I see that you've already been asked this in a different
bug report (and the answer is "not yet").

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets

[Alex Bochannek]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Have you been through the copyright assignment process?
>
> Never mind -- I see that you've already been asked this in a different
> bug report (and the answer is "not yet").

I submitted the signed paperwork today. In the past I had done some work
when my employer at the time already had an agreement in place.

-- 
Alex.

bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets

[Lars Ingebrigtsen]

Alex Bochannek <alex@bochannek.com> writes:

> I submitted the signed paperwork today. In the past I had done some work
> when my employer at the time already had an agreement in place.

Ah; right -- I had forgotten about that.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets

[Lars Ingebrigtsen]

Alex Bochannek <alex@bochannek.com> writes:

> This was introduced with use of lexical-binding in Gnus and the
> difference between set and setq.
>
> The below patch fixes the problem.

Thanks; pushed to Emacs 28 now.

I also grepped through the Emacs tree to see whether there were any
other instances of (set (if ...)), but this seemed to be the only
instance.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets

[Alex Bochannek]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Alex Bochannek <alex@bochannek.com> writes:
>
>> This was introduced with use of lexical-binding in Gnus and the
>> difference between set and setq.
>>
>> The below patch fixes the problem.
>
> Thanks; pushed to Emacs 28 now.
>
> I also grepped through the Emacs tree to see whether there were any
> other instances of (set (if ...)), but this seemed to be the only
> instance.

Thank you.

-- 
Alex.