* bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets
@ 2021-05-21 23:43 Alex Bochannek
2021-05-25 4:05 ` Lars Ingebrigtsen
2021-05-27 23:21 ` Lars Ingebrigtsen
0 siblings, 2 replies; 7+ messages in thread
From: Alex Bochannek @ 2021-05-21 23:43 UTC (permalink / raw)
To: 48577
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
When using an expiry target mailbox and an IMAP server that does not
support move (Dovecot as per nnimap-quirks), messages will be copied,
but not deleted after expiry.
This was introduced with use of lexical-binding in Gnus and the
difference between set and setq.
The below patch fixes the problem.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 670 bytes --]
diff --git a/lisp/gnus/nnimap.el b/lisp/gnus/nnimap.el
index 570be49094..f869f586d9 100644
--- a/lisp/gnus/nnimap.el
+++ b/lisp/gnus/nnimap.el
@@ -1076,7 +1076,9 @@ nnimap-process-expiry-targets
"UID COPY %s %S")
(nnimap-article-ranges (gnus-compress-sequence articles))
(nnimap-group-to-imap (gnus-group-real-name nnmail-expiry-target)))
- (set (if can-move 'deleted-articles 'articles-to-delete) articles))))
+ (if can-move
+ (setq deleted-articles articles)
+ (setq articles-to-delete articles)))))
t)
(t
(dolist (article articles)
[-- Attachment #3: Type: text/plain, Size: 11 bytes --]
--
Alex.
^ permalink raw reply related [flat|nested] 7+ messages in thread* bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets
2021-05-21 23:43 bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets Alex Bochannek
@ 2021-05-25 4:05 ` Lars Ingebrigtsen
2021-05-25 4:10 ` Lars Ingebrigtsen
2021-05-27 23:21 ` Lars Ingebrigtsen
1 sibling, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2021-05-25 4:05 UTC (permalink / raw)
To: Alex Bochannek; +Cc: 48577
Alex Bochannek <alex@bochannek.com> writes:
> When using an expiry target mailbox and an IMAP server that does not
> support move (Dovecot as per nnimap-quirks), messages will be copied,
> but not deleted after expiry.
>
> This was introduced with use of lexical-binding in Gnus and the
> difference between set and setq.
>
> The below patch fixes the problem.
Thanks; looks good.
I thought we had FSF copyright assignment paperwork on file (as there's
been several patches applied from you before), but I can't see your name
in the copyright file now. Have you been through the copyright
assignment process?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets
2021-05-21 23:43 bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets Alex Bochannek
2021-05-25 4:05 ` Lars Ingebrigtsen
@ 2021-05-27 23:21 ` Lars Ingebrigtsen
2021-05-28 2:04 ` Alex Bochannek
1 sibling, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2021-05-27 23:21 UTC (permalink / raw)
To: Alex Bochannek; +Cc: 48577
Alex Bochannek <alex@bochannek.com> writes:
> This was introduced with use of lexical-binding in Gnus and the
> difference between set and setq.
>
> The below patch fixes the problem.
Thanks; pushed to Emacs 28 now.
I also grepped through the Emacs tree to see whether there were any
other instances of (set (if ...)), but this seemed to be the only
instance.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets
2021-05-27 23:21 ` Lars Ingebrigtsen
@ 2021-05-28 2:04 ` Alex Bochannek
0 siblings, 0 replies; 7+ messages in thread
From: Alex Bochannek @ 2021-05-28 2:04 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 48577
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Alex Bochannek <alex@bochannek.com> writes:
>
>> This was introduced with use of lexical-binding in Gnus and the
>> difference between set and setq.
>>
>> The below patch fixes the problem.
>
> Thanks; pushed to Emacs 28 now.
>
> I also grepped through the Emacs tree to see whether there were any
> other instances of (set (if ...)), but this seemed to be the only
> instance.
Thank you.
--
Alex.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-05-28 2:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 23:43 bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets Alex Bochannek
2021-05-25 4:05 ` Lars Ingebrigtsen
2021-05-25 4:10 ` Lars Ingebrigtsen
2021-05-25 7:28 ` Alex Bochannek
2021-05-25 19:17 ` Lars Ingebrigtsen
2021-05-27 23:21 ` Lars Ingebrigtsen
2021-05-28 2:04 ` Alex Bochannek
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).