* bug#44188: [PATCH] Use lexical binding in wdired.el @ 2020-10-23 23:15 Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors 2020-10-23 23:23 ` bug#44188: [PATCH] Use lexical binding for several Elisp files Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors 0 siblings, 1 reply; 4+ messages in thread From: Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-10-23 23:15 UTC (permalink / raw) To: 44188 [-- Attachment #1: Type: text/plain, Size: 224 bytes --] See attached. I don't notice any byte-compilation warnings, or unused let-bound variables. Please let me know if there's anything else that needs to be done. -- Sent with https://mailfence.com Secure and private email [-- Attachment #2: File Attachment: 0001-Use-lexical-binding-in-wdired.el.patch --] [-- Type: text/x-diff, Size: 694 bytes --] From 908a188298035e45d1c35f95d550312bfb146b46 Mon Sep 17 00:00:00 2001 From: Brian Leung <leungbk@mailfence.com> Date: Fri, 23 Oct 2020 16:11:29 -0700 Subject: [PATCH] Use lexical binding in wdired.el --- lisp/wdired.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/wdired.el b/lisp/wdired.el index da162b7bb2..b675ec8bfb 100644 --- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -1,4 +1,4 @@ -;;; wdired.el --- Rename files editing their names in dired buffers -*- coding: utf-8; -*- +;;; wdired.el --- Rename files editing their names in dired buffers -*- lexical-binding: t; coding: utf-8 -*- ;; Copyright (C) 2004-2020 Free Software Foundation, Inc. -- 2.28.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#44188: [PATCH] Use lexical binding for several Elisp files 2020-10-23 23:15 bug#44188: [PATCH] Use lexical binding in wdired.el Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-10-23 23:23 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors 2020-10-26 16:01 ` bug#44188: [PATCH] Use lexical binding in wdired.el Lars Ingebrigtsen 0 siblings, 1 reply; 4+ messages in thread From: Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-10-23 23:23 UTC (permalink / raw) To: 44188 [-- Attachment #1: Type: text/plain, Size: 115 bytes --] I enforced lexical binding in a few other files. -- Sent with https://mailfence.com Secure and private email [-- Attachment #2: File Attachment: 0001-Use-lexical-binding-in-wdired.el.patch --] [-- Type: text/x-diff, Size: 698 bytes --] From 908a188298035e45d1c35f95d550312bfb146b46 Mon Sep 17 00:00:00 2001 From: Brian Leung <leungbk@mailfence.com> Date: Fri, 23 Oct 2020 16:11:29 -0700 Subject: [PATCH 1/4] Use lexical binding in wdired.el --- lisp/wdired.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/wdired.el b/lisp/wdired.el index da162b7bb2..b675ec8bfb 100644 --- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -1,4 +1,4 @@ -;;; wdired.el --- Rename files editing their names in dired buffers -*- coding: utf-8; -*- +;;; wdired.el --- Rename files editing their names in dired buffers -*- lexical-binding: t; coding: utf-8 -*- ;; Copyright (C) 2004-2020 Free Software Foundation, Inc. -- 2.28.0 [-- Attachment #3: File Attachment: 0002-Use-lexical-binding-in-wid-browse.el.patch --] [-- Type: text/x-diff, Size: 664 bytes --] From ae7d3352f9ca4d919fab3917cef84734178a9a66 Mon Sep 17 00:00:00 2001 From: Brian Leung <leungbk@mailfence.com> Date: Fri, 23 Oct 2020 16:17:46 -0700 Subject: [PATCH 2/4] Use lexical binding in wid-browse.el --- lisp/wid-browse.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/wid-browse.el b/lisp/wid-browse.el index 53f918cff9..b7171dcb45 100644 --- a/lisp/wid-browse.el +++ b/lisp/wid-browse.el @@ -1,4 +1,4 @@ -;;; wid-browse.el --- functions for browsing widgets +;;; wid-browse.el --- functions for browsing widgets -*- lexical-binding: t -*- ;; ;; Copyright (C) 1997, 2001-2020 Free Software Foundation, Inc. ;; -- 2.28.0 [-- Attachment #4: File Attachment: 0003-Use-lexical-binding-in-widget.el.patch --] [-- Type: text/x-diff, Size: 653 bytes --] From 2814d5d6841e4c1545d983513c9978a1b4bd9a22 Mon Sep 17 00:00:00 2001 From: Brian Leung <leungbk@mailfence.com> Date: Fri, 23 Oct 2020 16:20:01 -0700 Subject: [PATCH 3/4] Use lexical binding in widget.el --- lisp/widget.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/widget.el b/lisp/widget.el index 8f1e090161..dcf770ea30 100644 --- a/lisp/widget.el +++ b/lisp/widget.el @@ -1,4 +1,4 @@ -;;; widget.el --- a library of user interface components +;;; widget.el --- a library of user interface components -*- lexical-binding: t -*- ;; ;; Copyright (C) 1996-1997, 2001-2020 Free Software Foundation, Inc. ;; -- 2.28.0 [-- Attachment #5: File Attachment: 0004-Use-lexical-binding-in-winner.el.patch --] [-- Type: text/x-diff, Size: 639 bytes --] From b5806eab32c71bb1c16b312c5431fe88d77d862e Mon Sep 17 00:00:00 2001 From: Brian Leung <leungbk@mailfence.com> Date: Fri, 23 Oct 2020 16:20:07 -0700 Subject: [PATCH 4/4] Use lexical binding in winner.el --- lisp/winner.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/winner.el b/lisp/winner.el index 4313e76719..e55ab710c4 100644 --- a/lisp/winner.el +++ b/lisp/winner.el @@ -1,4 +1,4 @@ -;;; winner.el --- Restore old window configurations +;;; winner.el --- Restore old window configurations -*- lexical-binding: t -*- ;; Copyright (C) 1997-1998, 2001-2020 Free Software Foundation, Inc. -- 2.28.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#44188: [PATCH] Use lexical binding in wdired.el 2020-10-23 23:23 ` bug#44188: [PATCH] Use lexical binding for several Elisp files Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-10-26 16:01 ` Lars Ingebrigtsen 2021-05-11 13:37 ` Lars Ingebrigtsen 0 siblings, 1 reply; 4+ messages in thread From: Lars Ingebrigtsen @ 2020-10-26 16:01 UTC (permalink / raw) To: Brian Leung; +Cc: 44188 Brian Leung <leungbk@mailfence.com> writes: > I enforced lexical binding in a few other files. Thanks, but I'm slightly worried whether these have been tested? There's sometimes subtle problems with converting to lexical binding that's not obvious from just compiling the files, but is only revealed by actually using the functions. So when converting to lexical binding, we try to (where it makes sense) to add some unit tests to test/lisp/<file>-tests.el at the same time to give us greater confidence that the mechanisms still work. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#44188: [PATCH] Use lexical binding in wdired.el 2020-10-26 16:01 ` bug#44188: [PATCH] Use lexical binding in wdired.el Lars Ingebrigtsen @ 2021-05-11 13:37 ` Lars Ingebrigtsen 0 siblings, 0 replies; 4+ messages in thread From: Lars Ingebrigtsen @ 2021-05-11 13:37 UTC (permalink / raw) To: Brian Leung; +Cc: 44188 All the files in question have been converted to lexical binding now, as far as I can tell, so I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-11 13:37 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-10-23 23:15 bug#44188: [PATCH] Use lexical binding in wdired.el Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors 2020-10-23 23:23 ` bug#44188: [PATCH] Use lexical binding for several Elisp files Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors 2020-10-26 16:01 ` bug#44188: [PATCH] Use lexical binding in wdired.el Lars Ingebrigtsen 2021-05-11 13:37 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).