unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Brian Leung <leungbk@mailfence.com>
Cc: 44188@debbugs.gnu.org
Subject: bug#44188: [PATCH] Use lexical binding in wdired.el
Date: Mon, 26 Oct 2020 17:01:44 +0100	[thread overview]
Message-ID: <87zh49x9g7.fsf_-_@gnus.org> (raw)
In-Reply-To: <930162507.128721.1603495416517@ichabod.co-bxl> (Brian Leung's message of "Sat, 24 Oct 2020 01:23:36 +0200 (CEST)")

Brian Leung <leungbk@mailfence.com> writes:

> I enforced lexical binding in a few other files.

Thanks, but I'm slightly worried whether these have been tested?
There's sometimes subtle problems with converting to lexical binding
that's not obvious from just compiling the files, but is only revealed
by actually using the functions.

So when converting to lexical binding, we try to (where it makes sense)
to add some unit tests to test/lisp/<file>-tests.el at the same time to
give us greater confidence that the mechanisms still work.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-10-26 16:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23 23:15 bug#44188: [PATCH] Use lexical binding in wdired.el Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-23 23:23 ` bug#44188: [PATCH] Use lexical binding for several Elisp files Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-26 16:01   ` Lars Ingebrigtsen [this message]
2021-05-11 13:37     ` bug#44188: [PATCH] Use lexical binding in wdired.el Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh49x9g7.fsf_-_@gnus.org \
    --to=larsi@gnus.org \
    --cc=44188@debbugs.gnu.org \
    --cc=leungbk@mailfence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).