From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44188: [PATCH] Use lexical binding in wdired.el Date: Mon, 26 Oct 2020 17:01:44 +0100 Message-ID: <87zh49x9g7.fsf_-_@gnus.org> References: <649664717.128563.1603494942107@ichabod.co-bxl> <930162507.128721.1603495416517@ichabod.co-bxl> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6067"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44188@debbugs.gnu.org To: Brian Leung Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 26 17:05:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX4zz-0001Q9-Tg for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 17:05:31 +0100 Original-Received: from localhost ([::1]:43762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX4zy-00064Q-Vb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 12:05:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX4xa-0003I7-DV for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 12:03:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57660) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kX4xa-0005tX-2Z for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 12:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kX4xZ-0002Wk-Vu for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 12:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 16:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44188 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44188-submit@debbugs.gnu.org id=B44188.16037281228000 (code B ref 44188); Mon, 26 Oct 2020 16:03:01 +0000 Original-Received: (at 44188) by debbugs.gnu.org; 26 Oct 2020 16:02:02 +0000 Original-Received: from localhost ([127.0.0.1]:40973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX4wb-00024l-Sg for submit@debbugs.gnu.org; Mon, 26 Oct 2020 12:02:02 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:44810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX4wa-0001z0-9X for 44188@debbugs.gnu.org; Mon, 26 Oct 2020 12:02:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2rCWU3SLaduBJGEmxr0a+2KLeLxW+8J5bEWnOiyGFlk=; b=FlivlKZik3D/lVQ5OM/nhJTkBG fMA0V5/qZ9zkS5O0vbjQVCDay6c3eEZSpO9wlisJ09+264suHhsXrRGoWN/JgbIJxSgg3Z/9feOvH ivDu3saMxyeLNThcvA4m64xud8KbF8SDAH9ja72yh/t/ZVpDHxLekjNegGkPpPvoh1Uo=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX4wM-0002cA-CO; Mon, 26 Oct 2020 17:01:53 +0100 X-Now-Playing: White Hole's _Pink Album_: "Piano Again" In-Reply-To: <930162507.128721.1603495416517@ichabod.co-bxl> (Brian Leung's message of "Sat, 24 Oct 2020 01:23:36 +0200 (CEST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191597 Archived-At: Brian Leung writes: > I enforced lexical binding in a few other files. Thanks, but I'm slightly worried whether these have been tested? There's sometimes subtle problems with converting to lexical binding that's not obvious from just compiling the files, but is only revealed by actually using the functions. So when converting to lexical binding, we try to (where it makes sense) to add some unit tests to test/lisp/-tests.el at the same time to give us greater confidence that the mechanisms still work. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no