unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Felician Nemeth <felician.nemeth@gmail.com>
To: Sebastian Poeplau <sebastian.poeplau@mailbox.org>
Cc: 69657@debbugs.gnu.org, "João Távora" <joaotavora@gmail.com>
Subject: bug#69657: Missing imenu entries with eglot
Date: Sat, 09 Mar 2024 17:20:12 +0100	[thread overview]
Message-ID: <87v85v1io3.fsf@betli.tmit.bme.hu> (raw)
In-Reply-To: <87bk7oz6vc.fsf@mailbox.org> (Sebastian Poeplau's message of "Fri, 08 Mar 2024 23:28:26 +0100")

CC-ing João, the maintainer of breadcrumb-mode.

> I did M-x imenu, although I should add that I normally use
> consult-imenu, which presents a flattened menu. That's also what I wrote
> the patch for.

Without the patch, I can jump to "bar" (M-x imenu RET Foo RET bar RET)
and cannot jump to "Foo".  With the patch, I can jump to "Foo" (M-x
imenu RET Foo RET) and cannot jump to "bar".

So the default / basic behavior has changed, but I don't think it is a
definit improvement.

>> On the other hand, the patch seems to ruin breadcrumb-mode: putting
>> the point after "{}", the breadcrumb header line shows: "dir/test.cpp:
>> Class > Foo" instead of the original "dir/test.cpp: Class > Foo >
>> bar".
>
> If you move point _after_ "{}", you're outside of method "bar", aren't
> you? Doesn't that mean the breadcrumb header is correct now and was
> wrong before?

This is the first time I use breadcrumb, so I don't really know what is
the exact correct behaviour.  But without the patch there are locations
for with "bar" is present it the breadcrumb header, and with the patch
there isn't any.

Maybe this is a bug in breadcrumb, but applying the current version of
the patch is going to ruin an existing feature.

Additionally, with the patch, the *Completions* buffer shows: "3
possible completions: *Rescan* Foo".  So maybe there is a bug in imenu
as well, since it seems it cannot handle items having the same name.

> for the record, this is the textDocument/documentSymbol response I'm
> getting for the example in my original message:  [...]

This is what I get as well, so luckily the different clangd versions
don't cause problems.

----

By the way, I haven't used consult before, but after a quick look at it,
I think consult-imenu could use the breadcrumb-kind text properties to
show additional information in its live preview mode.





  reply	other threads:[~2024-03-09 16:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08 20:01 bug#69657: Missing imenu entries with eglot Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-08 21:44 ` Felician Nemeth
2024-03-08 22:28   ` Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-09 16:20     ` Felician Nemeth [this message]
2024-03-10  1:05       ` João Távora
2024-03-10 16:15         ` Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-10 19:15           ` Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-10 19:33             ` João Távora
2024-03-17 11:04               ` Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v85v1io3.fsf@betli.tmit.bme.hu \
    --to=felician.nemeth@gmail.com \
    --cc=69657@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=sebastian.poeplau@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).