From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#69657: Missing imenu entries with eglot Date: Sat, 09 Mar 2024 17:20:12 +0100 Message-ID: <87v85v1io3.fsf@betli.tmit.bme.hu> References: <87frx0ze5n.fsf@mailbox.org> <87a5n8s8jw.fsf@betli.tmit.bme.hu> <87bk7oz6vc.fsf@mailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23845"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: 69657@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Sebastian Poeplau Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 09 17:21:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rizSM-00063H-Na for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Mar 2024 17:21:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rizRz-0000bH-RR; Sat, 09 Mar 2024 11:21:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rizRx-0000b3-PR for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 11:21:30 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rizRx-0007kc-HF for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 11:21:29 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rizST-0002x0-Ut for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 11:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Mar 2024 16:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69657 X-GNU-PR-Package: emacs Original-Received: via spool by 69657-submit@debbugs.gnu.org id=B69657.171000131611330 (code B ref 69657); Sat, 09 Mar 2024 16:22:01 +0000 Original-Received: (at 69657) by debbugs.gnu.org; 9 Mar 2024 16:21:56 +0000 Original-Received: from localhost ([127.0.0.1]:34687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rizSN-0002wf-IZ for submit@debbugs.gnu.org; Sat, 09 Mar 2024 11:21:55 -0500 Original-Received: from mail-ej1-f44.google.com ([209.85.218.44]:46191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rizSK-0002wS-V9 for 69657@debbugs.gnu.org; Sat, 09 Mar 2024 11:21:53 -0500 Original-Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a45bdf6e9c2so363736066b.0 for <69657@debbugs.gnu.org>; Sat, 09 Mar 2024 08:21:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710001214; x=1710606014; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Kgzsvs8jhrLTiQFKFIHZoTw+5YxMWjSF4qDtsfUOBq8=; b=CxPWI6ASpx/ST1ZMqZ0T21x2Zbh25wY8sdng9SUQWewcNeZ8wDbxWeaVQCsYpQmrRX PSkpi6H+YR7u0oQ1HMeCfpLD2Uq3PNnOt61peAdxwJ/B23kPFDdEwEraOe7rM1W0YN5T mJn0UwoQPwWI1r3VIGSqclsZ2XT9i51m2vvxTZNPoG9qCbUWgs8un0Lw1eqa8WY9mKYf ySN63NG73xxcTsggFyJQ20tdwZY6D2w4rLU7Wm5aP0fZC+z2usglKAbZGM/djGg8VxxF Of/3Yi9jK/+H0CSQfFylMAqrc6agOinHMmX+2d3X2zmJ/HZtwcOe+cg9pUFKi2FjxwoB j++Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710001214; x=1710606014; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Kgzsvs8jhrLTiQFKFIHZoTw+5YxMWjSF4qDtsfUOBq8=; b=FTgtPppl7XLWmc6bPaBmW0z1xeyrUUYHyH7GMutwHaWMz+NWmcT2dJNED7l9tSWH+3 DicUonbBypNvsmAckzozDyOStoDfhQ/tgz8HIJHs35K88/DnpQ7tltWVbsnvfWcYwRSJ BMUGAcTrjIN88DL4p9MQKR7tpslmKmjxQvFM/SkbYv1a30uZejEttxUumjSJZE73ZnYx 0ji2R0TgdNhucsx5j4yH7ravSgbCH6jLHp/3IYiPxb3q2Pip9dwzQgVt1QX9+MJnCfkF cpEar7+wiCV44LMY4IrtfNXgnLnp7wtsFFBC/PJpb4IgX3aUvZEZCkJ4FuHP4kni6YfY 0HhQ== X-Gm-Message-State: AOJu0YxJA4DrGWwiUIV60RB5nJzYxJwb0nI3RlDWCzY/M+wPHSkYSnRi cMP3L/2o+GJDs9GeeDNAfYd9uawua1hGlDm6c3vhitrYs45e2CrY X-Google-Smtp-Source: AGHT+IHfGzEwPvDzBou3WzTGXeQVbvL1QFVtqprlcL51pDaNVBXrNb0PgZroaF6oC4S7EeLsPkIoZQ== X-Received: by 2002:a17:906:f215:b0:a45:b1cf:42f6 with SMTP id gt21-20020a170906f21500b00a45b1cf42f6mr1230587ejb.9.1710001214041; Sat, 09 Mar 2024 08:20:14 -0800 (PST) Original-Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id j20-20020a170906411400b00a45c18345e0sm1028451ejk.163.2024.03.09.08.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Mar 2024 08:20:13 -0800 (PST) In-Reply-To: <87bk7oz6vc.fsf@mailbox.org> (Sebastian Poeplau's message of "Fri, 08 Mar 2024 23:28:26 +0100") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUMBwgHAgMFAAGPjY7/ //80MDHq6eqJt3pKAAABr0lEQVQ4jX2UzZKDIAzHqR177q7TPbtx2HMr6guQcrbY9txZ0fd/hA0f onXazcEJ/CD8E4Js8/HS9mwjXtqeMRxHXJkakTEm4b4GPVQW8PU8ov4fQCqeThlF60MBWdo1IXzd 2nEEZE7CEAZLwI0N/gJAhTj7ESQAX4gPgO8lyI+cvgViSVPlNomAj2M9gW40eg7VWY3cATjUcyiO Z+i03cFruGLYoUR7VyU3HihdmCEVhoDN65FXkpbSxkomOzsTQN/gySaodGb9Gdi1oSRXP46gdBWh LcUKJNdeGCWac74GKakmne0aHCFvyqJPYLsCFAVlhRTvGdzMdLHqtgRyUulyXIAH7CYQ3AB0Nody JQhAkq/qtOnbjhxdzYDkXPxlH5y4WdUAeUcX1NVJ6GR7UQEYPGWoAnA36OQNn5lRRp38vHTAp9Br LoTmvlPPDoRCKzpjG1SXT89AaT5l456BamJuMcs+NIOMzJ/s5dI6yUVcrARlruwOebfdv6gunTn4 ww3+QjGBEn5suVyLHoSGvAqREuDLN+iqZ+VcFg+HBbsJUU9+FZthbez9T+bdb+kPv2Ls6ct3hTkA AAAASUVORK5CYII= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281345 Archived-At: CC-ing Jo=C3=A3o, the maintainer of breadcrumb-mode. > I did M-x imenu, although I should add that I normally use > consult-imenu, which presents a flattened menu. That's also what I wrote > the patch for. Without the patch, I can jump to "bar" (M-x imenu RET Foo RET bar RET) and cannot jump to "Foo". With the patch, I can jump to "Foo" (M-x imenu RET Foo RET) and cannot jump to "bar". So the default / basic behavior has changed, but I don't think it is a definit improvement. >> On the other hand, the patch seems to ruin breadcrumb-mode: putting >> the point after "{}", the breadcrumb header line shows: "dir/test.cpp: >> Class > Foo" instead of the original "dir/test.cpp: Class > Foo > >> bar". > > If you move point _after_ "{}", you're outside of method "bar", aren't > you? Doesn't that mean the breadcrumb header is correct now and was > wrong before? This is the first time I use breadcrumb, so I don't really know what is the exact correct behaviour. But without the patch there are locations for with "bar" is present it the breadcrumb header, and with the patch there isn't any. Maybe this is a bug in breadcrumb, but applying the current version of the patch is going to ruin an existing feature. Additionally, with the patch, the *Completions* buffer shows: "3 possible completions: *Rescan* Foo". So maybe there is a bug in imenu as well, since it seems it cannot handle items having the same name. > for the record, this is the textDocument/documentSymbol response I'm > getting for the example in my original message: [...] This is what I get as well, so luckily the different clangd versions don't cause problems. ---- By the way, I haven't used consult before, but after a quick look at it, I think consult-imenu could use the breadcrumb-kind text properties to show additional information in its live preview mode.