From: "João Távora" <joaotavora@gmail.com>
To: Sebastian Poeplau <sebastian.poeplau@mailbox.org>
Cc: 69657@debbugs.gnu.org, Felician Nemeth <felician.nemeth@gmail.com>
Subject: bug#69657: Missing imenu entries with eglot
Date: Sun, 10 Mar 2024 19:33:58 +0000 [thread overview]
Message-ID: <CALDnm52aPqDmNGEbgbyxTGdRDtJpc9pzfRS9LNEKuO1kqyDiqw@mail.gmail.com> (raw)
In-Reply-To: <87frwxuc1w.fsf@mailbox.org>
On Sun, Mar 10, 2024 at 7:22 PM Sebastian Poeplau
<sebastian.poeplau@mailbox.org> wrote:
> Here's the return value of eglot-imenu with pylsp:
>
> ((#1="Class"
> (#("Foo" 0 3 (breadcrumb-kind #1# breadcrumb-region (1 . 44))) . 1))
> (#2="Method"
> ("Foo" (#("bar" 0 3 (breadcrumb-kind #2# breadcrumb-region (16 . 44))) . 16))))
> For completeness, this is pylsp's response to
> textDocument/documentSymbol:
See https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_documentSymbol
pylsp does this because it is old, it uses SymbolInformation.
clangd and most other servers use DocumentSymbol[] which is not
only much more powerful and logical for represting a file's AST but
also doesn't lend itself well to that structure of categorization, which
is rather useless except for the fact that it makes leaves out of AST
non-leaves.
The problems are in Imenu.
You should rather lobby for a better imenu structure (which will be
hard to do fully backward compatibly will all existing UIs -- except if
you use the string properties trick that Eglot/breadcrumb use as
I explained) You could also lobby for a brand new imenu replacement
in Emacs.
João
next prev parent reply other threads:[~2024-03-10 19:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 20:01 bug#69657: Missing imenu entries with eglot Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-08 21:44 ` Felician Nemeth
2024-03-08 22:28 ` Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-09 16:20 ` Felician Nemeth
2024-03-10 1:05 ` João Távora
2024-03-10 16:15 ` Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-10 19:15 ` Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-10 19:33 ` João Távora [this message]
2024-03-17 11:04 ` Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm52aPqDmNGEbgbyxTGdRDtJpc9pzfRS9LNEKuO1kqyDiqw@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=69657@debbugs.gnu.org \
--cc=felician.nemeth@gmail.com \
--cc=sebastian.poeplau@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).