unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Sebastian Poeplau via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: 69657@debbugs.gnu.org, Felician Nemeth <felician.nemeth@gmail.com>
Subject: bug#69657: Missing imenu entries with eglot
Date: Sun, 10 Mar 2024 17:15:49 +0100	[thread overview]
Message-ID: <87jzmat5qe.fsf@mailbox.org> (raw)
In-Reply-To: <CALDnm53uLT7Hq_1NEyyXiBQTgrf=F81Jp9Ebd=xvhNOqUCkAqA@mail.gmail.com>

> I understand Sebastian wants to see an extra top-evel ("Foo" . 1) there
> or something, but that leads to two entries with duplicate names and imenu
> just doesn't like that (if I apply the patch I just can't go to 'bar' with M
> -x imenu), neither do some of its clients.

What about naming the separate entry differently, e.g., "Foo (top)"?
I'll certainly look into using the breadcrumb metadata instead, but that
doesn't help users of plain imenu.

> This is way Eglot emits "breadcrumb"-friendly cookies to overcome imenu's
> limitations.   Using breadcrumb i can jump to Foo and Foo > bar just
> fine (using
> `M-x breadcrumb-jump`).

Thanks for the hint, I didn't know about `breadcrumb-jump'; I'd only
used the headline feature before.

> Anyway, if users don't like Eglot's imenu function, they can use something
> else.  Eglot's imenu is different from c++-ts-mode, and afaik c++-ts-mode's is
> already different from c++-mode's.  I wouldn't install this patch though,
> teach other UIs about those optional cookies seems like a better deal that
> doesn't break stuff.

I wonder why I did get separate entries in consult-imenu with pylsp
though. I'll have to give it another look, but it seems to me that in
this case (e.g., with SymbolInformation objects) eglot's imenu function
returns data that (a) works with plain imenu and (b) gives me what I
expect with consult-imenu.





  reply	other threads:[~2024-03-10 16:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08 20:01 bug#69657: Missing imenu entries with eglot Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-08 21:44 ` Felician Nemeth
2024-03-08 22:28   ` Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-09 16:20     ` Felician Nemeth
2024-03-10  1:05       ` João Távora
2024-03-10 16:15         ` Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-03-10 19:15           ` Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-10 19:33             ` João Távora
2024-03-17 11:04               ` Sebastian Poeplau via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzmat5qe.fsf@mailbox.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=69657@debbugs.gnu.org \
    --cc=felician.nemeth@gmail.com \
    --cc=joaotavora@gmail.com \
    --cc=sebastian.poeplau@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).