From: Lars Ingebrigtsen <larsi@gnus.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 41130@debbugs.gnu.org, Stefan Kangas <stefan@marxist.se>,
41198@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline
Date: Sat, 17 Oct 2020 08:36:47 +0200 [thread overview]
Message-ID: <87sgadz7cw.fsf@gnus.org> (raw)
In-Reply-To: <D701384F-49DB-483E-80CA-FAB93001B6E0@gmail.com> (Yuan Fu's message of "Fri, 16 Oct 2020 15:27:33 -0400")
Yuan Fu <casouri@gmail.com> writes:
> This patch should make outline behaves like org: S-TAB always cycle
> the whole buffer, regardless where is the point. TAB cycles a heading,
> and does nothing if point is before the first heading.
I think the behaviour makes sense, but the implementation isn't ideal:
[...]
> + (condition-case nil
> + (pcase (outline--cycle-state)
> + ('hide-all
> + (if (outline-has-subheading-p)
> + (progn (outline-show-children)
> + (message "Only headings"))
> + (outline-show-subtree)
> + (message "Show all")))
> + ('headings-only
> + (outline-show-subtree)
> + (message "Show all"))
> + ('show-all
> + (outline-hide-subtree)
> + (message "Hide all")))
> + ;; If error: "Before first heading" occurs, ignore it.
> + (error nil)))
This is basically an `ignore-errors' around a whole bunch of code, used
as a program flow mechanism, and that's always awkward, because it hides
real errors in the code.
Altering the functions to not error out in these situations would be
better.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-10-17 6:36 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 1:52 bug#41198: 27.0.60; [PATCH] heading cycling command for outline Yuan Fu
2020-05-19 2:45 ` bug#41130: " Stefan Kangas
2020-05-19 18:31 ` Yuan Fu
2020-05-19 22:36 ` Stefan Kangas
2020-05-20 1:37 ` Yuan Fu
2020-05-07 20:53 ` bug#41130: outline-mode: Add new commands like org-cycle and org=global-cycle Stefan Kangas
2020-05-07 21:03 ` Stefan Kangas
2020-05-12 22:52 ` Juri Linkov
2020-05-19 3:00 ` bug#41130: outline-mode: Add new commands like org-cycle and org-global-cycle Stefan Kangas
2020-05-19 22:04 ` Juri Linkov
2020-05-24 7:29 ` Bastien
2020-05-24 14:35 ` Eli Zaretskii
2020-05-24 16:26 ` Bastien
2020-05-24 16:39 ` Eli Zaretskii
2020-05-24 17:09 ` Dmitry Gutov
2020-05-25 8:50 ` Bastien
2020-06-23 22:27 ` Basil L. Contovounesios
2020-09-06 8:22 ` Bastien
2020-05-13 7:13 ` bug#41130: outline-mode: Add new commands like org-cycle and org=global-cycle Tassilo Horn
2020-05-13 16:54 ` Robert Pluim
2020-05-13 18:51 ` Tassilo Horn
2020-05-19 3:06 ` Stefan Kangas
2020-05-20 14:12 ` bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Howard Melman
2020-05-20 21:34 ` Stefan Kangas
2020-05-24 7:26 ` bug#41130: outline-mode: Add new commands like org-cycle and org=global-cycle Bastien
2020-05-24 14:49 ` Philip K.
2020-05-24 16:30 ` Bastien
2020-08-17 22:30 ` bug#41130: outline-mode: Add new commands like org-cycle and org-global-cycle Howard Melman
2020-08-18 4:30 ` Eli Zaretskii
2020-10-13 3:16 ` bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Lars Ingebrigtsen
2020-10-13 13:16 ` bug#41198: " Yuan Fu
2020-10-14 19:24 ` Juri Linkov
2020-10-15 7:02 ` Lars Ingebrigtsen
2020-10-15 7:52 ` Robert Pluim
2020-10-15 23:33 ` bug#41198: " Yuan Fu
2020-10-16 3:12 ` Yuan Fu
2020-10-16 4:59 ` bug#41198: " Lars Ingebrigtsen
2020-10-16 8:25 ` bug#41130: " Robert Pluim
2020-10-16 8:20 ` Juri Linkov
2020-10-16 19:27 ` Yuan Fu
2020-10-17 6:36 ` Lars Ingebrigtsen [this message]
2020-10-17 20:30 ` Juri Linkov
2020-10-18 0:28 ` bug#41198: " Yuan Fu
2020-10-18 8:36 ` Lars Ingebrigtsen
2020-10-18 20:23 ` Yuan Fu
2020-10-19 8:45 ` Lars Ingebrigtsen
2020-11-15 5:50 ` bug#41198: 28.0.50; " Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-16 21:59 ` Lars Ingebrigtsen
2020-11-17 2:47 ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-24 5:09 ` Lars Ingebrigtsen
2020-11-25 19:24 ` Juri Linkov
2020-11-26 10:13 ` Lars Ingebrigtsen
2020-11-27 8:29 ` Juri Linkov
2020-11-27 18:39 ` Drew Adams
2020-11-28 1:58 ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-10 19:08 ` Howard Melman
2020-12-12 20:57 ` Juri Linkov
2020-12-14 20:31 ` Juri Linkov
2020-12-15 0:09 ` Howard Melman
2020-12-15 3:46 ` Pankaj Jangid
2020-12-15 9:10 ` Juri Linkov
2020-12-15 10:42 ` Pankaj Jangid
2020-12-15 20:23 ` Juri Linkov
2020-12-16 4:02 ` Pankaj Jangid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgadz7cw.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=41130@debbugs.gnu.org \
--cc=41198@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=juri@linkov.net \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).