From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Date: Sat, 17 Oct 2020 08:36:47 +0200 Message-ID: <87sgadz7cw.fsf@gnus.org> References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> <92D944EF-6BF9-4635-AC05-4B51B386D5C7@gmail.com> <878sca7r43.fsf@gnus.org> <87mu0ozntx.fsf@mail.linkov.net> <87v9fatwdi.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4794"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41130@debbugs.gnu.org, Stefan Kangas , 41198@debbugs.gnu.org, Juri Linkov To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 17 08:37:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTfq9-0001Al-HW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Oct 2020 08:37:17 +0200 Original-Received: from localhost ([::1]:40468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTfq8-00088X-Dk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Oct 2020 02:37:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTfpu-00088D-LQ for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2020 02:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49784) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTfpu-0008Ip-C8 for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2020 02:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kTfpu-0003tN-7J for bug-gnu-emacs@gnu.org; Sat, 17 Oct 2020 02:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Oct 2020 06:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41130-submit@debbugs.gnu.org id=B41130.160291662014953 (code B ref 41130); Sat, 17 Oct 2020 06:37:02 +0000 Original-Received: (at 41130) by debbugs.gnu.org; 17 Oct 2020 06:37:00 +0000 Original-Received: from localhost ([127.0.0.1]:33097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTfps-0003t2-Hw for submit@debbugs.gnu.org; Sat, 17 Oct 2020 02:37:00 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:36020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTfpq-0003sj-LD; Sat, 17 Oct 2020 02:36:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0J/HyxX8smqgkM3kFAKR84eh1QELEG2YOjTvM6YVcUg=; b=JCqhAELu84l2GuAUTIyOxyjngA 5GVe7tFHHZ5x1OPAN6NxBcxf+zD+Egb6HKYNLuf7fOH+0iwuK71oP5DZqJhszuFec54jaNe3LNcqD SVBQhAYhimBcVzhPp5/ef0Lb6kTLtGASkAboq5va0ZxYTLoy/s50372lfqBrTXSn1oGM=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTfpg-000051-NT; Sat, 17 Oct 2020 08:36:51 +0200 X-Now-Playing: Various's _1-8 Split Series_: "Foehn - Shrouded" In-Reply-To: (Yuan Fu's message of "Fri, 16 Oct 2020 15:27:33 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190753 Archived-At: Yuan Fu writes: > This patch should make outline behaves like org: S-TAB always cycle > the whole buffer, regardless where is the point. TAB cycles a heading, > and does nothing if point is before the first heading. I think the behaviour makes sense, but the implementation isn't ideal: [...] > + (condition-case nil > + (pcase (outline--cycle-state) > + ('hide-all > + (if (outline-has-subheading-p) > + (progn (outline-show-children) > + (message "Only headings")) > + (outline-show-subtree) > + (message "Show all"))) > + ('headings-only > + (outline-show-subtree) > + (message "Show all")) > + ('show-all > + (outline-hide-subtree) > + (message "Hide all"))) > + ;; If error: "Before first heading" occurs, ignore it. > + (error nil))) This is basically an `ignore-errors' around a whole bunch of code, used as a program flow mechanism, and that's always awkward, because it hides real errors in the code. Altering the functions to not error out in these situations would be better. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no