unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Yuan Fu <casouri@gmail.com>
Cc: 41130@debbugs.gnu.org, 41198@debbugs.gnu.org
Subject: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline
Date: Mon, 18 May 2020 19:45:10 -0700	[thread overview]
Message-ID: <CADwFkmniRyc9c0k7=AZ9T9ZjGQzHLK_hZr37EZqP21xfUrVQ-A@mail.gmail.com> (raw)
In-Reply-To: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> (Yuan Fu's message of "Mon, 11 May 2020 21:52:25 -0400")

forcemerge 41130 41198
thanks

Yuan Fu <casouri@gmail.com> writes:

> Add two commands that cycles a heading (like that in Org mode) in outline-mode:
>
> - outline-cycle: cycles between “hide all”, “sub headings” and “show all” state. They are called “FOLDED”, “CHILDREN”, “SUBTREE” in Org mode.
> - outline-cycle-buffer: cycles between “only top level headings”, “all headings”, “show all” states

Thanks for working on this.  I've tested your patch, and it seems to
work as advertised.

> Could this be useful?

I think it could.  I have previously sent the wishlist Bug#41130, which
I have now merged with this bug.  I have seen no objections to that
proposal, so I hope that it is uncontroversial.

In Bug#41130, I also suggest to add the same keybinding as in org-mode:
TAB and S-TAB.  Could you add such keybindings to outline-mode-map in
your patch?

I think we also need ChangeLog in the commit message, an entry in NEWS,
and updates to the manual.

> +(defun outline-cycle ()
> +  "Cycle between “hide all”, “headings only” and “show all”.
> +
> +“Hide all” means hide all subheadings and their bodies.
> +“Headings only” means show sub headings but not their bodies.
> +“Show all” means show all subheadings and their bodies."

I can't remember seeing double quotes used like that before in doc
strings.  Correct me if I'm wrong, but wouldn't we normally use
`single-quotes' for something like this?

Best regards,
Stefan Kangas





  reply	other threads:[~2020-05-19  2:45 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12  1:52 bug#41198: 27.0.60; [PATCH] heading cycling command for outline Yuan Fu
2020-05-19  2:45 ` Stefan Kangas [this message]
2020-05-19 18:31   ` bug#41130: " Yuan Fu
2020-05-19 22:36     ` Stefan Kangas
2020-05-20  1:37       ` Yuan Fu
2020-05-07 20:53         ` bug#41130: outline-mode: Add new commands like org-cycle and org=global-cycle Stefan Kangas
2020-05-07 21:03           ` Stefan Kangas
2020-05-12 22:52           ` Juri Linkov
2020-05-19  3:00             ` bug#41130: outline-mode: Add new commands like org-cycle and org-global-cycle Stefan Kangas
2020-05-19 22:04               ` Juri Linkov
2020-05-24  7:29                 ` Bastien
2020-05-24 14:35                   ` Eli Zaretskii
2020-05-24 16:26                     ` Bastien
2020-05-24 16:39                       ` Eli Zaretskii
2020-05-24 17:09                         ` Dmitry Gutov
2020-05-25  8:50                           ` Bastien
2020-06-23 22:27                             ` Basil L. Contovounesios
2020-09-06  8:22                               ` Bastien
2020-05-13  7:13           ` bug#41130: outline-mode: Add new commands like org-cycle and org=global-cycle Tassilo Horn
2020-05-13 16:54             ` Robert Pluim
2020-05-13 18:51               ` Tassilo Horn
2020-05-19  3:06             ` Stefan Kangas
2020-05-20 14:12           ` bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Howard Melman
2020-05-20 21:34             ` Stefan Kangas
2020-05-24  7:26           ` bug#41130: outline-mode: Add new commands like org-cycle and org=global-cycle Bastien
2020-05-24 14:49             ` Philip K.
2020-05-24 16:30               ` Bastien
2020-08-17 22:30           ` bug#41130: outline-mode: Add new commands like org-cycle and org-global-cycle Howard Melman
2020-08-18  4:30             ` Eli Zaretskii
2020-10-13  3:16         ` bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Lars Ingebrigtsen
2020-10-13 13:16           ` bug#41198: " Yuan Fu
2020-10-14 19:24           ` Juri Linkov
2020-10-15  7:02             ` Lars Ingebrigtsen
2020-10-15  7:52               ` Robert Pluim
2020-10-15 23:33             ` bug#41198: " Yuan Fu
2020-10-16  3:12               ` Yuan Fu
2020-10-16  4:59               ` bug#41198: " Lars Ingebrigtsen
2020-10-16  8:25                 ` bug#41130: " Robert Pluim
2020-10-16  8:20               ` Juri Linkov
2020-10-16 19:27                 ` Yuan Fu
2020-10-17  6:36                   ` Lars Ingebrigtsen
2020-10-17 20:30                     ` Juri Linkov
2020-10-18  0:28                       ` bug#41198: " Yuan Fu
2020-10-18  8:36                         ` Lars Ingebrigtsen
2020-10-18 20:23                           ` Yuan Fu
2020-10-19  8:45                             ` Lars Ingebrigtsen
2020-11-15  5:50 ` bug#41198: 28.0.50; " Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-16 21:59   ` Lars Ingebrigtsen
2020-11-17  2:47     ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-24  5:09       ` Lars Ingebrigtsen
2020-11-25 19:24         ` Juri Linkov
2020-11-26 10:13           ` Lars Ingebrigtsen
2020-11-27  8:29             ` Juri Linkov
2020-11-27 18:39               ` Drew Adams
2020-11-28  1:58               ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-10 19:08                 ` Howard Melman
2020-12-12 20:57                   ` Juri Linkov
2020-12-14 20:31                   ` Juri Linkov
2020-12-15  0:09                     ` Howard Melman
2020-12-15  3:46                     ` Pankaj Jangid
2020-12-15  9:10                       ` Juri Linkov
2020-12-15 10:42                         ` Pankaj Jangid
2020-12-15 20:23                           ` Juri Linkov
2020-12-16  4:02                             ` Pankaj Jangid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmniRyc9c0k7=AZ9T9ZjGQzHLK_hZr37EZqP21xfUrVQ-A@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=41130@debbugs.gnu.org \
    --cc=41198@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).