From: Stefan Kangas <stefankangas@gmail.com>
To: Tassilo Horn <tsdh@gnu.org>
Cc: 41130@debbugs.gnu.org
Subject: bug#41130: outline-mode: Add new commands like org-cycle and org=global-cycle
Date: Mon, 18 May 2020 20:06:00 -0700 [thread overview]
Message-ID: <CADwFkmkAv_tEeLCCG-WUPs7csU8ovLa3ek52Uaphs3Eqxw8Xyg@mail.gmail.com> (raw)
In-Reply-To: <87wo5gxq7p.fsf@gnu.org>
Tassilo Horn <tsdh@gnu.org> writes:
> I'm also very much in favor of this. I think probably every user has
> his own incarnation of such a command.
I wish I was one of these users. ;-)
> Well, I think those shouldn't be commands in outline-minor-mode-map as
> they should only be active when point is on an outline heading, no? At
> least that's the case with org-mode where TAB acts quite differently
> depending on the context.
This is a good point, yes.
> --8<---------------cut here---------------start------------->8---
> (defmacro th/define-context-key (keymap key dispatch)
> "Define KEY in KEYMAP to execute according to DISPATCH.
>
> DISPATCH is a form that is evaluated and should return the
> command to be executed.
>
> If DISPATCH returns nil, then the command normally bound to KEY
> will be executed.
>
> Example:
>
> (th/define-context-key hs-minor-mode-map
> (kbd \"<C-tab>\")
> (cond
> ((not (hs-already-hidden-p))
> 'hs-hide-block)
> ((hs-already-hidden-p)
> 'hs-show-block)))
>
> This will make <C-tab> show a hidden block. If the block is
> shown, then it'll be hidden."
> (declare (indent 2))
> `(define-key ,keymap ,key
> `(menu-item "context-key" ignore
> :filter ,(lambda (&optional ignored)
> ,dispatch))))
>
> (th/define-context-key outline-minor-mode-map (kbd "<tab>")
> (when (save-excursion
> (move-beginning-of-line 1)
> (looking-at-p outline-regexp))
> 'outline-toggle-children))
> --8<---------------cut here---------------end--------------->8---
Interesting. I suppose the only question I have is this: how do we turn
this into something we could add to Emacs?
There is also the question of C-TAB conflicting with tab-bar-mode.
> PS: On a related note, I think there should be some standard facility
> for defining keys depending on the context. If Stefan hadn't shown me
> the menu-item-with-:filter trick some years ago, I would probably not
> found out myself.
Agreed. I had not seen that before, until now.
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2020-05-19 3:06 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 1:52 bug#41198: 27.0.60; [PATCH] heading cycling command for outline Yuan Fu
2020-05-19 2:45 ` bug#41130: " Stefan Kangas
2020-05-19 18:31 ` Yuan Fu
2020-05-19 22:36 ` Stefan Kangas
2020-05-20 1:37 ` Yuan Fu
2020-05-07 20:53 ` bug#41130: outline-mode: Add new commands like org-cycle and org=global-cycle Stefan Kangas
2020-05-07 21:03 ` Stefan Kangas
2020-05-12 22:52 ` Juri Linkov
2020-05-19 3:00 ` bug#41130: outline-mode: Add new commands like org-cycle and org-global-cycle Stefan Kangas
2020-05-19 22:04 ` Juri Linkov
2020-05-24 7:29 ` Bastien
2020-05-24 14:35 ` Eli Zaretskii
2020-05-24 16:26 ` Bastien
2020-05-24 16:39 ` Eli Zaretskii
2020-05-24 17:09 ` Dmitry Gutov
2020-05-25 8:50 ` Bastien
2020-06-23 22:27 ` Basil L. Contovounesios
2020-09-06 8:22 ` Bastien
2020-05-13 7:13 ` bug#41130: outline-mode: Add new commands like org-cycle and org=global-cycle Tassilo Horn
2020-05-13 16:54 ` Robert Pluim
2020-05-13 18:51 ` Tassilo Horn
2020-05-19 3:06 ` Stefan Kangas [this message]
2020-05-20 14:12 ` bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Howard Melman
2020-05-20 21:34 ` Stefan Kangas
2020-05-24 7:26 ` bug#41130: outline-mode: Add new commands like org-cycle and org=global-cycle Bastien
2020-05-24 14:49 ` Philip K.
2020-05-24 16:30 ` Bastien
2020-08-17 22:30 ` bug#41130: outline-mode: Add new commands like org-cycle and org-global-cycle Howard Melman
2020-08-18 4:30 ` Eli Zaretskii
2020-10-13 3:16 ` bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Lars Ingebrigtsen
2020-10-13 13:16 ` bug#41198: " Yuan Fu
2020-10-14 19:24 ` Juri Linkov
2020-10-15 7:02 ` Lars Ingebrigtsen
2020-10-15 7:52 ` Robert Pluim
2020-10-15 23:33 ` bug#41198: " Yuan Fu
2020-10-16 3:12 ` Yuan Fu
2020-10-16 4:59 ` bug#41198: " Lars Ingebrigtsen
2020-10-16 8:25 ` bug#41130: " Robert Pluim
2020-10-16 8:20 ` Juri Linkov
2020-10-16 19:27 ` Yuan Fu
2020-10-17 6:36 ` Lars Ingebrigtsen
2020-10-17 20:30 ` Juri Linkov
2020-10-18 0:28 ` bug#41198: " Yuan Fu
2020-10-18 8:36 ` Lars Ingebrigtsen
2020-10-18 20:23 ` Yuan Fu
2020-10-19 8:45 ` Lars Ingebrigtsen
2020-11-15 5:50 ` bug#41198: 28.0.50; " Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-16 21:59 ` Lars Ingebrigtsen
2020-11-17 2:47 ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-24 5:09 ` Lars Ingebrigtsen
2020-11-25 19:24 ` Juri Linkov
2020-11-26 10:13 ` Lars Ingebrigtsen
2020-11-27 8:29 ` Juri Linkov
2020-11-27 18:39 ` Drew Adams
2020-11-28 1:58 ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-10 19:08 ` Howard Melman
2020-12-12 20:57 ` Juri Linkov
2020-12-14 20:31 ` Juri Linkov
2020-12-15 0:09 ` Howard Melman
2020-12-15 3:46 ` Pankaj Jangid
2020-12-15 9:10 ` Juri Linkov
2020-12-15 10:42 ` Pankaj Jangid
2020-12-15 20:23 ` Juri Linkov
2020-12-16 4:02 ` Pankaj Jangid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmkAv_tEeLCCG-WUPs7csU8ovLa3ek52Uaphs3Eqxw8Xyg@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=41130@debbugs.gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).