unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: No Wayman <iarchivedmywholelife@gmail.com>
To: 64452@debbugs.gnu.org
Subject: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log*
Date: Mon, 03 Jul 2023 20:13:23 -0400	[thread overview]
Message-ID: <87sfa44ixh.fsf@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]


Unless there is good reason not to use special-mode, it'd be nice 
to have the typical special-mode bindings (quit-window especially) 
in these buffers.

Rough draft patch attached. 


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-comp.el-use-special-mode-for-log-buffers.patch --]
[-- Type: text/x-patch, Size: 2023 bytes --]

From d2aad9faf904bfd197e0dd30a178f1bf05821c0c Mon Sep 17 00:00:00 2001
From: Nicholas Vollmer <iarchivedmywholelife@gmail.com>
Date: Mon, 3 Jul 2023 20:23:00 -0400
Subject: [PATCH] * comp.el: use special-mode for log buffers

(comp-log-to-buffer): ensure comp-log-buffer in special-mode
(comp-run-async-workers): ensure comp-async-buffer in special-mode
---
 lisp/emacs-lisp/comp.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 22fb08e4688..20aee2006fa 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -1133,7 +1133,7 @@ comp-log-to-buffer
          (log-buffer
              (or (get-buffer comp-log-buffer-name)
                  (with-current-buffer (get-buffer-create comp-log-buffer-name)
-                   (setf buffer-read-only t)
+                   (unless (derived-mode-p 'special-mode) (special-mode))
                    (current-buffer))))
          (log-window (get-buffer-window log-buffer))
          (inhibit-read-only t)
@@ -4085,7 +4085,8 @@ comp-run-async-workers
                              :buffer (with-current-buffer
                                          (get-buffer-create
                                           comp-async-buffer-name)
-                                       (setf buffer-read-only t)
+                                       (unless (derived-mode-p 'special-mode)
+                                         (special-mode))
 			               (current-buffer))
                              :command (list
                                        (expand-file-name invocation-name
@@ -4119,6 +4120,7 @@ comp-run-async-workers
     (run-hooks 'native-comp-async-all-done-hook)
     (with-current-buffer (get-buffer-create comp-async-buffer-name)
       (save-excursion
+        (unless (derived-mode-p 'special-mode) (special-mode))
         (let ((inhibit-read-only t))
           (goto-char (point-max))
           (insert "Compilation finished.\n"))))
-- 
2.41.0


             reply	other threads:[~2023-07-04  0:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04  0:13 No Wayman [this message]
2023-07-04 11:02 ` bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* Eli Zaretskii
2023-07-04 22:21   ` No Wayman
2023-07-05 11:25     ` Eli Zaretskii
2023-07-05 12:52       ` iarchivedmywholelife
2023-07-05 14:47       ` Andrea Corallo
2023-07-06  8:52         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfa44ixh.fsf@gmail.com \
    --to=iarchivedmywholelife@gmail.com \
    --cc=64452@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).