From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: No Wayman Newsgroups: gmane.emacs.bugs Subject: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* Date: Mon, 03 Jul 2023 20:13:23 -0400 Message-ID: <87sfa44ixh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6918"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.11.7; emacs 30.0.50 To: 64452@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 04 02:31:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGTwt-0001cj-2r for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Jul 2023 02:31:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGTwf-0000sI-5t; Mon, 03 Jul 2023 20:31:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGTwc-0000qP-Ts for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 20:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGTwc-0008LU-Kg for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 20:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qGTwc-0002l6-3D for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 20:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: No Wayman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jul 2023 00:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.168843063910566 (code B ref -1); Tue, 04 Jul 2023 00:31:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Jul 2023 00:30:39 +0000 Original-Received: from localhost ([127.0.0.1]:34705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGTwE-0002kL-W4 for submit@debbugs.gnu.org; Mon, 03 Jul 2023 20:30:39 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:49552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGTw8-0002k9-IQ for submit@debbugs.gnu.org; Mon, 03 Jul 2023 20:30:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGTw8-0000jA-A3 for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 20:30:32 -0400 Original-Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGTw6-00084W-It for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 20:30:32 -0400 Original-Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-7656652da3cso432391885a.1 for ; Mon, 03 Jul 2023 17:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688430628; x=1691022628; h=mime-version:message-id:date:subject:to:from:user-agent:from:to:cc :subject:date:message-id:reply-to; bh=4aDdlVz9Fj5FwRCzIcTda+n+vEI8ew1iK1yc3RJzEM0=; b=l22sMMbO7pmvTJ0U5KF+1Cs7Jwz59Pa07amEQn/9iwYFm0IO5j+jWK05wPoO5Uhyyv ihjdb9LNh424vq/bKYWSJZul8o83o8E4D11om/XTbAMszOOqjQci+CXX7K517cj1gY0b MCTciTIxghgXn+s5t+JqbyXuAfL7TEIP9s37RYANgeBmBfEduq5HGthl/gqaYcCR4tot pexqQFzSQagZEpK4D4lMGBMZpBoqKt7p+k22rdaly957+akFKiiV05BV2brJdNcmOaIj 2Nj2aeLZrfU3z45ItmqzWVKUo+/HDDEwHzolQFMTSSucTqnMj61tYYZgYBzGi+6AxpNA bOXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688430628; x=1691022628; h=mime-version:message-id:date:subject:to:from:user-agent :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4aDdlVz9Fj5FwRCzIcTda+n+vEI8ew1iK1yc3RJzEM0=; b=ZTNoa2ZxoXk7JfSzkItblKskfvg3R1nieXNo8BESap0j1SXPsHZ+26hOfT0xzIHhug VOEUECcnhxYWtHaglzactiHpMKVVBETPPq8aEqKENFqnf81OdV3ReEBp3501CtY9KHo4 zjp2rxAAtPm0qGXHIPNQ7MQagXLie0d6ZrFJ96kKheYqazSuPy51IfxrPSaSGA5m1FFm Iy6QCNGZDvUPKlYfYtQNRYC62inp8ICHRfj9D1qFXgPfR8/AIZOI4VgMmlT8JaF8ytHS HR6qBU0MWnugmUZYmStoBpquyRTZ2AhibTFImfEpaO/TrUJKWNsljnU3oEQgFp7bnGRY KtIw== X-Gm-Message-State: ABy/qLZi0bZiEq+qBCizImtghsGMcZrtfMs8iXdPIAZRCKbkWh6ic279 u74/Vjw3kzG1t0WAbYFjCYW5vLNC9FjMKA== X-Google-Smtp-Source: APBJJlGPZx7lEJyjlAd/pMRd1edUlhXjSer3B2Y2rPi/EixOxhImS/ojvofNt9ACYJySIf33JArksw== X-Received: by 2002:a05:620a:1928:b0:767:2ccf:1e2f with SMTP id bj40-20020a05620a192800b007672ccf1e2fmr14538433qkb.57.1688430627656; Mon, 03 Jul 2023 17:30:27 -0700 (PDT) Original-Received: from laptop ([2601:84:847f:c697:2d4:9eff:feb6:970c]) by smtp.gmail.com with ESMTPSA id i21-20020a05620a075500b007677f66b160sm195555qki.124.2023.07.03.17.30.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 17:30:27 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::734; envelope-from=iarchivedmywholelife@gmail.com; helo=mail-qk1-x734.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264554 Archived-At: --=-=-= Content-Type: text/plain; format=flowed Unless there is good reason not to use special-mode, it'd be nice to have the typical special-mode bindings (quit-window especially) in these buffers. Rough draft patch attached. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-comp.el-use-special-mode-for-log-buffers.patch >From d2aad9faf904bfd197e0dd30a178f1bf05821c0c Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Mon, 3 Jul 2023 20:23:00 -0400 Subject: [PATCH] * comp.el: use special-mode for log buffers (comp-log-to-buffer): ensure comp-log-buffer in special-mode (comp-run-async-workers): ensure comp-async-buffer in special-mode --- lisp/emacs-lisp/comp.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 22fb08e4688..20aee2006fa 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -1133,7 +1133,7 @@ comp-log-to-buffer (log-buffer (or (get-buffer comp-log-buffer-name) (with-current-buffer (get-buffer-create comp-log-buffer-name) - (setf buffer-read-only t) + (unless (derived-mode-p 'special-mode) (special-mode)) (current-buffer)))) (log-window (get-buffer-window log-buffer)) (inhibit-read-only t) @@ -4085,7 +4085,8 @@ comp-run-async-workers :buffer (with-current-buffer (get-buffer-create comp-async-buffer-name) - (setf buffer-read-only t) + (unless (derived-mode-p 'special-mode) + (special-mode)) (current-buffer)) :command (list (expand-file-name invocation-name @@ -4119,6 +4120,7 @@ comp-run-async-workers (run-hooks 'native-comp-async-all-done-hook) (with-current-buffer (get-buffer-create comp-async-buffer-name) (save-excursion + (unless (derived-mode-p 'special-mode) (special-mode)) (let ((inhibit-read-only t)) (goto-char (point-max)) (insert "Compilation finished.\n")))) -- 2.41.0 --=-=-=--