From: Eli Zaretskii <eliz@gnu.org>
To: Andrea Corallo <acorallo@gnu.org>
Cc: 64452-done@debbugs.gnu.org, iarchivedmywholelife@gmail.com,
monnier@iro.umontreal.ca
Subject: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log*
Date: Thu, 06 Jul 2023 11:52:02 +0300 [thread overview]
Message-ID: <83bkgpifrh.fsf@gnu.org> (raw)
In-Reply-To: <yp1ilay5sa4.fsf@fencepost.gnu.org> (message from Andrea Corallo on Wed, 05 Jul 2023 10:47:47 -0400)
> From: Andrea Corallo <acorallo@gnu.org>
> Cc: No Wayman <iarchivedmywholelife@gmail.com>, monnier@iro.umontreal.ca,
> 64452@debbugs.gnu.org
> Date: Wed, 05 Jul 2023 10:47:47 -0400
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: No Wayman <iarchivedmywholelife@gmail.com>
> >> Cc: Andrea Corallo <acorallo@gnu.org>, Stefan Monnier
> >> <monnier@iro.umontreal.ca>, 64452@debbugs.gnu.org
> >> Date: Tue, 04 Jul 2023 18:21:00 -0400
> >>
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >>
> >> > Thanks, but why not elisp-compile-mode, like we do in
> >> > *Compile-log*
> >> > buffers for byte compilation?
> >>
> >> Works for me. Revision attached.
> >>
> >> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
> >> index 22fb08e4688..5f42d10407f 100644
> >> --- a/lisp/emacs-lisp/comp.el
> >> +++ b/lisp/emacs-lisp/comp.el
> >> @@ -1133,7 +1133,8 @@ comp-log-to-buffer
> >> (log-buffer
> >> (or (get-buffer comp-log-buffer-name)
> >> (with-current-buffer (get-buffer-create comp-log-buffer-name)
> >> - (setf buffer-read-only t)
> >> + (unless (derived-mode-p 'emacs-lisp-compilation-mode)
> >> + (emacs-lisp-compilation-mode))
> >
> > bytecomp.el uses
> >
> > (unless (derived-mode-p 'compilation-mode)
> > (emacs-lisp-compilation-mode))
> >
> > Isn't that better?
> >
> > Also, do we really need to do this twice in comp-run-async-workers?
> >
> > Andrea, any comments?
>
> No, haven't tried it but it LGTM form here.
Thanks, installed on the master branch, and closing the bug.
prev parent reply other threads:[~2023-07-06 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 0:13 bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* No Wayman
2023-07-04 11:02 ` Eli Zaretskii
2023-07-04 22:21 ` No Wayman
2023-07-05 11:25 ` Eli Zaretskii
2023-07-05 12:52 ` iarchivedmywholelife
2023-07-05 14:47 ` Andrea Corallo
2023-07-06 8:52 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkgpifrh.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64452-done@debbugs.gnu.org \
--cc=acorallo@gnu.org \
--cc=iarchivedmywholelife@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).