From: iarchivedmywholelife <iarchivedmywholelife@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 64452@debbugs.gnu.org, acorallo@gnu.org, monnier@iro.umontreal.ca
Subject: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log*
Date: Wed, 05 Jul 2023 08:52:44 -0400 [thread overview]
Message-ID: <64a5679e.050a0220.42b7d.2a4a@mx.google.com> (raw)
In-Reply-To: <83lefuk3b7.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]
Feel free to alter the patch as you see fit.I have no more time to invest in it.
-------- Original message --------From: Eli Zaretskii <eliz@gnu.org> Date: 7/5/23 7:25 AM (GMT-05:00) To: No Wayman <iarchivedmywholelife@gmail.com> Cc: acorallo@gnu.org, monnier@iro.umontreal.ca, 64452@debbugs.gnu.org Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* > From: No Wayman <iarchivedmywholelife@gmail.com>> Cc: Andrea Corallo <acorallo@gnu.org>, Stefan Monnier> <monnier@iro.umontreal.ca>, 64452@debbugs.gnu.org> Date: Tue, 04 Jul 2023 18:21:00 -0400> > Eli Zaretskii <eliz@gnu.org> writes:> > > Thanks, but why not elisp-compile-mode, like we do in > > *Compile-log*> > buffers for byte compilation?> > Works for me. Revision attached.> > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el> index 22fb08e4688..5f42d10407f 100644> --- a/lisp/emacs-lisp/comp.el> +++ b/lisp/emacs-lisp/comp.el> @@ -1133,7 +1133,8 @@ comp-log-to-buffer> (log-buffer> (or (get-buffer comp-log-buffer-name)> (with-current-buffer (get-buffer-create comp-log-buffer-name)> - (setf buffer-read-only t)> + (unless (derived-mode-p 'emacs-lisp-compilation-mode)> + (emacs-lisp-compilation-mode))bytecomp.el uses (unless (derived-mode-p 'compilation-mode) (emacs-lisp-compilation-mode))Isn't that better?Also, do we really need to do this twice in comp-run-async-workers?Andrea, any comments?
[-- Attachment #2: Type: text/html, Size: 2639 bytes --]
next prev parent reply other threads:[~2023-07-05 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 0:13 bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* No Wayman
2023-07-04 11:02 ` Eli Zaretskii
2023-07-04 22:21 ` No Wayman
2023-07-05 11:25 ` Eli Zaretskii
2023-07-05 12:52 ` iarchivedmywholelife [this message]
2023-07-05 14:47 ` Andrea Corallo
2023-07-06 8:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64a5679e.050a0220.42b7d.2a4a@mx.google.com \
--to=iarchivedmywholelife@gmail.com \
--cc=64452@debbugs.gnu.org \
--cc=acorallo@gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).