unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 38195@debbugs.gnu.org
Subject: bug#38195: 27.0.50; `edebug-remove-instrumentation' doesn't work for adviced functions
Date: Wed, 27 Nov 2019 13:17:51 +0100	[thread overview]
Message-ID: <87r21tecnk.fsf@gnus.org> (raw)
In-Reply-To: <87a78iuzbn.fsf@web.de> (Michael Heerdegen's message of "Tue, 26 Nov 2019 22:01:32 +0100")

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Michael Heerdegen <michael_heerdegen@web.de> writes:
>
>> BTW, I also wonder if we should enhance the command
>> `edebug-remove-instrumentation' so that it is able to reload source
>> files.  It could look at the SYMOL's `symbol-file's, collect these, load
>> the files, and only do what it does now for the symbols that are still
>> wrapped.
>
> Here is a draft.  Any thoughts (Lars)?

[...]

> +(defcustom edebug-reload-files 'ask
> +  "Whether `edebug-remove-instrumentation' should reload files.
> +
> +When non-nil, `edebug-remove-instrumentation' will reload files
> +where possible to get rid of instrumentation.  When the non-nil
> +value is the symbol 'ask, ask for every individual file before
> +loading it.

I don't think this is something that should be mixed up with the
edebug-remove-instrumentation command.  Reloading files can have other
side effects, and those may get in the way.  The user just wants the
edebugging to go away so that they can continue to use Emacs, not change
other bits.

But adding a new command like edebug-reload-instrumented-files would be
OK.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-11-27 12:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 13:55 bug#38195: 27.0.50; `edebug-remove-instrumentation' doesn't work for adviced functions Michael Heerdegen
2019-11-14  5:20 ` Lars Ingebrigtsen
2019-11-14 16:51   ` Michael Heerdegen
2019-11-14 22:39     ` Michael Heerdegen
2019-11-15  7:57       ` Lars Ingebrigtsen
2019-11-15 12:39         ` Michael Heerdegen
2019-11-16  4:28           ` Lars Ingebrigtsen
2019-11-16 12:25             ` Michael Heerdegen
2019-11-14 16:55   ` Michael Heerdegen
2019-11-14 19:08     ` Stefan Monnier
2019-11-14 20:27       ` Michael Heerdegen
2019-11-14 21:33         ` Stefan Monnier
2019-11-15 13:54         ` Michael Heerdegen
2019-11-15 17:30           ` Stefan Monnier
2019-11-17 12:35             ` Michael Heerdegen
2019-11-17 12:55           ` Michael Heerdegen
2019-11-17 16:04             ` Stefan Monnier
2019-11-21 11:49               ` Michael Heerdegen
2019-11-23 13:32                 ` Michael Heerdegen
2019-11-26 21:01                 ` Michael Heerdegen
2019-11-27 12:17                   ` Lars Ingebrigtsen [this message]
2020-09-20 10:54                     ` Lars Ingebrigtsen
2019-11-14 21:15   ` Michael Heerdegen
2019-11-15  8:03     ` Lars Ingebrigtsen
2019-11-15 12:11       ` Michael Heerdegen
2019-11-15 12:15         ` Lars Ingebrigtsen
2019-11-15 12:34           ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r21tecnk.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=38195@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).