From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38195: 27.0.50; `edebug-remove-instrumentation' doesn't work for adviced functions Date: Wed, 27 Nov 2019 13:17:51 +0100 Message-ID: <87r21tecnk.fsf@gnus.org> References: <87mucz98y9.fsf@web.de> <87r22brq3b.fsf@gnus.org> <87eeya9z3z.fsf@web.de> <87imnm4315.fsf@web.de> <87eey9z1mr.fsf@web.de> <87o8xaoe6j.fsf@web.de> <877e3t78l5.fsf@web.de> <87a78iuzbn.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="142608"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Monnier , 38195@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 27 13:19:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZwHj-000axE-53 for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Nov 2019 13:19:07 +0100 Original-Received: from localhost ([::1]:37606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZwHi-00078t-2I for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Nov 2019 07:19:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53637) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZwGi-0006ow-4Y for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 07:18:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZwGg-0006JZ-Vd for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 07:18:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZwGg-0006JV-S2 for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 07:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZwGg-0003HK-OQ for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 07:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Nov 2019 12:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38195 X-GNU-PR-Package: emacs Original-Received: via spool by 38195-submit@debbugs.gnu.org id=B38195.157485708212586 (code B ref 38195); Wed, 27 Nov 2019 12:18:02 +0000 Original-Received: (at 38195) by debbugs.gnu.org; 27 Nov 2019 12:18:02 +0000 Original-Received: from localhost ([127.0.0.1]:53591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZwGf-0003Gt-Mt for submit@debbugs.gnu.org; Wed, 27 Nov 2019 07:18:02 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:55478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZwGe-0003GX-1J for 38195@debbugs.gnu.org; Wed, 27 Nov 2019 07:18:00 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iZwGW-0001Ru-4c; Wed, 27 Nov 2019 13:17:54 +0100 In-Reply-To: <87a78iuzbn.fsf@web.de> (Michael Heerdegen's message of "Tue, 26 Nov 2019 22:01:32 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172528 Archived-At: Michael Heerdegen writes: > Michael Heerdegen writes: > >> BTW, I also wonder if we should enhance the command >> `edebug-remove-instrumentation' so that it is able to reload source >> files. It could look at the SYMOL's `symbol-file's, collect these, load >> the files, and only do what it does now for the symbols that are still >> wrapped. > > Here is a draft. Any thoughts (Lars)? [...] > +(defcustom edebug-reload-files 'ask > + "Whether `edebug-remove-instrumentation' should reload files. > + > +When non-nil, `edebug-remove-instrumentation' will reload files > +where possible to get rid of instrumentation. When the non-nil > +value is the symbol 'ask, ask for every individual file before > +loading it. I don't think this is something that should be mixed up with the edebug-remove-instrumentation command. Reloading files can have other side effects, and those may get in the way. The user just wants the edebugging to go away so that they can continue to use Emacs, not change other bits. But adding a new command like edebug-reload-instrumented-files would be OK. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no