From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 38195@debbugs.gnu.org
Subject: bug#38195: 27.0.50; `edebug-remove-instrumentation' doesn't work for adviced functions
Date: Thu, 14 Nov 2019 14:08:24 -0500 [thread overview]
Message-ID: <jwva78y70fq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87eeya9z3z.fsf@web.de> (Michael Heerdegen's message of "Thu, 14 Nov 2019 17:55:28 +0100")
> +(defun edebug--advised-p (symbol)
> + ;; Non-nil when SYMBOL's `symbol-function' is advised. The non-nil
> + ;; return value is the unwrapped base function if it was wrapped,
> + ;; and the symbol t else.
Do you really mean "advised"? It seems that this tests whether the code
is *instrumented* by looking past the (potential) pieces of advice.
I'll assume the above should say "instrumented", but if not, then
disregard the rest because I'm just confused.
> + (pcase (symbol-function symbol)
> + ((and (pred advice--p)
> + (app advice--cd*r orig-f)
> + (let unwrapped (edebug-unwrap* orig-f)))
> + (if (equal unwrapped orig-f) t unwrapped))
> + (`(macro . ,(and (pred advice--p)
> + (app advice--cd*r orig-f)
> + (let unwrapped (edebug-unwrap* orig-f))))
> + (if (equal unwrapped orig-f) t `(macro . ,unwrapped)))))
[ That's pretty ugly. I think I'd move the `app` and the `let` outside
of those patterns and into the code of the corresponding branch. ]
> - (let ((unwrapped (edebug-unwrap* (symbol-function symbol))))
> - (unless (equal unwrapped (symbol-function symbol))
> - (push symbol functions)))))
> + (if-let ((advised (edebug--advised-p symbol)))
> + (unless (eq advised t)
> + (push symbol functions))
> + (let ((unwrapped (edebug-unwrap*
> + (symbol-function symbol))))
> + (unless (equal unwrapped (symbol-function symbol))
> + (push symbol functions))))))
How 'bout using something like
(defun edebug--symbol-function (sym)
(let ((def (symbol-function sym)))
(if (eq 'macro (car-safe def))
(setq def (cdr def)))
(advice--cdr* def)))
and replacing (some) uses of `symbol-function` with it?
> ;; Remove instrumentation.
> (dolist (symbol functions)
> - (setf (symbol-function symbol)
> - (edebug-unwrap* (symbol-function symbol))))
> + (if-let ((advised (edebug--advised-p symbol)))
> + (unless (eq advised t)
> + (funcall (or (get symbol 'defalias-fset-function) #'fset)
> + symbol advised))
> + (setf (symbol-function symbol)
> + (edebug-unwrap* (symbol-function symbol)))))
Yuck!
Can't we just use `defalias` rather than `fset` (and that should
take care of calling `defalias-fset-function` when needed)?
> I'm not sure if I should use `indirect-function' somewhere instead of
> `symbol-function',
That's a question for Edebug's ;-)
In the above I assumed that there's a good reason why it uses
`symbol-function` so I preserved it.
> but I also don't understand (and also didn't yet try to find out) why
> nadvice doesn't use `indirect-function' for its manipulations.
That's because if I have `foo` as an alias for `bar` and I advise `foo`
I don't want it to affect `bar`: if you want to affect both, then you
should advise `bar`.
Stefan
next prev parent reply other threads:[~2019-11-14 19:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 13:55 bug#38195: 27.0.50; `edebug-remove-instrumentation' doesn't work for adviced functions Michael Heerdegen
2019-11-14 5:20 ` Lars Ingebrigtsen
2019-11-14 16:51 ` Michael Heerdegen
2019-11-14 22:39 ` Michael Heerdegen
2019-11-15 7:57 ` Lars Ingebrigtsen
2019-11-15 12:39 ` Michael Heerdegen
2019-11-16 4:28 ` Lars Ingebrigtsen
2019-11-16 12:25 ` Michael Heerdegen
2019-11-14 16:55 ` Michael Heerdegen
2019-11-14 19:08 ` Stefan Monnier [this message]
2019-11-14 20:27 ` Michael Heerdegen
2019-11-14 21:33 ` Stefan Monnier
2019-11-15 13:54 ` Michael Heerdegen
2019-11-15 17:30 ` Stefan Monnier
2019-11-17 12:35 ` Michael Heerdegen
2019-11-17 12:55 ` Michael Heerdegen
2019-11-17 16:04 ` Stefan Monnier
2019-11-21 11:49 ` Michael Heerdegen
2019-11-23 13:32 ` Michael Heerdegen
2019-11-26 21:01 ` Michael Heerdegen
2019-11-27 12:17 ` Lars Ingebrigtsen
2020-09-20 10:54 ` Lars Ingebrigtsen
2019-11-14 21:15 ` Michael Heerdegen
2019-11-15 8:03 ` Lars Ingebrigtsen
2019-11-15 12:11 ` Michael Heerdegen
2019-11-15 12:15 ` Lars Ingebrigtsen
2019-11-15 12:34 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva78y70fq.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=38195@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).